5.0.4 with all patches -> compile error on 64bit

5.0.4 with all patches -> compile error on 64bit

[Nail El-Sourani]

hi everyone,

trying to compile latest source code from
kernel.org/pub/linux/daemons/autofs/v5 with ALL patches applied as of today.

./configure works
make gives error:

...
gcc -O2 -Wall -D_REENTRANT -D_FILE_OFFSET_BITS=64 -rdynamic -fPIE
-D_GNU_SOURCE -I../include -DAUTOFS_LIB_DIR=\"/usr/lib/autofs\" 
-DAUTOFS_MAP_DIR=\"/etc\" -DAUTOFS_CONF_DIR=\"/etc/sysconfig\"
-DAUTOFS_FIFO_DIR=\"/var/run\" -DAUTOFS_FLAG_DIR=\"/var/run\"
-DVERSION_STRING=\"5.0.4\" -c flag.c
gcc -s -lpthread -rdynamic -pie -o automount automount.o indirect.o
direct.o spawn.o module.o mount.o lookup.o state.o flag.o
../lib/autofs.a -ldl
../lib/autofs.a(master_tok.o): In function `master_set_scan_buffer':
master_tok.c:(.text+0x257): undefined reference to `master_lex_destroy'
collect2: ld gab 1 als Ende-Status zurück
make[1]: *** [automount] Fehler 1
make[1]: Leaving directory `/root/Desktop/autofs-5.0.4/daemon'
make: *** [daemon] Fehler 2


(these are the last few lines)

i am suspecting a problem with 64bit but then again, what do i know...
this is a centos5.3 64bit machine

kind regards,
*nail el-Sourani

Re: 5.0.4 with all patches -> compile error on 64bit

[Ian Kent]

Nail El-Sourani wrote:
> hi everyone,
> 
> trying to compile latest source code from
> kernel.org/pub/linux/daemons/autofs/v5 with ALL patches applied as of today.
> 
> ./configure works
> make gives error:
> 
> ...
> gcc -O2 -Wall -D_REENTRANT -D_FILE_OFFSET_BITS=64 -rdynamic -fPIE
> -D_GNU_SOURCE -I../include -DAUTOFS_LIB_DIR=\"/usr/lib/autofs\" 
> -DAUTOFS_MAP_DIR=\"/etc\" -DAUTOFS_CONF_DIR=\"/etc/sysconfig\"
> -DAUTOFS_FIFO_DIR=\"/var/run\" -DAUTOFS_FLAG_DIR=\"/var/run\"
> -DVERSION_STRING=\"5.0.4\" -c flag.c
> gcc -s -lpthread -rdynamic -pie -o automount automount.o indirect.o
> direct.o spawn.o module.o mount.o lookup.o state.o flag.o
> ../lib/autofs.a -ldl
> ../lib/autofs.a(master_tok.o): In function `master_set_scan_buffer':
> master_tok.c:(.text+0x257): undefined reference to `master_lex_destroy'
> collect2: ld gab 1 als Ende-Status zurück
> make[1]: *** [automount] Fehler 1
> make[1]: Leaving directory `/root/Desktop/autofs-5.0.4/daemon'
> make: *** [daemon] Fehler 2
> 
> 
> (these are the last few lines)
> 
> i am suspecting a problem with 64bit but then again, what do i know...
> this is a centos5.3 64bit machine

OK I'll fix that.
I think it's the Lexx version what is too old.

I need to check this further but replacing
autofs-5.0.4-reset-flex-scanner-when-setting-buffer.patch with this may
help.

autofs-5.0.1 - clear flex buff before scan

From: Ian Kent <raven@themaw.net>

If the flex scanner buffer isn't initialized we can get incorrect
token values passed back to the parser so clear it for before
each parse.
--- autofs-5.0.1.orig/lib/master_tok.l
+++ autofs-5.0.1/lib/master_tok.l
@@ -412,6 +412,8 @@ static void master_echo(void)

 void master_set_scan_buffer(const char *buffer)
 {
+       memset(buff, 0, sizeof(buff));
+
        line = buffer;
        line_pos = &line[0];
        /*

Re: 5.0.4 with all patches -> compile error on 64bit

[Ian Kent]

Ian Kent wrote:
>> ...
>> gcc -O2 -Wall -D_REENTRANT -D_FILE_OFFSET_BITS=64 -rdynamic -fPIE
>> -D_GNU_SOURCE -I../include -DAUTOFS_LIB_DIR=\"/usr/lib/autofs\" 
>> -DAUTOFS_MAP_DIR=\"/etc\" -DAUTOFS_CONF_DIR=\"/etc/sysconfig\"
>> -DAUTOFS_FIFO_DIR=\"/var/run\" -DAUTOFS_FLAG_DIR=\"/var/run\"
>> -DVERSION_STRING=\"5.0.4\" -c flag.c
>> gcc -s -lpthread -rdynamic -pie -o automount automount.o indirect.o
>> direct.o spawn.o module.o mount.o lookup.o state.o flag.o
>> ../lib/autofs.a -ldl
>> ../lib/autofs.a(master_tok.o): In function `master_set_scan_buffer':
>> master_tok.c:(.text+0x257): undefined reference to `master_lex_destroy'
>> collect2: ld gab 1 als Ende-Status zurück
>> make[1]: *** [automount] Fehler 1
>> make[1]: Leaving directory `/root/Desktop/autofs-5.0.4/daemon'
>> make: *** [daemon] Fehler 2
>>
>>
>> (these are the last few lines)
>>
>> i am suspecting a problem with 64bit but then again, what do i know...
>> this is a centos5.3 64bit machine
> 
> OK I'll fix that.
> I think it's the Lexx version what is too old.

But then again maybe not, the flex version is just to old, I'm not sure
that the bleeding edge upstream source should make compromises for older
flex versions. The function master_lex_destroy() (actually yy... since
this is a multiple parser lexer) does more than just clear the user
parse buffer, and the 5.0.4 patch does a couple of other things as well.

A configure change and some #ifdef ugliness might do the trick I guess.
Not looking forward to doing that!

Ian