All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Miller <davem@davemloft.net>,
	JBeulich@novell.com, andi@firstfloor.org, mingo@elte.hu,
	hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	x86@kernel.org, ink@jurassic.park.msu.ru, rth@twiddle.net,
	linux@arm.linux.org.uk, hskinnemoen@atmel.com,
	cooloney@kernel.org, starvik@axis.com, jesper.nilsson@axis.com,
	dhowells@redhat.com, ysato@users.sourceforge.jp,
	tony.luck@intel.com, takata@linux-m32r.org, geert@linux-m68k.org,
	monstr@monstr.eu, ralf@linux-mips.org, kyle@mcmartin.ca,
	paulus@samba.org, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com, lethal@linux-sh.org,
	jdike@addtoit.com, chris@zankel.net, rusty@rustcorp.com.au,
	jens.axboe@oracle.com, davej@redhat.com, jeremy@xensource.com,
	linux-mm@kvack.org
Subject: Re: [PATCH 3/7] percpu: clean up percpu variable definitions
Date: Fri, 05 Jun 2009 13:25:30 +0900	[thread overview]
Message-ID: <4A289E3A.30000@kernel.org> (raw)
In-Reply-To: <1243919336.5308.32.camel@pasglop>

Benjamin Herrenschmidt wrote:
> On Mon, 2009-06-01 at 20:36 +0900, Tejun Heo wrote:
>>> Whether the volatile is actually needed or not, it's bad to have this
>>> kind of potential behavior changing nugget hidden in this seemingly
>>> inocuous change.  Especially if you're the poor soul who ends up
>>> having to debug it :-/
>> You're right.  Aieee... how do I feed volatile to the DEFINE macro.
>> I'll think of something.
> 
> Or better, work with the cris maintainer to figure out whether it's
> needed (it probably isn't) and have a pre-requisite patch that removes
> it before your series :-)

Yeap, that's worth giving a shot.

Mikael Starvik, can you please enlighten us why volatile is necessary
there?

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: David Miller <davem@davemloft.net>,
	JBeulich@novell.com, andi@firstfloor.org, mingo@elte.hu,
	hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	x86@kernel.org, ink@jurassic.park.msu.ru, rth@twiddle.net,
	linux@arm.linux.org.uk, hskinnemoen@atmel.com,
	cooloney@kernel.org, starvik@axis.com, jesper.nilsson@axis.com,
	dhowells@redhat.com, ysato@users.sourceforge.jp,
	tony.luck@intel.com, takata@linux-m32r.org, geert@linux-m68k.org,
	monstr@monstr.eu, ralf@linux-mips.org, kyle@mcmartin.ca,
	paulus@samba.org, schwidefsky@de.ibm.com,
	heiko.carstens@de.ibm.com, lethal@linux-sh.org,
	jdike@addtoit.com, chris@zankel.net, rusty@rustcorp.com.au,
	jens.axboe@oracle.com, davej@redhat.com, jeremy@xensource.com,
	linux-mm@kvack.org
Subject: Re: [PATCH 3/7] percpu: clean up percpu variable definitions
Date: Fri, 05 Jun 2009 13:25:30 +0900	[thread overview]
Message-ID: <4A289E3A.30000@kernel.org> (raw)
In-Reply-To: <1243919336.5308.32.camel@pasglop>

Benjamin Herrenschmidt wrote:
> On Mon, 2009-06-01 at 20:36 +0900, Tejun Heo wrote:
>>> Whether the volatile is actually needed or not, it's bad to have this
>>> kind of potential behavior changing nugget hidden in this seemingly
>>> inocuous change.  Especially if you're the poor soul who ends up
>>> having to debug it :-/
>> You're right.  Aieee... how do I feed volatile to the DEFINE macro.
>> I'll think of something.
> 
> Or better, work with the cris maintainer to figure out whether it's
> needed (it probably isn't) and have a pre-requisite patch that removes
> it before your series :-)

Yeap, that's worth giving a shot.

Mikael Starvik, can you please enlighten us why volatile is necessary
there?

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-06-05  4:28 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-01  8:58 [GIT PATCH core/percpu] percpu: convert most archs to dynamic percpu, take#2 Tejun Heo
2009-06-01  8:58 ` [PATCH 1/7] percpu: use dynamic percpu allocator as the default percpu allocator Tejun Heo
2009-06-01  8:58 ` [PATCH 2/7] percpu: cleanup percpu array definitions Tejun Heo
2009-06-01  8:58   ` Tejun Heo
2009-06-01  8:58 ` [PATCH 3/7] percpu: clean up percpu variable definitions Tejun Heo
2009-06-01  8:58   ` Tejun Heo
2009-06-01  9:40   ` David Miller
2009-06-01  9:40     ` David Miller
2009-06-01 11:36     ` Tejun Heo
2009-06-01 11:36       ` Tejun Heo
2009-06-02  5:08       ` Benjamin Herrenschmidt
2009-06-02  5:08         ` Benjamin Herrenschmidt
2009-06-05  4:25         ` Tejun Heo [this message]
2009-06-05  4:25           ` Tejun Heo
2009-06-11 10:45           ` Jesper Nilsson
2009-06-17  2:28             ` Tejun Heo
2009-06-10 18:30     ` H. Peter Anvin
2009-06-10 18:30       ` H. Peter Anvin
2009-06-01  8:58 ` [PATCH 4/7] percpu: enforce global definition Tejun Heo
2009-06-01  8:58 ` [PATCH 5/7] alpha: kill unnecessary __used attribute in PER_CPU_ATTRIBUTES Tejun Heo
2009-06-01  8:58 ` [PATCH 6/7] alpha: switch to dynamic percpu allocator Tejun Heo
2009-06-01  8:58 ` [PATCH 7/7] s390: " Tejun Heo
2009-06-01 16:10 ` [GIT PATCH core/percpu] percpu: convert most archs to dynamic percpu, take#2 Kyle McMartin
2009-06-01 19:51   ` Kyle McMartin
2009-06-05  4:24     ` Tejun Heo
2009-06-02  6:35 ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2009-05-20  7:37 [PATCHSET core/percpu] percpu: convert most archs to dynamic percpu Tejun Heo
2009-05-20  7:37 ` [PATCH 3/7] percpu: clean up percpu variable definitions Tejun Heo
2009-05-20  7:37   ` Tejun Heo
2009-05-20  9:17   ` Jens Axboe
2009-05-20  9:17     ` Jens Axboe
2009-05-25  6:07   ` Rusty Russell
2009-05-25  6:07     ` Rusty Russell
2009-05-25 16:07     ` Tejun Heo
2009-05-25 16:07       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A289E3A.30000@kernel.org \
    --to=tj@kernel.org \
    --cc=JBeulich@novell.com \
    --cc=andi@firstfloor.org \
    --cc=benh@kernel.crashing.org \
    --cc=chris@zankel.net \
    --cc=cooloney@kernel.org \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=hskinnemoen@atmel.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jdike@addtoit.com \
    --cc=jens.axboe@oracle.com \
    --cc=jeremy@xensource.com \
    --cc=jesper.nilsson@axis.com \
    --cc=kyle@mcmartin.ca \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mingo@elte.hu \
    --cc=monstr@monstr.eu \
    --cc=paulus@samba.org \
    --cc=ralf@linux-mips.org \
    --cc=rth@twiddle.net \
    --cc=rusty@rustcorp.com.au \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.