From: Stephen Boyd <bebarino@gmail.com>
To: git list <git@vger.kernel.org>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>,
"Junio C Hamano" <gitster@pobox.com>
Subject: parse-options: ambiguous LASTARG_DEFAULT and OPTARG
Date: Thu, 04 Jun 2009 22:43:14 -0700 [thread overview]
Message-ID: <4A28B072.8030006@gmail.com> (raw)
Hi,
This in builtin-branch.c
{
OPTION_CALLBACK, 0, "merged", &merge_filter_ref,
"commit", "print only merged branches",
PARSE_OPT_LASTARG_DEFAULT | PARSE_OPT_NONEG,
opt_parse_merge_filter, (intptr_t) "HEAD",
},
and the usage message for "git-branch -h" will print out
--merged <commit>
when I'm expecting
--merged[=<commit>]
This is because the PARSE_OPT_OPTARG flag is not used. Is this correct?
The default value is still set correctly in some cases, but become
ambiguous in other cases. Take this for example
$ git branch --merged --verbose
fatal: malformed object name --verbose
but
$ git branch --verbose --merged
works fine.
The simple fix is to just add PARSE_OPT_OPTARG to the flags, and fix a
test or two. But I'm wondering if doing that will become problematic for
end-users. Essentially you can no longer do git branch --merged master,
you must do git branch --merged=master.
next reply other threads:[~2009-06-05 5:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 5:43 Stephen Boyd [this message]
2009-06-06 10:30 ` parse-options: ambiguous LASTARG_DEFAULT and OPTARG René Scharfe
2009-06-06 20:14 ` Stephen Boyd
2009-06-07 23:39 ` [PATCH] show-branch: don't use LASTARG_DEFAULT with OPTARG Stephen Boyd
2009-06-08 17:24 ` René Scharfe
2009-06-08 21:56 ` Junio C Hamano
2009-06-09 8:23 ` [PATCH] parse-options: add parse_options_check to validate option specs Pierre Habouzit
2009-06-12 19:31 ` Pierre Habouzit
2009-06-12 21:25 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A28B072.8030006@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.