From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Stephen Boyd <bebarino@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git list <git@vger.kernel.org>,
Pierre Habouzit <madcoder@madism.org>
Subject: Re: [PATCH] show-branch: don't use LASTARG_DEFAULT with OPTARG
Date: Mon, 08 Jun 2009 19:24:30 +0200 [thread overview]
Message-ID: <4A2D494E.3030803@lsrfire.ath.cx> (raw)
In-Reply-To: <1244417955-21226-1-git-send-email-bebarino@gmail.com>
Stephen Boyd schrieb:
> 5734365 (show-branch: migrate to parse-options API 2009-05-21)
> incorrectly set the --more option's flags to be
> PARSE_OPT_LASTARG_DEFAULT and PARSE_OPT_OPTARG. These two flags
> shouldn't be used together. An option taking a default should just set
> the default value desired and parse options will take care of the rest.
>
> Update the header comment to better convey this information.
Thank you!
next prev parent reply other threads:[~2009-06-08 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 5:43 parse-options: ambiguous LASTARG_DEFAULT and OPTARG Stephen Boyd
2009-06-06 10:30 ` René Scharfe
2009-06-06 20:14 ` Stephen Boyd
2009-06-07 23:39 ` [PATCH] show-branch: don't use LASTARG_DEFAULT with OPTARG Stephen Boyd
2009-06-08 17:24 ` René Scharfe [this message]
2009-06-08 21:56 ` Junio C Hamano
2009-06-09 8:23 ` [PATCH] parse-options: add parse_options_check to validate option specs Pierre Habouzit
2009-06-12 19:31 ` Pierre Habouzit
2009-06-12 21:25 ` René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2D494E.3030803@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madcoder@madism.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.