From: "Richard Röjfors" <richard.rojfors.ext-l7gf1WXxx3uGw+nKnLezzg@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>,
Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] I2C: ocores can add I2C devices to the bus
Date: Fri, 05 Jun 2009 09:12:57 +0200 [thread overview]
Message-ID: <4A28C579.7090507@mocean-labs.com> (raw)
In-Reply-To: <20090604210243.078aeb2f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
Jean Delvare wrote:
>
> I am now convinced your proposed implementation makes sense for your
> specific need (which is relatively rare, which is why i2c-core doesn't
> handle it.) And contrary to what I first wrote, this doesn't need to be
> moved to i2c-core: this is specific enough that I'd rather let the code
> live in the bus driver (i2c-ocores) for now, and only if at least two
> other bus drivers need the same, consider moving it to i2c-core.
>
> So if you fix the minor objection Ben had about your patch and resend
> it, I think we can merge that.
Will do.
> Oh, and I also believe your driver
> should call i2c_unregister_device() on removal, for symmetry.
Isn't better to leave that to i2c_del_adapter? Otherwise we need to store a list
of the I2C-clients returned by i2c_new_device.
--Richard
next prev parent reply other threads:[~2009-06-05 7:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 17:52 [PATCH] I2C: ocores can add I2C devices to the bus Richard Ršöjfors
[not found] ` <4A2566E8.7080404-l7gf1WXxx3uGw+nKnLezzg@public.gmane.org>
2009-06-02 22:48 ` Ben Dooks
[not found] ` <20090602224822.GE18453-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-03 8:00 ` Richard R?öjfors
2009-06-03 8:15 ` Jean Delvare
[not found] ` <20090603101533.599d41db-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-03 8:22 ` Peter Korsgaard
[not found] ` <87oct53ewh.fsf-uXGAPMMVk8amE9MCos8gUmSdvHPH+/yF@public.gmane.org>
2009-06-03 8:49 ` Jean Delvare
2009-06-03 8:53 ` Richard R?öjfors
[not found] ` <4A2639F6.2010505-l7gf1WXxx3uGw+nKnLezzg@public.gmane.org>
2009-06-04 12:11 ` Richard Ršöjfors
2009-06-04 13:07 ` Jean Delvare
[not found] ` <20090604150752.6aa7668c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-04 14:24 ` Richard Ršöjfors
[not found] ` <4A27D91E.1000306-l7gf1WXxx3uGw+nKnLezzg@public.gmane.org>
2009-06-04 14:41 ` Mark Brown
2009-06-04 19:02 ` Jean Delvare
[not found] ` <20090604210243.078aeb2f-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2009-06-05 7:12 ` Richard Röjfors [this message]
[not found] ` <4A28C579.7090507-l7gf1WXxx3uGw+nKnLezzg@public.gmane.org>
2009-06-05 11:54 ` Jean Delvare
2009-06-13 9:38 ` Ben Dooks
[not found] ` <20090613093830.GD20446-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2009-06-13 9:39 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A28C579.7090507@mocean-labs.com \
--to=richard.rojfors.ext-l7gf1wxxx3ugw+nknlezzg@public.gmane.org \
--cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
--cc=jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.