Re: [PATCH] I2C: ocores can add I2C devices to the bus

[Peter Korsgaard <jacmet-OfajU3CKLf1/SzgSGea1oA@public.gmane.org>]

>>>>> "Jean" == Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> writes:

Hi,

 Jean> I don't like the idea much either, nor the implementation.

 Jean> Firstly, I don't understand why this would be needed. I can understand
 Jean> that in some cases you don't know the I2C bus number in advance, but
 Jean> then some code must still instantiate the I2C bus, and the same code
 Jean> should be able to call i2c_new_device() directly to instantiate the
 Jean> devices on that bus. Richard, did you try to just do this? If it
 Jean> doesn't work, please explain why.

Indeed. Isn't it just a matter of using i2c_add_numbered_adapter -
E.G.:

--- linux-2.6/drivers/i2c/busses/i2c-ocores.c	2008-11-26 11:16:27.000000000 +0100
+++ linux-2.6-new/drivers/i2c/busses/i2c-ocores.c	2008-12-13 19:59:12.000000000 +0100
@@ -261,11 +261,12 @@
 	/* hook up driver to tree */
 	platform_set_drvdata(pdev, i2c);
 	i2c->adap = ocores_adapter;
+	i2c->adap.nr = pdev->id;
 	i2c_set_adapdata(&i2c->adap, i2c);
 	i2c->adap.dev.parent = &pdev->dev;
 
 	/* add i2c adapter to i2c tree */
-	ret = i2c_add_adapter(&i2c->adap);
+	ret = i2c_add_numbered_adapter(&i2c->adap);
 	if (ret) {
 		dev_err(&pdev->dev, "Failed to add adapter\n");
 		goto add_adapter_failed;

Or am I misunderstanding the issue?

-- 
Bye, Peter Korsgaard