[PATCH] Don't use absolute path for ip, does not always work

[PATCH] Don't use absolute path for ip, does not always work

[Seewer Philippe]

---
diff --git a/modules.d/40network/dhclient-script 
b/modules.d/40network/dhclient-script
index 1ee78fe..d283762 100755
--- a/modules.d/40network/dhclient-script
+++ b/modules.d/40network/dhclient-script
@@ -69,7 +69,7 @@ setup_interface() {

  case $reason in
      PREINIT)
-       run /sbin/ip link set $netif up
+       run ip link set $netif up
         ;;
      BOUND)
         setup_interface
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute path for ip, does not always work

[Bill Nottingham]

Seewer Philippe (philippe.seewer-omB+W0Dpw2o@public.gmane.org) said: 
> ---
> diff --git a/modules.d/40network/dhclient-script  
> b/modules.d/40network/dhclient-script
> index 1ee78fe..d283762 100755
> --- a/modules.d/40network/dhclient-script
> +++ b/modules.d/40network/dhclient-script
> @@ -69,7 +69,7 @@ setup_interface() {
>
>  case $reason in
>      PREINIT)
> -       run /sbin/ip link set $netif up
> +       run ip link set $netif up
>         ;;
>      BOUND)
>         setup_interface

Why does it not always work, unless you're breaking your initramfs?

Bill
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute path for ip, does not always work

[Victor Lowther]

On Jun 5, 2009, at 10:59 AM, Bill Nottingham <notting-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:

> Seewer Philippe (philippe.seewer-omB+W0Dpw2o@public.gmane.org) said:
>> ---
>> diff --git a/modules.d/40network/dhclient-script
>> b/modules.d/40network/dhclient-script
>> index 1ee78fe..d283762 100755
>> --- a/modules.d/40network/dhclient-script
>> +++ b/modules.d/40network/dhclient-script
>> @@ -69,7 +69,7 @@ setup_interface() {
>>
>> case $reason in
>>     PREINIT)
>> -       run /sbin/ip link set $netif up
>> +       run ip link set $netif up
>>        ;;
>>     BOUND)
>>        setup_interface
>
> Why does it not always work, unless you're breaking your initramfs?

What if your distro does not put ip in /sbin?

Besides, hardcoding executable locations when we know we have a sane  
path is silly.

>
>
> Bill
> --
> To unsubscribe from this list: send the line "unsubscribe initramfs"  
> in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute path for ip, does not always work

[Bill Nottingham]

Victor Lowther (victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org) said: 
>> Why does it not always work, unless you're breaking your initramfs?
>
> What if your distro does not put ip in /sbin?

I was under the impression that the generation already put it in
a known place, in which case there's no reason to worry about it
being elsewhere. I checked again, and that's not the case.

Bill
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute path for ip, does not always work

[Victor Lowther]

On Jun 5, 2009, at 12:27 PM, Bill Nottingham <notting-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:

> Victor Lowther (victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org) said:
>>> Why does it not always work, unless you're breaking your initramfs?
>>
>> What if your distro does not put ip in /sbin?
>
> I was under the impression that the generation already put it in
> a known place, in which case there's no reason to worry about it
> being elsewhere. I checked again, and that's not the case.

I should hope so, otherwise writing the install code to be as distro  
agnostic as feasible was all for naught. :)

>
> Bill
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Don't use absolute path for ip, does not always work

[Seewer Philippe]

Victor Lowther wrote:
> On Jun 5, 2009, at 12:27 PM, Bill Nottingham <notting-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> 
>> Victor Lowther (victor.lowther-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org) said:
>>>> Why does it not always work, unless you're breaking your initramfs?
>>>
>>> What if your distro does not put ip in /sbin?
>>
>> I was under the impression that the generation already put it in
>> a known place, in which case there's no reason to worry about it
>> being elsewhere. I checked again, and that's not the case.
> 
> I should hope so, otherwise writing the install code to be as distro 
> agnostic as feasible was all for naught. :)

I guess I should have formulated my post better.

ip get's copied in, no worries. dracut_install ip works perfectly. Since 
it looks everywhere sensible for the utility if no path is provided.

Problem is that debian puts ip in /bin not /sbin. So the code almost 
always works, except for debian.

Regards,
Philippe
--
To unsubscribe from this list: send the line "unsubscribe initramfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html