All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jesper Dangaard Brouer <hawk@comx.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de,
	wg@grandegger.com, vladislav.yasevich@hp.com, sri@us.ibm.com,
	linux-sctp@vger.kernel.org, Trond.Myklebust@netapp.com,
	linux-nfs@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/5] We must use rcu_barrier() on module unload
Date: Mon, 08 Jun 2009 16:00:29 +0200	[thread overview]
Message-ID: <4A2D197D.4060804@trash.net> (raw)
In-Reply-To: <20090608130959.10052.54590.stgit@localhost>

Jesper Dangaard Brouer wrote:
> If an unloadable module uses RCU callbacks, it need to use
> rcu_barrier() so that the module may be safely unloaded.
> 
> While hacking on a netfilter module of my own, I learned the
> importance of calling rcu_barrier() instead of only a
> synchronize_rcu() on module unload (iif using any call_rcu()
> callbacks).  synchronize_rcu() does wait for a grace period to
> elapse, but it does not wait for the callbacks to complete.
> 
> ...
> I have made a patch for each individual module, so objections can be
> made on a per module basis.  I have Cc'ed all of the patches to the
> maintainers of each module (according to the MAINTAINERS file).

Acked-by: Patrick McHardy <kaber@trash.net> for patches 1 and 2, good
catch.

WARNING: multiple messages have this Message-ID (diff)
From: Patrick McHardy <kaber@trash.net>
To: Jesper Dangaard Brouer <hawk@comx.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	urs.thuermann@volkswagen.de, oliver.hartkopp@volkswagen.de,
	wg@grandegger.com, vladislav.yasevich@hp.com, sri@us.ibm.com,
	linux-sctp@vger.kernel.org, Trond.Myklebust@netapp.com,
	linux-nfs@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 0/5] We must use rcu_barrier() on module unload
Date: Mon, 08 Jun 2009 14:00:29 +0000	[thread overview]
Message-ID: <4A2D197D.4060804@trash.net> (raw)
In-Reply-To: <20090608130959.10052.54590.stgit@localhost>

Jesper Dangaard Brouer wrote:
> If an unloadable module uses RCU callbacks, it need to use
> rcu_barrier() so that the module may be safely unloaded.
> 
> While hacking on a netfilter module of my own, I learned the
> importance of calling rcu_barrier() instead of only a
> synchronize_rcu() on module unload (iif using any call_rcu()
> callbacks).  synchronize_rcu() does wait for a grace period to
> elapse, but it does not wait for the callbacks to complete.
> 
> ...
> I have made a patch for each individual module, so objections can be
> made on a per module basis.  I have Cc'ed all of the patches to the
> maintainers of each module (according to the MAINTAINERS file).

Acked-by: Patrick McHardy <kaber@trash.net> for patches 1 and 2, good
catch.

  parent reply	other threads:[~2009-06-08 14:00 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 13:11 [PATCH 0/5] We must use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-08 13:11 ` Jesper Dangaard Brouer
2009-06-08 13:11 ` [PATCH 1/5] 8021q: Vlan driver should use rcu_barrier() on unload instead of syncronize_net() Jesper Dangaard Brouer
2009-06-08 13:11   ` [PATCH 1/5] 8021q: Vlan driver should use rcu_barrier() on unload Jesper Dangaard Brouer
2009-06-08 15:54   ` [PATCH 1/5] 8021q: Vlan driver should use rcu_barrier() on unload instead of syncronize_net() Paul E. McKenney
2009-06-08 15:54     ` [PATCH 1/5] 8021q: Vlan driver should use rcu_barrier() on Paul E. McKenney
2009-06-08 13:11 ` [PATCH 2/5] nfnetlink_queue: Use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-08 13:11   ` Jesper Dangaard Brouer
2009-06-08 16:05   ` Paul E. McKenney
2009-06-08 16:05     ` Paul E. McKenney
2009-06-08 16:05     ` Paul E. McKenney
2009-06-08 16:05     ` [PATCH 2/5] nfnetlink_queue: Use rcu_barrier() on module Paul E. McKenney
2009-06-10  5:38   ` [PATCH 2/5] nfnetlink_queue: Use rcu_barrier() on module unload Andrew Morton
2009-06-10  5:38     ` [PATCH 2/5] nfnetlink_queue: Use rcu_barrier() on module Andrew Morton
2009-06-08 13:11 ` [PATCH 3/5] can: af_can.c use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-08 13:11   ` Jesper Dangaard Brouer
2009-06-08 13:24   ` Oliver Hartkopp
2009-06-08 13:24     ` Oliver Hartkopp
2009-06-10  8:10     ` David Miller
2009-06-10  8:10       ` David Miller
2009-06-10  8:22       ` Oliver Hartkopp
2009-06-10  8:52         ` David Miller
2009-06-10 12:41           ` Jeremy Kerr
2009-06-10 12:41             ` Jeremy Kerr
2009-06-10 16:45             ` David Miller
2009-06-10 16:45               ` David Miller
2009-06-10 10:02       ` Alan Cox
2009-06-10 10:02         ` Alan Cox
2009-06-10 11:33       ` Jan Engelhardt
2009-06-10 11:33         ` Jan Engelhardt
2009-06-08 16:13   ` Paul E. McKenney
2009-06-08 16:13     ` Paul E. McKenney
2009-06-08 17:00     ` Oliver Hartkopp
2009-06-08 17:00       ` Oliver Hartkopp
2009-06-08 13:11 ` [PATCH 4/5] sctp: protocol.c call rcu_barrier() on unload Jesper Dangaard Brouer
2009-06-08 13:11   ` Jesper Dangaard Brouer
2009-06-08 16:22   ` Paul E. McKenney
2009-06-08 16:22     ` Paul E. McKenney
2009-06-09 15:44     ` Vlad Yasevich
2009-06-09 15:44       ` Vlad Yasevich
2009-06-09 15:50       ` Paul E. McKenney
2009-06-09 15:50         ` Paul E. McKenney
2009-06-09 16:26         ` Vlad Yasevich
2009-06-09 16:26           ` Vlad Yasevich
2009-06-09 16:26           ` Vlad Yasevich
2009-06-09 16:26           ` Vlad Yasevich
2009-06-08 13:11 ` [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-08 13:11   ` Jesper Dangaard Brouer
2009-06-08 16:26   ` Paul E. McKenney
2009-06-08 16:26     ` [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module Paul E. McKenney
2009-06-08 17:00     ` [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module unload Trond Myklebust
2009-06-08 17:00       ` Trond Myklebust
2009-06-08 17:00       ` Trond Myklebust
2009-06-08 17:00       ` [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module Trond Myklebust
     [not found]       ` <1244480449.5040.4.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-06-08 19:48         ` [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-08 19:48           ` Jesper Dangaard Brouer
2009-06-08 19:48           ` Jesper Dangaard Brouer
2009-06-08 19:48           ` Jesper Dangaard Brouer
2009-06-08 21:13           ` [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module Paul E. McKenney
2009-06-08 21:13             ` [PATCH 5/5] sunrpc/auth_gss: Call rcu_barrier() on module unload Paul E. McKenney
2009-06-08 14:00 ` Patrick McHardy [this message]
2009-06-08 14:00   ` [PATCH 0/5] We must use " Patrick McHardy
2009-06-10  8:11 ` David Miller
2009-06-10  8:11   ` David Miller
2009-06-10  8:11   ` David Miller
2009-06-10  8:11   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2D197D.4060804@trash.net \
    --to=kaber@trash.net \
    --cc=Trond.Myklebust@netapp.com \
    --cc=davem@davemloft.net \
    --cc=hawk@comx.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=oliver.hartkopp@volkswagen.de \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=sri@us.ibm.com \
    --cc=urs.thuermann@volkswagen.de \
    --cc=vladislav.yasevich@hp.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.