All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uri Lublin <uril@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] exec-migration: handle EINTR in popen_get_buffer()
Date: Tue, 09 Jun 2009 13:49:17 +0300	[thread overview]
Message-ID: <4A2E3E2D.1030401@redhat.com> (raw)
In-Reply-To: <f43fc5580906080955i19ad85a5m141b6d2c01d14684@mail.gmail.com>

On 06/08/2009 07:55 PM, Blue Swirl wrote:
> On 6/8/09, Uri Lublin<uril@redhat.com>  wrote:
>> Sometimes, upon interrupt, fread returns with no data, and
>>   the (incoming exec) migration fails.
>>
>>   Fix by retrying on such a case.
>
> Maybe a better solution would be to introduce qemu_{f,}{read,write},
> which handle EINTR and partial reads/writes.
>
>

The migration code does not care about partial reads/writes (at this level). 
Data is read /written to/from a buffer. When needed/available we retry.

I can introduce qemu_{f,}{read,write} which only takes care of EINTR (by 
retrying) but the caller would have to handle partial reads/writes (and EAGAIN). 
Would that be helpful ?

Thanks,
     Uri.

  reply	other threads:[~2009-06-09 10:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 16:27 [Qemu-devel] [PATCH] exec-migration: handle EINTR in popen_get_buffer() Uri Lublin
2009-06-08 16:55 ` Blue Swirl
2009-06-09 10:49   ` Uri Lublin [this message]
2009-06-09 14:51     ` Blue Swirl
2009-06-08 17:54 ` Michael S. Tsirkin
2009-06-09 12:20   ` Michael S. Tsirkin
2009-06-09 12:32   ` Uri Lublin
  -- strict thread matches above, loose matches on Subject: below --
2009-06-02 16:49 Uri Lublin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2E3E2D.1030401@redhat.com \
    --to=uril@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.