All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	linux-raid@vger.kernel.org, Jens
Subject: RFC: Adding new block layer error codes
Date: Thu, 11 Jun 2009 16:16:57 -0500	[thread overview]
Message-ID: <4A317449.4040602@cs.wisc.edu> (raw)

Hi,

Sorry to cc so many FS guys. I am a lowly SCSI guy :), so I have no idea 
what lists you guys normally hang out on.

The problem is dm-multipath needs more information about why a IO is 
being failed. If it gets a error because a cable went bad, then we want 
to retry a new path right away. If it gets a error because the device is 
dead, then we want to fail it upwards.

Block layer drivers currently return a errno.h type of error code like 
-EIO or -EOPNOTSUPP to blk_end_request/blk_end_request_all and friends. 
So a long time ago, I tried to just add new errno values for the block 
layer to use (http://marc.info/?l=linux-kernel&m=107715299008231&w=2). 
People did not like this for various reasons.

Next, I tried adding new block layer error codes 
(http://marc.info/?l=linux-kernel&m=107961883915068&w=2  and again here 
http://marc.info/?l=linux-scsi&m=112487427230642&w=2 and actually I 
modified those again a couple times but cannot find the links). My 
concern with the approach in these patches is that while they work well 
for errors that dm-multipath needs to handle, I have no idea what File 
Systems devs need. Also I think this would be useful for RAID.

Now, at work I have lots of bugzillas so I can finally spend some time 
at work to finish this up, and I want to know what developers need. If 
the lower layers can tell you what failed (device or connection to a 
device or driver) and if the lower layers thought the problem was 
retryable or not from its perspective is that good enough. Something 
like this http://marc.info/?l=linux-scsi&m=112487427230642&w=2 ?

WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michaelc@cs.wisc.edu>
To: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	device-mapper development <dm-devel@redhat.com>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>,
	linux-raid@vger.kernel.org, Jens Axboe
Subject: RFC: Adding new block layer error codes
Date: Thu, 11 Jun 2009 16:16:57 -0500	[thread overview]
Message-ID: <4A317449.4040602@cs.wisc.edu> (raw)

Hi,

Sorry to cc so many FS guys. I am a lowly SCSI guy :), so I have no idea 
what lists you guys normally hang out on.

The problem is dm-multipath needs more information about why a IO is 
being failed. If it gets a error because a cable went bad, then we want 
to retry a new path right away. If it gets a error because the device is 
dead, then we want to fail it upwards.

Block layer drivers currently return a errno.h type of error code like 
-EIO or -EOPNOTSUPP to blk_end_request/blk_end_request_all and friends. 
So a long time ago, I tried to just add new errno values for the block 
layer to use (http://marc.info/?l=linux-kernel&m=107715299008231&w=2). 
People did not like this for various reasons.

Next, I tried adding new block layer error codes 
(http://marc.info/?l=linux-kernel&m=107961883915068&w=2  and again here 
http://marc.info/?l=linux-scsi&m=112487427230642&w=2 and actually I 
modified those again a couple times but cannot find the links). My 
concern with the approach in these patches is that while they work well 
for errors that dm-multipath needs to handle, I have no idea what File 
Systems devs need. Also I think this would be useful for RAID.

Now, at work I have lots of bugzillas so I can finally spend some time 
at work to finish this up, and I want to know what developers need. If 
the lower layers can tell you what failed (device or connection to a 
device or driver) and if the lower layers thought the problem was 
retryable or not from its perspective is that good enough. Something 
like this http://marc.info/?l=linux-scsi&m=112487427230642&w=2 ?

             reply	other threads:[~2009-06-11 21:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11 21:16 Mike Christie [this message]
2009-06-11 21:16 ` RFC: Adding new block layer error codes Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A317449.4040602@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=dm-devel@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.