All of lore.kernel.org
 help / color / mirror / Atom feed
* net: fix network drivers ndo_start_xmit() return values (part 5)
@ 2009-06-12 15:13 Patrick McHardy
  0 siblings, 0 replies; only message in thread
From: Patrick McHardy @ 2009-06-12 15:13 UTC (permalink / raw)
  To: David S. Miller; +Cc: Linux Netdev List, ursula.braun

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 05.diff --]
[-- Type: text/x-patch, Size: 1148 bytes --]

commit a457e7b57fba9fe2209890bb068ecae60285d0db
Author: Patrick McHardy <kaber@trash.net>
Date:   Fri Jun 12 17:07:07 2009 +0200

    net: fix network drivers ndo_start_xmit() return values (part 5)
    
    Fix up s390 drivers that return an errno value to qdisc_restart(), causing
    qdisc_restart() to print a warning an requeue/retransmit the skb.
    
    - claw: impossible condition, simply remove it
    
    Signed-off-by: Patrick McHardy <kaber@trash.net>

diff --git a/drivers/s390/net/claw.c b/drivers/s390/net/claw.c
index 30a43cc..7b6f46d 100644
--- a/drivers/s390/net/claw.c
+++ b/drivers/s390/net/claw.c
@@ -338,12 +338,6 @@ claw_tx(struct sk_buff *skb, struct net_device *dev)
 
 	CLAW_DBF_TEXT(4, trace, "claw_tx");
         p_ch=&privptr->channel[WRITE];
-        if (skb == NULL) {
-                privptr->stats.tx_dropped++;
-		privptr->stats.tx_errors++;
-		CLAW_DBF_TEXT_(2, trace, "clawtx%d", -EIO);
-                return -EIO;
-        }
         spin_lock_irqsave(get_ccwdev_lock(p_ch->cdev), saveflags);
         rc=claw_hw_tx( skb, dev, 1 );
         spin_unlock_irqrestore(get_ccwdev_lock(p_ch->cdev), saveflags);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-12 15:13 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-12 15:13 net: fix network drivers ndo_start_xmit() return values (part 5) Patrick McHardy

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.