* net: fix network drivers ndo_start_xmit() return values (part 7)
@ 2009-06-12 15:34 Patrick McHardy
0 siblings, 0 replies; only message in thread
From: Patrick McHardy @ 2009-06-12 15:34 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List, Chas Williams
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: 07.diff --]
[-- Type: text/x-patch, Size: 960 bytes --]
commit 356695e6aa6fa75b4f48b05d22dcad264603abe4
Author: Patrick McHardy <kaber@trash.net>
Date: Fri Jun 12 17:32:06 2009 +0200
net: fix network drivers ndo_start_xmit() return values (part 7)
Fix up ATM drivers that return an errno value to qdisc_restart(), causing
qdisc_restart() to print a warning an requeue/retransmit the skb.
- lec: condition can only be remedied by userspace, until that retransmissions
Compile tested only.
Signed-off-by: Patrick McHardy <kaber@trash.net>
diff --git a/net/atm/lec.c b/net/atm/lec.c
index 199b6bb..b499af4 100644
--- a/net/atm/lec.c
+++ b/net/atm/lec.c
@@ -271,7 +271,8 @@ static int lec_start_xmit(struct sk_buff *skb, struct net_device *dev)
printk("%s:No lecd attached\n", dev->name);
dev->stats.tx_errors++;
netif_stop_queue(dev);
- return -EUNATCH;
+ kfree_skb(skb);
+ return NETDEV_TX_OK;
}
pr_debug("skbuff head:%lx data:%lx tail:%lx end:%lx\n",
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-06-12 15:34 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-12 15:34 net: fix network drivers ndo_start_xmit() return values (part 7) Patrick McHardy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.