* Re: [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on
2009-06-13 17:21 [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on more Alistair John Strachan
@ 2009-06-14 7:22 ` Hans de Goede
2009-06-14 7:45 ` Alistair John Strachan
2009-06-15 20:02 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2009-06-14 7:22 UTC (permalink / raw)
To: lm-sensors
On 06/13/2009 07:21 PM, Alistair John Strachan wrote:
> Salut Jean,
>
> These patches have been compile and runtime tested.
>
> They switch AB9, AB9 QuadGT and IX38 QuadGT mainboards over to using
> the DMI probe method. The testers have been credited appropriately.
>
> (The driver currently supports 17 models, 7 are now using DMI.)
>
Hi,
All 3 look good to me, although I did notice 2 have a common prefix,
we have some code to handle this in place, right ?
Regards,
Hans
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on
2009-06-13 17:21 [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on more Alistair John Strachan
2009-06-14 7:22 ` [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on Hans de Goede
@ 2009-06-14 7:45 ` Alistair John Strachan
2009-06-15 20:02 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Alistair John Strachan @ 2009-06-14 7:45 UTC (permalink / raw)
To: lm-sensors
On Sunday 14 June 2009 08:22:27 Hans de Goede wrote:
> On 06/13/2009 07:21 PM, Alistair John Strachan wrote:
> > Salut Jean,
> >
> > These patches have been compile and runtime tested.
> >
> > They switch AB9, AB9 QuadGT and IX38 QuadGT mainboards over to using
> > the DMI probe method. The testers have been credited appropriately.
> >
> > (The driver currently supports 17 models, 7 are now using DMI.)
>
> Hi,
>
> All 3 look good to me, although I did notice 2 have a common prefix,
> we have some code to handle this in place, right ?
Yes, Jean pointed this out last time and now we just chop the bit we don't
care about off (find first open bracket, trim any preceding spaces), and
compare only exact strings (length must match, non case-sensitive strings must
match).
Should all work fine, but I sent the strings separately in case there are
regressions.
--
Cheers,
Alistair.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on
2009-06-13 17:21 [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on more Alistair John Strachan
2009-06-14 7:22 ` [lm-sensors] [PATCH 0/3] hwmon: (abituguru3) DMI probing on Hans de Goede
2009-06-14 7:45 ` Alistair John Strachan
@ 2009-06-15 20:02 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2009-06-15 20:02 UTC (permalink / raw)
To: lm-sensors
Hi Alistair,
On Sat, 13 Jun 2009 18:21:11 +0100, Alistair John Strachan wrote:
> These patches have been compile and runtime tested.
>
> They switch AB9, AB9 QuadGT and IX38 QuadGT mainboards over to using
> the DMI probe method. The testers have been credited appropriately.
>
> (The driver currently supports 17 models, 7 are now using DMI.)
I think it's somewhat overkill to split these changes into 3 patches. I
don't really expect a regression here, and if it were to happen, I'm
reasonably certain we would figure out which change is faulty without
reverting the patches.
Care to resubmit as a single patch?
Thanks,
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread