All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: k-ueda@ct.jp.nec.com, Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org,
	device-mapper development <dm-devel@redhat.com>,
	Boaz Harrosh <bharrosh@panasas.com>,
	Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Subject: Re: [PATCH block#for-2.6.31] block: add request clone interface (v2)
Date: Mon, 15 Jun 2009 12:31:48 +0900	[thread overview]
Message-ID: <4A35C0A4.20707@ct.jp.nec.com> (raw)
In-Reply-To: <x49ski5v7vs.fsf@segfault.boston.devel.redhat.com>

Hi Jeff,

On 06/12/2009 11:33 PM +0900, Jeff Moyer wrote:
> Jens Axboe <jens.axboe@oracle.com> writes:
>> On Thu, Jun 11 2009, Jeff Moyer wrote:
>>> Jens Axboe <jens.axboe@oracle.com> writes:
>>> Is blk_rq_unprep_clone really the best name?
>>>           ^^^^^^
>> Probably not, but I'm not very good at coming up with elegant names.
>> Your email should have included a new suggestion :-)
> 
> Fair enough.  ;)
> 
>>  - blk_rq_unprep_clone(struct request *clone)
>>      * Frees cloned bios from the clone request.
> 
> Why not blk_rq_free_clone?

Because the 'clone' is not freed in this interface.
This interface frees only bios in the 'clone'.
Allocating/freeing the 'clone' are the caller's work, since
only the caller knows how to allocate/free it.

'prep' after 'alloc' and 'unprep' before 'free' is symmetric
and I feel a good candidate for my request-stacking driver,
so I chose it. 

Thanks,
Kiyoshi Ueda

WARNING: multiple messages have this Message-ID (diff)
From: Kiyoshi Ueda <k-ueda@ct.jp.nec.com>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org,
	device-mapper development <dm-devel@redhat.com>,
	Boaz Harrosh <bharrosh@panasas.com>,
	"Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>,
	k-ueda@ct.jp.nec.com
Subject: Re: [PATCH block#for-2.6.31] block: add request clone interface (v2)
Date: Mon, 15 Jun 2009 12:31:48 +0900	[thread overview]
Message-ID: <4A35C0A4.20707@ct.jp.nec.com> (raw)
In-Reply-To: <x49ski5v7vs.fsf@segfault.boston.devel.redhat.com>

Hi Jeff,

On 06/12/2009 11:33 PM +0900, Jeff Moyer wrote:
> Jens Axboe <jens.axboe@oracle.com> writes:
>> On Thu, Jun 11 2009, Jeff Moyer wrote:
>>> Jens Axboe <jens.axboe@oracle.com> writes:
>>> Is blk_rq_unprep_clone really the best name?
>>>           ^^^^^^
>> Probably not, but I'm not very good at coming up with elegant names.
>> Your email should have included a new suggestion :-)
> 
> Fair enough.  ;)
> 
>>  - blk_rq_unprep_clone(struct request *clone)
>>      * Frees cloned bios from the clone request.
> 
> Why not blk_rq_free_clone?

Because the 'clone' is not freed in this interface.
This interface frees only bios in the 'clone'.
Allocating/freeing the 'clone' are the caller's work, since
only the caller knows how to allocate/free it.

'prep' after 'alloc' and 'unprep' before 'free' is symmetric
and I feel a good candidate for my request-stacking driver,
so I chose it. 

Thanks,
Kiyoshi Ueda

  reply	other threads:[~2009-06-15  3:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-11  3:10 [PATCH block#for-2.6.31] block: add request clone interface (v2) Kiyoshi Ueda
2009-06-11  3:10 ` Kiyoshi Ueda
2009-06-11 11:09 ` Jens Axboe
2009-06-11 12:53   ` Jeff Moyer
2009-06-12 13:30     ` Jens Axboe
2009-06-12 13:30       ` Jens Axboe
2009-06-12 14:33       ` Jeff Moyer
2009-06-15  3:31         ` Kiyoshi Ueda [this message]
2009-06-15  3:31           ` Kiyoshi Ueda
2009-06-15  9:30           ` Boaz Harrosh
2009-06-15  9:30             ` Boaz Harrosh
2009-06-16  3:02             ` Kiyoshi Ueda
2009-06-16  3:02               ` Kiyoshi Ueda
2009-06-16  8:02               ` Boaz Harrosh
2009-06-16 12:35               ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A35C0A4.20707@ct.jp.nec.com \
    --to=k-ueda@ct.jp.nec.com \
    --cc=bharrosh@panasas.com \
    --cc=dm-devel@redhat.com \
    --cc=j-nomura@ce.jp.nec.com \
    --cc=jens.axboe@oracle.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.