All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mario Limonciello <mario_limonciello@dell.com>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] Don't match Dell devices on KERNEL, instead use ATTR{bInterfaceProtocol}
Date: Mon, 15 Jun 2009 16:31:12 +0000	[thread overview]
Message-ID: <4A367750.5040207@dell.com> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]

Hi:

For some reason I was getting mixed results where I couldn't get the
rule to run properly with a git pull today and udev 142.  ${attr} wasn't
expanding like it should have been.  I've modified the rule a bit and
this one is now working correctly.

Regards
-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: hid2hci.diff --]
[-- Type: text/x-patch; name="hid2hci.diff", Size: 978 bytes --]

=== modified file 'hid2hci/62-hid2hci.rules'
--- hid2hci/62-hid2hci.rules	2009-06-13 01:09:03 +0000
+++ hid2hci/62-hid2hci.rules	2009-06-15 16:25:29 +0000
@@ -1,16 +1,16 @@
 # do not edit this file, it will be overwritten on update
 
 ACTION!="add", GOTO="hid2hci_end"
+SUBSYSTEM!="usb", GOTO="hid2hci_end"
 
 # Variety of Dell Bluetooth devices - it looks like a bit of an odd rule,
 # because it is matching on a mouse device that is self powered, but that
 # is where a HID report needs to be sent to switch modes.
 #
 # Known supported devices: 413c:8154, 413c:8158, 413c:8162
-KERNEL=="mouse*", SUBSYSTEMS=="usb", ATTRS{idVendor}=="413c", ATTRS{bmAttributes}=="e0", \
+ATTR{bInterfaceProtocol}=="02", ATTRS{idVendor}=="413c", ATTRS{bmAttributes}=="e0", \
     RUN+="hid2hci --method dell -v $attr{idVendor} -p $attr{idProduct} --mode hci"
 
-SUBSYSTEM!="usb", GOTO="hid2hci_end"
 ENV{DEVTYPE}!="usb_device", GOTO="hid2hci_end"
 
 # Logitech devices


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

             reply	other threads:[~2009-06-15 16:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 16:31 Mario Limonciello [this message]
2009-06-15 17:23 ` [PATCH] Don't match Dell devices on KERNEL, instead use Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A367750.5040207@dell.com \
    --to=mario_limonciello@dell.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.