[PATCH] Don't match Dell devices on KERNEL, instead use ATTR{bInterfaceProtocol}

[PATCH] Don't match Dell devices on KERNEL, instead use ATTR{bInterfaceProtocol}

[Mario Limonciello]

[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]

Hi:

For some reason I was getting mixed results where I couldn't get the
rule to run properly with a git pull today and udev 142.  ${attr} wasn't
expanding like it should have been.  I've modified the rule a bit and
this one is now working correctly.

Regards
-- 
Mario Limonciello
*Dell | Linux Engineering*
mario_limonciello@dell.com

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: hid2hci.diff --]
[-- Type: text/x-patch; name="hid2hci.diff", Size: 978 bytes --]

=== modified file 'hid2hci/62-hid2hci.rules'
--- hid2hci/62-hid2hci.rules	2009-06-13 01:09:03 +0000
+++ hid2hci/62-hid2hci.rules	2009-06-15 16:25:29 +0000
@@ -1,16 +1,16 @@
 # do not edit this file, it will be overwritten on update
 
 ACTION!="add", GOTO="hid2hci_end"
+SUBSYSTEM!="usb", GOTO="hid2hci_end"
 
 # Variety of Dell Bluetooth devices - it looks like a bit of an odd rule,
 # because it is matching on a mouse device that is self powered, but that
 # is where a HID report needs to be sent to switch modes.
 #
 # Known supported devices: 413c:8154, 413c:8158, 413c:8162
-KERNEL=="mouse*", SUBSYSTEMS=="usb", ATTRS{idVendor}=="413c", ATTRS{bmAttributes}=="e0", \
+ATTR{bInterfaceProtocol}=="02", ATTRS{idVendor}=="413c", ATTRS{bmAttributes}=="e0", \
     RUN+="hid2hci --method dell -v $attr{idVendor} -p $attr{idProduct} --mode hci"
 
-SUBSYSTEM!="usb", GOTO="hid2hci_end"
 ENV{DEVTYPE}!="usb_device", GOTO="hid2hci_end"
 
 # Logitech devices


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

Re: [PATCH] Don't match Dell devices on KERNEL, instead use

[Kay Sievers]

On Mon, Jun 15, 2009 at 18:31, Mario
Limonciello<mario_limonciello@dell.com> wrote:
> For some reason I was getting mixed results where I couldn't get the
> rule to run properly with a git pull today and udev 142.  ${attr} wasn't
> expanding like it should have been.  I've modified the rule a bit and
> this one is now working correctly.

Applied.

Thanks,
Kay