From: Boaz Harrosh <bharrosh@panasas.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Christoph Hellwig <hch@infradead.org>,
open-osd mailing-list <osd-dev@open-osd.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] exofs: Avoid using file_fsync()
Date: Mon, 15 Jun 2009 20:23:49 +0300 [thread overview]
Message-ID: <4A3683A5.2090908@panasas.com> (raw)
In-Reply-To: <4A3682FC.6010000@garzik.org>
On 06/15/2009 08:21 PM, Jeff Garzik wrote:
> Christoph Hellwig wrote:
>> On Mon, Jun 15, 2009 at 04:31:01PM +0300, Boaz Harrosh wrote:
>>> + ret = write_inode_now(inode, 0);
>> You shouldn't need a write_inode_now, but rather just a similar
>> sync_inode call as in ext2 or the new simple_fsync as data was
>> already written by the VFS.
>
> And then there is the issue of needing to flush the storage device,
> otherwise fsync(2) does not provide relevant guarantees...
>
> Jeff
>
Right thanks, I need to do this too, will do
Boaz
prev parent reply other threads:[~2009-06-15 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 13:31 [PATCH] exofs: Avoid using file_fsync() Boaz Harrosh
2009-06-15 13:50 ` Christoph Hellwig
2009-06-15 14:30 ` Boaz Harrosh
2009-06-15 16:52 ` Boaz Harrosh
2009-06-15 17:07 ` [PATCH version 2] " Boaz Harrosh
2009-06-15 17:21 ` [PATCH] " Jeff Garzik
2009-06-15 17:23 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3683A5.2090908@panasas.com \
--to=bharrosh@panasas.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.