All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Regression opening read-only cdroms
Date: Tue, 16 Jun 2009 15:00:44 +0300	[thread overview]
Message-ID: <4A37896C.8050208@redhat.com> (raw)

qemu used to be quite happy opening read-only cdrom images, and I was 
quite happy feeding kvm-autotest a library of read-only iso images.  
However since

    commit 0e1d8f4c549e51fd19793a154862979fdc199477
    Author: Christoph Hellwig <hch@lst.de>
    Date:   Mon Jun 15 13:53:26 2009 +0200

         raw-posix: always store open flags

         Both the Linux floppy and the FreeBSD CDROM host device need to
    store
         the open flags so that they can re-open the device later. 
    Store the
         open flags unconditionally to remove the ifdef mess and simply the
         calling conventions for the later patches in the series.

         Signed-off-by: Christoph Hellwig <hch@lst.de>

this state of happiness no longer exists.

Can you look at what caused this?

-- 
error compiling committee.c: too many arguments to function

             reply	other threads:[~2009-06-16 12:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 12:00 Avi Kivity [this message]
2009-06-16 14:33 ` [Qemu-devel] Regression opening read-only cdroms Jamie Lokier
2009-06-16 14:54   ` Stefano Stabellini
2009-06-16 14:54     ` Jamie Lokier
2009-06-16 16:28       ` Anthony Liguori
2009-06-16 17:14         ` Stefano Stabellini
2009-06-16 17:46           ` Jamie Lokier
2009-06-16 17:54             ` Avi Kivity
2009-06-16 18:56               ` Jamie Lokier
2009-06-16 19:02                 ` Jamie Lokier
2009-06-16 21:11         ` Gerd Hoffmann
2009-06-17  6:27           ` Avi Kivity
2009-06-16 15:16   ` Avi Kivity
2009-06-16 15:54     ` Jamie Lokier
2009-06-16 16:17       ` Avi Kivity
2009-06-16 17:51         ` Jamie Lokier
2009-06-16 17:58           ` Avi Kivity
2009-06-18 12:37   ` Richard W.M. Jones
2009-06-24 20:23     ` Jamie Lokier
2009-06-24 22:43       ` Richard W.M. Jones
2009-06-25  0:50         ` Jamie Lokier
2009-06-25  8:17           ` Richard W.M. Jones
2009-06-16 16:28 ` Blue Swirl
2009-06-16 18:37   ` Blue Swirl
2009-06-16 21:16     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37896C.8050208@redhat.com \
    --to=avi@redhat.com \
    --cc=hch@lst.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.