From: Anthony Liguori <anthony@codemonkey.ws>
To: Jamie Lokier <jamie@shareable.org>
Cc: Avi Kivity <avi@redhat.com>, Christoph Hellwig <hch@lst.de>,
qemu-devel <qemu-devel@nongnu.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] Regression opening read-only cdroms
Date: Tue, 16 Jun 2009 11:28:27 -0500 [thread overview]
Message-ID: <4A37C82B.5030805@codemonkey.ws> (raw)
In-Reply-To: <20090616145421.GD29040@shareable.org>
Jamie Lokier wrote:
>> Indeed.
>> I have a patch that adds bdrv_set_read_only that set bs->read_only = 1
>> so that bdrv_open2 can check if the flag is set and act accordingly.
>> The problem is that in xen we read whether the device should be opened
>> read only in the VM config file, I don't think the user can specify to
>> open a drive read-only in qemu.
>>
>
> What's missing is a "ro" sub-option to "-drive".
>
It only is useful if we can expose that read-only attribute to the
guest. You can't do that consistently with all block devices so the
result would be that you'll fail write operations causing a guest to crash.
This is not friendly to a user who expects that ro would Just Work.
Regards,
Anthony Liguori
> -- Jamie
>
>
>
next prev parent reply other threads:[~2009-06-16 16:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 12:00 [Qemu-devel] Regression opening read-only cdroms Avi Kivity
2009-06-16 14:33 ` Jamie Lokier
2009-06-16 14:54 ` Stefano Stabellini
2009-06-16 14:54 ` Jamie Lokier
2009-06-16 16:28 ` Anthony Liguori [this message]
2009-06-16 17:14 ` Stefano Stabellini
2009-06-16 17:46 ` Jamie Lokier
2009-06-16 17:54 ` Avi Kivity
2009-06-16 18:56 ` Jamie Lokier
2009-06-16 19:02 ` Jamie Lokier
2009-06-16 21:11 ` Gerd Hoffmann
2009-06-17 6:27 ` Avi Kivity
2009-06-16 15:16 ` Avi Kivity
2009-06-16 15:54 ` Jamie Lokier
2009-06-16 16:17 ` Avi Kivity
2009-06-16 17:51 ` Jamie Lokier
2009-06-16 17:58 ` Avi Kivity
2009-06-18 12:37 ` Richard W.M. Jones
2009-06-24 20:23 ` Jamie Lokier
2009-06-24 22:43 ` Richard W.M. Jones
2009-06-25 0:50 ` Jamie Lokier
2009-06-25 8:17 ` Richard W.M. Jones
2009-06-16 16:28 ` Blue Swirl
2009-06-16 18:37 ` Blue Swirl
2009-06-16 21:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A37C82B.5030805@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=hch@lst.de \
--cc=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.