Re: echo and hello bug

[James Jarvis <James.Jarvis@ed.ac.uk>]

Vladimir 'phcoder' Serbinenko wrote:
>> tried this module list in grub-mkimage on 2282 but it hung!
>>     
> I think you have a problem with you building system. If you want ping
> me (phcoder) on IRC and I'll compile for you
>   
Shamed me into looking deeper! I discover that by listing hello and echo 
first in the grub-mkimage command they both work as expected. Not sure 
why this occurs - is there a file detailing module dependencies one can 
look at?

Anyway, whilst looking through the code I did spot a semantic error, fix 
shown in this patch:
Index: echo.c
===================================================================
--- echo.c      (revision 2331)
+++ echo.c      (working copy)
@@ -113,7 +113,7 @@
 GRUB_MOD_INIT(echo)
 {
   cmd = grub_register_extcmd ("echo", grub_cmd_echo, 
GRUB_COMMAND_FLAG_BOTH,
-                             "echo [-e|-n] FILE", "Display a line of 
text.",
+                             "echo [-e|-n] STRING", "Display a line of 
text.",
                              options);
 }

James

-- 
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.