All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix domid length in xenconsole
@ 2009-06-16 15:44 Stefano Stabellini
  0 siblings, 0 replies; only message in thread
From: Stefano Stabellini @ 2009-06-16 15:44 UTC (permalink / raw)
  To: xen-devel

Hi all,
the last patch for xenconsole erroneously assumed that the max length
of a domid in char is 3 while is obviously 5; this patch fixes it.
Also snprintf includes the final '\0' in the char count.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>

---

diff -r 33894148c1fd tools/console/client/main.c
--- a/tools/console/client/main.c	Tue Jun 16 13:42:22 2009 +0100
+++ b/tools/console/client/main.c	Tue Jun 16 13:45:18 2009 +0100
@@ -306,10 +306,10 @@
 	dom_path = xs_get_domain_path(xs, domid);
 	if (dom_path == NULL)
 		err(errno, "xs_get_domain_path()");
-	path = malloc(strlen(dom_path) + strlen("/serial/0/tty") + 3);
+	path = malloc(strlen(dom_path) + strlen("/serial/0/tty") + 5);
 	if (path == NULL)
 		err(ENOMEM, "malloc");
-	snprintf(path, strlen(dom_path) + strlen("/serial/0/tty") + 2, "%s/serial/%d/tty", dom_path, num);
+	snprintf(path, strlen(dom_path) + strlen("/serial/0/tty") + 5, "%s/serial/%d/tty", dom_path, num);
 
 	/* FIXME consoled currently does not assume domain-0 doesn't have a
 	   console which is good when we break domain-0 up.  To keep us

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-16 15:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-16 15:44 [PATCH] fix domid length in xenconsole Stefano Stabellini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.