All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] update stubdom config example
Date: Tue, 16 Jun 2009 17:09:24 +0100	[thread overview]
Message-ID: <4A37C3B4.90601@eu.citrix.com> (raw)
In-Reply-To: <20090616155652.GT5866@const.bordeaux.inria.fr>

Samuel Thibault wrote:

> Stefano Stabellini, le Tue 16 Jun 2009 16:46:17 +0100, a écrit :
>> this patch updates the stubdom config example to reflect that the serial
>> option can now be used.
> 
> Ok, so now I see what your previous patch is for :) I still think
> openpty() shouldn't be used, as a standard function with the same name
> but different prototype exists, that would lead us to troubles. I would
> rather see it as open("/dev/ptmx") and/or posix_openpt(), which actually
> does the same, but can be interfaced in a standard way. And then we
> could even implement pts_name() to provide the console frontend path.
> 

I wasn't aware of posix_openpt, I think that is the best choice.
I'll resend the patch and also update the qemu patch that uses it.

      reply	other threads:[~2009-06-16 16:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 15:46 [PATCH] update stubdom config example Stefano Stabellini
2009-06-16 15:56 ` Samuel Thibault
2009-06-16 16:09   ` Stefano Stabellini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37C3B4.90601@eu.citrix.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.