All of lore.kernel.org
 help / color / mirror / Atom feed
From: Izik Eidus <ieidus@redhat.com>
To: linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andrea Arcangeli <aarcange@redhat.com>,
	nickpiggin@yahoo.com.au
Subject: running get_user_pages() from kernel thread
Date: Tue, 16 Jun 2009 21:05:27 +0300	[thread overview]
Message-ID: <4A37DEE7.1000208@redhat.com> (raw)

Hey,

ksm is running from its kernel thread context get_user_pages(), but look 
like it isnt safe to do get_user_pages() from kernel thread:
get_user_pages may lead into do_swap_page() that may lead into calling 
grab_swap_token()

Now grab_swap_token() will do:
current_interval = global_faults - current->mm->... (here is the bug... 
(kernel thread doesnt have mm strcture)

So the question is: is this thing is by desgin? (that kernel thread cant 
call get_user_pages???), should i use something like switch_mm()??

Thanks.



             reply	other threads:[~2009-06-16 18:05 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 18:05 Izik Eidus [this message]
2009-06-16 18:13 ` running get_user_pages() from kernel thread Andrea Arcangeli
2009-06-16 18:38   ` Hugh Dickins
2009-06-16 18:55     ` Rik van Riel
2009-06-16 19:45       ` Hugh Dickins
2009-06-16 20:38         ` Andrea Arcangeli
2009-06-16 21:02           ` Hugh Dickins
2009-06-16 21:19         ` Rik van Riel
2009-06-16 19:20     ` Izik Eidus
2009-06-16 20:45       ` Hugh Dickins
2009-06-16 21:25         ` Izik Eidus
2009-06-16 20:08     ` Johannes Weiner
2009-06-16 20:57       ` Hugh Dickins
2009-06-16 21:50         ` [patch 1/2] mm: make swap token dummies static inlines Johannes Weiner
2009-06-16 21:50           ` Johannes Weiner
2009-06-16 21:55           ` Rik van Riel
2009-06-16 21:55             ` Rik van Riel
2009-06-16 21:50         ` [patch 2/2] mm: remove task assumptions from swap token Johannes Weiner
2009-06-16 21:50           ` Johannes Weiner
2009-06-16 21:56           ` Rik van Riel
2009-06-16 21:56             ` Rik van Riel
2009-06-17  2:00           ` Minchan Kim
2009-06-17  2:00             ` Minchan Kim
2009-06-17  8:31             ` Johannes Weiner
2009-06-17  8:31               ` Johannes Weiner
2009-06-16 21:52         ` running get_user_pages() from kernel thread Johannes Weiner
2009-06-21 13:02           ` [PATCH] mm: pass mm to grab_swap_token Hugh Dickins
2009-06-22  0:32             ` Minchan Kim
2009-06-16 21:16       ` running get_user_pages() from kernel thread Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37DEE7.1000208@redhat.com \
    --to=ieidus@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.