From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Andrea Arcangeli <aarcange@redhat.com>,
Izik Eidus <ieidus@redhat.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] mm: remove task assumptions from swap token
Date: Tue, 16 Jun 2009 17:56:22 -0400 [thread overview]
Message-ID: <4A381506.20102@redhat.com> (raw)
In-Reply-To: <1245189037-22961-2-git-send-email-hannes@cmpxchg.org>
Johannes Weiner wrote:
> From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
>
> grab_swap_token() should not make any assumptions about the running
> process as the swap token is an attribute of the address space and the
> faulting mm is not necessarily current->mm.
>
> This fixes get_user_pages() from kernel threads which would blow up
> when encountering a swapped out page and grab_swap_token()
> dereferencing the unset for kernel threads current->mm.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
Andrea Arcangeli <aarcange@redhat.com>,
Izik Eidus <ieidus@redhat.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] mm: remove task assumptions from swap token
Date: Tue, 16 Jun 2009 17:56:22 -0400 [thread overview]
Message-ID: <4A381506.20102@redhat.com> (raw)
In-Reply-To: <1245189037-22961-2-git-send-email-hannes@cmpxchg.org>
Johannes Weiner wrote:
> From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
>
> grab_swap_token() should not make any assumptions about the running
> process as the swap token is an attribute of the address space and the
> faulting mm is not necessarily current->mm.
>
> This fixes get_user_pages() from kernel threads which would blow up
> when encountering a swapped out page and grab_swap_token()
> dereferencing the unset for kernel threads current->mm.
>
> Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-16 21:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 18:05 running get_user_pages() from kernel thread Izik Eidus
2009-06-16 18:13 ` Andrea Arcangeli
2009-06-16 18:38 ` Hugh Dickins
2009-06-16 18:55 ` Rik van Riel
2009-06-16 19:45 ` Hugh Dickins
2009-06-16 20:38 ` Andrea Arcangeli
2009-06-16 21:02 ` Hugh Dickins
2009-06-16 21:19 ` Rik van Riel
2009-06-16 19:20 ` Izik Eidus
2009-06-16 20:45 ` Hugh Dickins
2009-06-16 21:25 ` Izik Eidus
2009-06-16 20:08 ` Johannes Weiner
2009-06-16 20:57 ` Hugh Dickins
2009-06-16 21:50 ` [patch 1/2] mm: make swap token dummies static inlines Johannes Weiner
2009-06-16 21:50 ` Johannes Weiner
2009-06-16 21:55 ` Rik van Riel
2009-06-16 21:55 ` Rik van Riel
2009-06-16 21:50 ` [patch 2/2] mm: remove task assumptions from swap token Johannes Weiner
2009-06-16 21:50 ` Johannes Weiner
2009-06-16 21:56 ` Rik van Riel [this message]
2009-06-16 21:56 ` Rik van Riel
2009-06-17 2:00 ` Minchan Kim
2009-06-17 2:00 ` Minchan Kim
2009-06-17 8:31 ` Johannes Weiner
2009-06-17 8:31 ` Johannes Weiner
2009-06-16 21:52 ` running get_user_pages() from kernel thread Johannes Weiner
2009-06-21 13:02 ` [PATCH] mm: pass mm to grab_swap_token Hugh Dickins
2009-06-22 0:32 ` Minchan Kim
2009-06-16 21:16 ` running get_user_pages() from kernel thread Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A381506.20102@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=ieidus@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.