From: Anthony Liguori <aliguori@us.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
virtualization@lists.linux-foundation.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Blue Swirl <blauwirbel@gmail.com>,
Anthony Liguori <anthony@codemonkey.ws>,
Glauber Costa <glommer@redhat.com>
Subject: Re: [PATCHv4 01/13] qemu: make default_write_config use mask table
Date: Tue, 16 Jun 2009 15:40:13 -0500 [thread overview]
Message-ID: <4A38032D.5060506@us.ibm.com> (raw)
In-Reply-To: <20090610122804.GB27174@redhat.com>
Michael S. Tsirkin wrote:
> Change much of hw/pci to use symbolic constants and a table-driven
> design: add a mask table with writable bits set and readonly bits unset.
> Detect change by comparing original and new registers.
>
> This makes it easy to support capabilities where read-only/writeable
> bit layout differs between devices, depending on capabilities present.
>
> As a result, writing a single byte in BAR registers now works as
> it should. Writing to upper limit registers in the bridge
> also works as it should. Code is also shorter.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This series introduces warning (virtio_load decl/def does not match).
--
Regards,
Anthony Liguori
WARNING: multiple messages have this Message-ID (diff)
From: Anthony Liguori <aliguori@us.ibm.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Carsten Otte <cotte@de.ibm.com>,
kvm@vger.kernel.org, Glauber Costa <glommer@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
Blue Swirl <blauwirbel@gmail.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config use mask table
Date: Tue, 16 Jun 2009 15:40:13 -0500 [thread overview]
Message-ID: <4A38032D.5060506@us.ibm.com> (raw)
In-Reply-To: <20090610122804.GB27174@redhat.com>
Michael S. Tsirkin wrote:
> Change much of hw/pci to use symbolic constants and a table-driven
> design: add a mask table with writable bits set and readonly bits unset.
> Detect change by comparing original and new registers.
>
> This makes it easy to support capabilities where read-only/writeable
> bit layout differs between devices, depending on capabilities present.
>
> As a result, writing a single byte in BAR registers now works as
> it should. Writing to upper limit registers in the bridge
> also works as it should. Code is also shorter.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This series introduces warning (virtio_load decl/def does not match).
--
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-06-16 20:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1244635350.git.mst@redhat.com>
2009-06-10 12:28 ` [PATCHv4 01/13] qemu: make default_write_config use mask table Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-16 20:40 ` Anthony Liguori [this message]
2009-06-16 20:40 ` [Qemu-devel] " Anthony Liguori
2009-06-17 11:49 ` Michael S. Tsirkin
2009-06-17 11:49 ` Michael S. Tsirkin
2009-06-17 11:49 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-16 20:40 ` Anthony Liguori
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [PATCHv4 02/13] qemu: capability bits in pci save/restore Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [PATCHv4 03/13] qemu: add routines to manage PCI capabilities Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:28 ` [PATCHv4 04/13] qemu: helper routines for pci access Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:28 ` [PATCHv4 05/13] qemu: MSI-X support functions Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:28 ` [PATCHv4 06/13] qemu: add flag to disable MSI-X by default Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:28 ` [PATCHv4 07/13] qemu: minimal MSI/MSI-X implementation for PC Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [PATCHv4 08/13] qemu: add support for resizing regions Michael S. Tsirkin
2009-06-10 12:28 ` Michael S. Tsirkin
2009-06-10 12:28 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:29 ` [PATCHv4 09/13] qemu: virtio support for many interrupt vectors Michael S. Tsirkin
2009-06-10 12:29 ` Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:29 ` [PATCHv4 10/13] qemu: MSI-X support in virtio PCI Michael S. Tsirkin
2009-06-10 12:29 ` Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:29 ` [PATCHv4 11/13] qemu: request 3 vectors in virtio-net Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:29 ` Michael S. Tsirkin
2009-06-10 12:29 ` [PATCHv4 12/13] qemu: virtio save/load bindings Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:29 ` Michael S. Tsirkin
2009-06-10 12:29 ` [PATCHv4 13/13] qemu: add pci_get/set_byte Michael S. Tsirkin
2009-06-10 12:29 ` [Qemu-devel] " Michael S. Tsirkin
2009-06-10 12:29 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A38032D.5060506@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.