* cpusets: document adding/removing cpus to cpuset elaborately
@ 2009-06-16 11:16 Nikanth Karthikesan
2009-06-16 11:23 ` [LTP] " Subrata Modak
2009-06-17 0:45 ` cpusets: document adding/removing cpus to cpuset elaborately Li Zefan
0 siblings, 2 replies; 6+ messages in thread
From: Nikanth Karthikesan @ 2009-06-16 11:16 UTC (permalink / raw)
To: Paul Menage; +Cc: linux-kernel
Writing a pid to the file, tasks adds that task to that cgroup/cpuset. But to
add a cpu/mem to a cpuset, the new list of cpus should be written to the
cpuset.mems file which would replace the old list of cpus. Make this clearer
in the documentation.
Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
---
diff --git a/Documentation/cgroups/cpusets.txt b/Documentation/cgroups/cpusets.txt
index f9ca389..1d7e978 100644
--- a/Documentation/cgroups/cpusets.txt
+++ b/Documentation/cgroups/cpusets.txt
@@ -777,6 +777,18 @@ in cpuset directories:
# /bin/echo 1-4 > cpus -> set cpus list to cpus 1,2,3,4
# /bin/echo 1,2,3,4 > cpus -> set cpus list to cpus 1,2,3,4
+To add a CPU to a cpuset, write the new list of CPUs including the
+CPU to be added. To add 6 to the above cpuset:
+
+# /bin/echo 1-4,6 > cpus -> set cpus list to cpus 1,2,3,4,6
+
+Similarly to remove a CPU from a cpuset, write the new list of CPUs
+without the CPU to be removed.
+
+To remove all the CPUs:
+
+# /bin/echo "" > cpus -> clear cpus list
+
2.3 Setting flags
-----------------
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [LTP] cpusets: document adding/removing cpus to cpuset elaborately
2009-06-16 11:16 cpusets: document adding/removing cpus to cpuset elaborately Nikanth Karthikesan
@ 2009-06-16 11:23 ` Subrata Modak
2009-06-18 17:31 ` Subrata Modak
2009-06-17 0:45 ` cpusets: document adding/removing cpus to cpuset elaborately Li Zefan
1 sibling, 1 reply; 6+ messages in thread
From: Subrata Modak @ 2009-06-16 11:23 UTC (permalink / raw)
To: Nikanth Karthikesan; +Cc: ltp-list, Paul Menage, linux-kernel, miaox
[-- Attachment #1.1: Type: text/plain, Size: 1868 bytes --]
On Tue, Jun 16, 2009 at 4:46 PM, Nikanth Karthikesan <knikanth@suse.de>wrote:
> Writing a pid to the file, tasks adds that task to that cgroup/cpuset. But
> to
> add a cpu/mem to a cpuset, the new list of cpus should be written to the
> cpuset.mems file which would replace the old list of cpus. Make this
> clearer
> in the documentation.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
Hey,
Great to see that you are working on the documentation part. Have you given
a try to test the CPUSET features in the kernel with the recently added
tests from LTP(
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/controllers/cpuset/)
? It would be great if you help us in improving them further.
Regards--
Subrata
>
> ---
>
> diff --git a/Documentation/cgroups/cpusets.txt
> b/Documentation/cgroups/cpusets.txt
> index f9ca389..1d7e978 100644
> --- a/Documentation/cgroups/cpusets.txt
> +++ b/Documentation/cgroups/cpusets.txt
> @@ -777,6 +777,18 @@ in cpuset directories:
> # /bin/echo 1-4 > cpus -> set cpus list to cpus 1,2,3,4
> # /bin/echo 1,2,3,4 > cpus -> set cpus list to cpus 1,2,3,4
>
> +To add a CPU to a cpuset, write the new list of CPUs including the
> +CPU to be added. To add 6 to the above cpuset:
> +
> +# /bin/echo 1-4,6 > cpus -> set cpus list to cpus 1,2,3,4,6
> +
> +Similarly to remove a CPU from a cpuset, write the new list of CPUs
> +without the CPU to be removed.
> +
> +To remove all the CPUs:
> +
> +# /bin/echo "" > cpus -> clear cpus list
> +
> 2.3 Setting flags
> -----------------
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Regards & Thanks--
Subrata
[-- Attachment #1.2: Type: text/html, Size: 2854 bytes --]
[-- Attachment #2: Type: text/plain, Size: 332 bytes --]
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cpusets: document adding/removing cpus to cpuset elaborately
2009-06-16 11:16 cpusets: document adding/removing cpus to cpuset elaborately Nikanth Karthikesan
2009-06-16 11:23 ` [LTP] " Subrata Modak
@ 2009-06-17 0:45 ` Li Zefan
2009-06-17 9:42 ` Paul Menage
1 sibling, 1 reply; 6+ messages in thread
From: Li Zefan @ 2009-06-17 0:45 UTC (permalink / raw)
To: Nikanth Karthikesan; +Cc: Paul Menage, linux-kernel
Nikanth Karthikesan wrote:
> Writing a pid to the file, tasks adds that task to that cgroup/cpuset. But to
> add a cpu/mem to a cpuset, the new list of cpus should be written to the
> cpuset.mems file which would replace the old list of cpus. Make this clearer
> in the documentation.
>
Though I think '>' already means overwrite so removing/adding cpus should
always writing the full list of CPUs to 'cpus', more documentation to make
cpuset usage clearer is not bad.
Acked-by: Li Zefan <lizf@cn.fujitsu.com>
> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
>
> ---
>
> diff --git a/Documentation/cgroups/cpusets.txt b/Documentation/cgroups/cpusets.txt
> index f9ca389..1d7e978 100644
> --- a/Documentation/cgroups/cpusets.txt
> +++ b/Documentation/cgroups/cpusets.txt
> @@ -777,6 +777,18 @@ in cpuset directories:
> # /bin/echo 1-4 > cpus -> set cpus list to cpus 1,2,3,4
> # /bin/echo 1,2,3,4 > cpus -> set cpus list to cpus 1,2,3,4
>
> +To add a CPU to a cpuset, write the new list of CPUs including the
> +CPU to be added. To add 6 to the above cpuset:
> +
> +# /bin/echo 1-4,6 > cpus -> set cpus list to cpus 1,2,3,4,6
> +
> +Similarly to remove a CPU from a cpuset, write the new list of CPUs
> +without the CPU to be removed.
> +
> +To remove all the CPUs:
> +
> +# /bin/echo "" > cpus -> clear cpus list
> +
> 2.3 Setting flags
> -----------------
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: cpusets: document adding/removing cpus to cpuset elaborately
2009-06-17 0:45 ` cpusets: document adding/removing cpus to cpuset elaborately Li Zefan
@ 2009-06-17 9:42 ` Paul Menage
0 siblings, 0 replies; 6+ messages in thread
From: Paul Menage @ 2009-06-17 9:42 UTC (permalink / raw)
To: Li Zefan; +Cc: Nikanth Karthikesan, linux-kernel
On Tue, Jun 16, 2009 at 5:45 PM, Li Zefan<lizf@cn.fujitsu.com> wrote:
> Nikanth Karthikesan wrote:
>> Writing a pid to the file, tasks adds that task to that cgroup/cpuset. But to
>> add a cpu/mem to a cpuset, the new list of cpus should be written to the
>> cpuset.mems file which would replace the old list of cpus. Make this clearer
>> in the documentation.
>>
>
> Though I think '>' already means overwrite so removing/adding cpus should
> always writing the full list of CPUs to 'cpus'
But in the context of cgroups/cpusets that's not always the case -
think of the "tasks" file.
>
> Acked-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Paul Menage <menage@google.com>
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] cpusets: document adding/removing cpus to cpuset elaborately
2009-06-16 11:23 ` [LTP] " Subrata Modak
@ 2009-06-18 17:31 ` Subrata Modak
2009-06-19 3:56 ` [LTP] cpusets: document adding/removing cpus to cpusetelaborately Nikanth Karthikesan
0 siblings, 1 reply; 6+ messages in thread
From: Subrata Modak @ 2009-06-18 17:31 UTC (permalink / raw)
To: Nikanth Karthikesan; +Cc: ltp-list, miaox
Hi Nikanth,
On Tue, 2009-06-16 at 16:53 +0530, Subrata Modak wrote:
> On Tue, Jun 16, 2009 at 4:46 PM, Nikanth Karthikesan
> <knikanth@suse.de> wrote:
> Writing a pid to the file, tasks adds that task to that
> cgroup/cpuset. But to
> add a cpu/mem to a cpuset, the new list of cpus should be
> written to the
> cpuset.mems file which would replace the old list of cpus.
> Make this clearer
> in the documentation.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
>
> Hey,
>
> Great to see that you are working on the documentation part. Have you
> given a try to test the CPUSET features in the kernel with the
> recently added tests from
> LTP(http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/controllers/cpuset/) ? It would be great if you help us in improving them further.
>
Would you like to share something with us ?
Regards--
Subrata
> Regards--
> Subrata
>
>
>
>
> ---
>
> diff --git a/Documentation/cgroups/cpusets.txt
> b/Documentation/cgroups/cpusets.txt
> index f9ca389..1d7e978 100644
> --- a/Documentation/cgroups/cpusets.txt
> +++ b/Documentation/cgroups/cpusets.txt
> @@ -777,6 +777,18 @@ in cpuset directories:
> # /bin/echo 1-4 > cpus -> set cpus list to cpus
> 1,2,3,4
> # /bin/echo 1,2,3,4 > cpus -> set cpus list to cpus
> 1,2,3,4
>
> +To add a CPU to a cpuset, write the new list of CPUs
> including the
> +CPU to be added. To add 6 to the above cpuset:
> +
> +# /bin/echo 1-4,6 > cpus -> set cpus list to cpus
> 1,2,3,4,6
> +
> +Similarly to remove a CPU from a cpuset, write the new list
> of CPUs
> +without the CPU to be removed.
> +
> +To remove all the CPUs:
> +
> +# /bin/echo "" > cpus -> clear cpus list
> +
> 2.3 Setting flags
> -----------------
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Regards & Thanks--
> Subrata
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables unlimited
> royalty-free distribution of the report engine for externally facing
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [LTP] cpusets: document adding/removing cpus to cpusetelaborately
2009-06-18 17:31 ` Subrata Modak
@ 2009-06-19 3:56 ` Nikanth Karthikesan
0 siblings, 0 replies; 6+ messages in thread
From: Nikanth Karthikesan @ 2009-06-19 3:56 UTC (permalink / raw)
To: subrata, Nikanth Karthikesan; +Cc: ltp-list, miaox
>>> On 6/18/2009 at 11:01 PM, Subrata Modak <subrata@linux.vnet.ibm.com> wrote:
> Hi Nikanth,
>
> On Tue, 2009-06-16 at 16:53 +0530, Subrata Modak wrote:
> > On Tue, Jun 16, 2009 at 4:46 PM, Nikanth Karthikesan
> > <knikanth@suse.de> wrote:
> > Writing a pid to the file, tasks adds that task to that
> > cgroup/cpuset. But to
> > add a cpu/mem to a cpuset, the new list of cpus should be
> > written to the
> > cpuset.mems file which would replace the old list of cpus.
> > Make this clearer
> > in the documentation.
> >
> > Signed-off-by: Nikanth Karthikesan <knikanth@suse.de>
> >
> > Hey,
> >
> > Great to see that you are working on the documentation part. Have you
> > given a try to test the CPUSET features in the kernel with the
> > recently added tests from
> >
> LTP(http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/controller
> s/cpuset/) ? It would be great if you help us in improving them further.
> >
>
> Would you like to share something with us ?
>
Hey Subrata
Great to hear from you. I was working on a patch that touches cpuset, and
mis-understood the doc, hence the patch. But I haven't worked on it after that,
as I was occupied with something else.
Thanks a lot for pointing me to the LTP test cases. It should help me. Surely,
would use it when I get back to it, after I am back from vacation and and report
my experience. :)
Thanks
Nikanth
> >
> >
> >
> >
> > ---
> >
> > diff --git a/Documentation/cgroups/cpusets.txt
> > b/Documentation/cgroups/cpusets.txt
> > index f9ca389..1d7e978 100644
> > --- a/Documentation/cgroups/cpusets.txt
> > +++ b/Documentation/cgroups/cpusets.txt
> > @@ -777,6 +777,18 @@ in cpuset directories:
> > # /bin/echo 1-4 > cpus -> set cpus list to cpus
> > 1,2,3,4
> > # /bin/echo 1,2,3,4 > cpus -> set cpus list to cpus
> > 1,2,3,4
> >
> > +To add a CPU to a cpuset, write the new list of CPUs
> > including the
> > +CPU to be added. To add 6 to the above cpuset:
> > +
> > +# /bin/echo 1-4,6 > cpus -> set cpus list to cpus
> > 1,2,3,4,6
> > +
> > +Similarly to remove a CPU from a cpuset, write the new list
> > of CPUs
> > +without the CPU to be removed.
> > +
> > +To remove all the CPUs:
> > +
> > +# /bin/echo "" > cpus -> clear cpus list
> > +
> > 2.3 Setting flags
> > -----------------
> >
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at
> > http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
> >
> >
> > --
> > Regards & Thanks--
> > Subrata
> > ------------------------------------------------------------------------------
> > Crystal Reports - New Free Runtime and 30 Day Trial
> > Check out the new simplified licensing option that enables unlimited
> > royalty-free distribution of the report engine for externally facing
> > server and web deployment.
> > http://p.sf.net/sfu/businessobjects
> > _______________________________________________ Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-06-19 3:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-16 11:16 cpusets: document adding/removing cpus to cpuset elaborately Nikanth Karthikesan
2009-06-16 11:23 ` [LTP] " Subrata Modak
2009-06-18 17:31 ` Subrata Modak
2009-06-19 3:56 ` [LTP] cpusets: document adding/removing cpus to cpusetelaborately Nikanth Karthikesan
2009-06-17 0:45 ` cpusets: document adding/removing cpus to cpuset elaborately Li Zefan
2009-06-17 9:42 ` Paul Menage
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.