* [PATCH] driver core: remove unheeded warning about driver methods
@ 2009-06-17 15:59 Alan Stern
2009-06-17 16:25 ` Boaz Harrosh
0 siblings, 1 reply; 3+ messages in thread
From: Alan Stern @ 2009-06-17 15:59 UTC (permalink / raw)
To: Greg KH; +Cc: SCSI development list, Kernel development list
This patch (as1263) removes a warning which has been present for so
long, and consistently ignored, that it obviously is not doing any
good. It gets triggered on pretty much every boot by the SCSI disk
and cdrom drivers. Evidently nobody cares.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
---
Index: usb-2.6/drivers/base/driver.c
===================================================================
--- usb-2.6.orig/drivers/base/driver.c
+++ usb-2.6/drivers/base/driver.c
@@ -225,12 +225,6 @@ int driver_register(struct device_driver
BUG_ON(!drv->bus->p);
- if ((drv->bus->probe && drv->probe) ||
- (drv->bus->remove && drv->remove) ||
- (drv->bus->shutdown && drv->shutdown))
- printk(KERN_WARNING "Driver '%s' needs updating - please use "
- "bus_type methods\n", drv->name);
-
other = driver_find(drv->name, drv->bus);
if (other) {
put_driver(other);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] driver core: remove unheeded warning about driver methods
2009-06-17 15:59 [PATCH] driver core: remove unheeded warning about driver methods Alan Stern
@ 2009-06-17 16:25 ` Boaz Harrosh
2009-06-17 17:12 ` Alan Stern
0 siblings, 1 reply; 3+ messages in thread
From: Boaz Harrosh @ 2009-06-17 16:25 UTC (permalink / raw)
To: Alan Stern, Hannes Reinecke, James Bottomley
Cc: Greg KH, SCSI development list, Kernel development list,
Andrew Morton
On 06/17/2009 06:59 PM, Alan Stern wrote:
> This patch (as1263) removes a warning which has been present for so
> long, and consistently ignored, that it obviously is not doing any
> good. It gets triggered on pretty much every boot by the SCSI disk
> and cdrom drivers. Evidently nobody cares.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
>
> Index: usb-2.6/drivers/base/driver.c
> ===================================================================
> --- usb-2.6.orig/drivers/base/driver.c
> +++ usb-2.6/drivers/base/driver.c
> @@ -225,12 +225,6 @@ int driver_register(struct device_driver
>
> BUG_ON(!drv->bus->p);
>
> - if ((drv->bus->probe && drv->probe) ||
> - (drv->bus->remove && drv->remove) ||
> - (drv->bus->shutdown && drv->shutdown))
> - printk(KERN_WARNING "Driver '%s' needs updating - please use "
> - "bus_type methods\n", drv->name);
> -
> other = driver_find(drv->name, drv->bus);
> if (other) {
> put_driver(other);
>
> --
There was a proper and simple fix for that problem here:
http://www.spinics.net/lists/kernel/msg860289.html
Hannes please re push this patch properly. We want it ;)
Boaz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-17 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-17 15:59 [PATCH] driver core: remove unheeded warning about driver methods Alan Stern
2009-06-17 16:25 ` Boaz Harrosh
2009-06-17 17:12 ` Alan Stern
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.