[PATCH] xend: fix a regression in c/s 19791.

[PATCH] xend: fix a regression in c/s 19791.

[Kouya Shimura]

[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 289 bytes --]

Using changeset 19791:c0d2838fc10f, I can't create an HVM.
xend.log shows:

  File "usr/lib64/python2.4/site-packages/xen/xend/image.py", line 759, in configure
    store_dmargs.remove('-sdl')
ValueError: list.remove(x): x not in list

Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>


[-- Attachment #2: image.patch --]
[-- Type: text/x-patch, Size: 660 bytes --]

diff -r dc0d1200e3f3 tools/python/xen/xend/image.py
--- a/tools/python/xen/xend/image.py	Thu Jun 18 15:32:48 2009 +0100
+++ b/tools/python/xen/xend/image.py	Fri Jun 19 13:26:31 2009 +0900
@@ -755,9 +755,8 @@ class HVMImageHandler(ImageHandler):
         if not self.display :
             self.display = ''
 
-        store_dmargs = self.dmargs[:]
-        store_dmargs.remove('-sdl')
-        store_dmargs.remove('-disable-opengl')
+        store_dmargs = [ x for x in self.dmargs
+                         if x not in ['-sdl', '-disable-opengl'] ]
         try :
             midx = store_dmargs.index('-monitor')
             store_dmargs[midx + 1] = 'pty'

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] xend: fix a regression in c/s 19791.

[Jun Koi]

On Fri, Jun 19, 2009 at 1:53 PM, Kouya Shimura<kouya@jp.fujitsu.com> wrote:
> Using changeset 19791:c0d2838fc10f, I can't create an HVM.
> xend.log shows:

Which is your xen tree??

My current, and latest unstable CS is still 19745.

http://xenbits.xensource.com/xen-unstable.hg


Thanks,
J

Re: [PATCH] xend: fix a regression in c/s 19791.

[Kouya Shimura]

I'm using the staging tree.
http://xenbits.xensource.com/staging/xen-unstable.hg

-- Kouya

Jun Koi writes:
> On Fri, Jun 19, 2009 at 1:53 PM, Kouya Shimura<kouya@jp.fujitsu.com> wrote:
> > Using changeset 19791:c0d2838fc10f, I can't create an HVM.
> > xend.log shows:
> 
> Which is your xen tree??
> 
> My current, and latest unstable CS is still 19745.
> 
> http://xenbits.xensource.com/xen-unstable.hg
> 
> 
> Thanks,
> J

Re: [PATCH] xend: fix a regression in c/s 19791.

[Jun Koi]

On Fri, Jun 19, 2009 at 2:14 PM, Kouya Shimura<kouya@jp.fujitsu.com> wrote:
> I'm using the staging tree.
> http://xenbits.xensource.com/staging/xen-unstable.hg

I see.

But anyway, is it less confused to name it xen-stage.hg, rather than
xen-unstable.hg?

Thanks,
J



>
> -- Kouya
>
> Jun Koi writes:
>> On Fri, Jun 19, 2009 at 1:53 PM, Kouya Shimura<kouya@jp.fujitsu.com> wrote:
>> > Using changeset 19791:c0d2838fc10f, I can't create an HVM.
>> > xend.log shows:
>>
>> Which is your xen tree??
>>
>> My current, and latest unstable CS is still 19745.
>>
>> http://xenbits.xensource.com/xen-unstable.hg
>>
>>
>> Thanks,
>> J
>

Re: [PATCH] xend: fix a regression in c/s 19791.

[Ian Jackson]

Jun Koi writes ("Re: [Xen-devel] [PATCH] xend: fix a regression in c/s 19791."):
> On Fri, Jun 19, 2009 at 2:14 PM, Kouya Shimura<kouya@jp.fujitsu.com> wrote:
> > I'm using the staging tree.
> > http://xenbits.xensource.com/staging/xen-unstable.hg
> 
> I see.
> 
> But anyway, is it less confused to name it xen-stage.hg, rather than
> xen-unstable.hg?

There are staging trees for each branch, so xen-3.4-testing.hg has one
too, for example.  The full name of this tree is `Xen unstable staging'.

Ian.

Re: [PATCH] xend: fix a regression in c/s 19791.

[Stefano Stabellini]

Kouya Shimura wrote:

> Using changeset 19791:c0d2838fc10f, I can't create an HVM.
> xend.log shows:
> 
>   File "usr/lib64/python2.4/site-packages/xen/xend/image.py", line 759, in configure
>     store_dmargs.remove('-sdl')
> ValueError: list.remove(x): x not in list
> 
> Signed-off-by: Kouya Shimura <kouya@jp.fujitsu.com>
> 


Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>