* [Xenomai-help] kernel build fails with CONFIG_X86_MCE_P4THERMAL=y @ 2009-06-21 20:54 Stefan Kisdaroczi 2009-06-22 8:45 ` Philippe Gerum 0 siblings, 1 reply; 4+ messages in thread From: Stefan Kisdaroczi @ 2009-06-21 20:54 UTC (permalink / raw) To: xenomai hi, if 'check for P4 thermal throttling interrupt.' ( CONFIG_X86_MCE_P4THERMAL ) is enabled, kernel builds ok with 2.6.28, but fails with adeos-ipipe-2.6.29.5-x86-2.4-02.patch: arch/x86/kernel/ipipe.c: In function ‘__ipipe_enable_pipeline’: arch/x86/kernel/ipipe.c:210: error: ‘smp_thermal_interrupt’ undeclared (first use in this function) arch/x86/kernel/ipipe.c:210: error: (Each undeclared identifier is reported only once arch/x86/kernel/ipipe.c:210: error: for each function it appears in.) make[3]: *** [arch/x86/kernel/ipipe.o] Fehler 1 make[2]: *** [arch/x86/kernel] Fehler 2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xenomai-help] kernel build fails with CONFIG_X86_MCE_P4THERMAL=y 2009-06-21 20:54 [Xenomai-help] kernel build fails with CONFIG_X86_MCE_P4THERMAL=y Stefan Kisdaroczi @ 2009-06-22 8:45 ` Philippe Gerum 2009-06-22 18:42 ` Stefan Kisdaroczi 0 siblings, 1 reply; 4+ messages in thread From: Philippe Gerum @ 2009-06-22 8:45 UTC (permalink / raw) To: Stefan Kisdaroczi; +Cc: xenomai On Sun, 2009-06-21 at 22:54 +0200, Stefan Kisdaroczi wrote: > hi, > > if 'check for P4 thermal throttling interrupt.' ( > CONFIG_X86_MCE_P4THERMAL ) is enabled, kernel builds ok with 2.6.28, but > fails with adeos-ipipe-2.6.29.5-x86-2.4-02.patch: > > arch/x86/kernel/ipipe.c: In function ‘__ipipe_enable_pipeline’: > arch/x86/kernel/ipipe.c:210: error: ‘smp_thermal_interrupt’ undeclared > (first use in this function) > arch/x86/kernel/ipipe.c:210: error: (Each undeclared identifier is > reported only once > arch/x86/kernel/ipipe.c:210: error: for each function it appears in.) > make[3]: *** [arch/x86/kernel/ipipe.o] Fehler 1 > make[2]: *** [arch/x86/kernel] Fehler 2 > Thanks. I will push 2.4-03 out after I have received confirmation that everything is fine on your side. TIA, diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c index 28cc903..d186a4c 100644 --- a/arch/x86/kernel/ipipe.c +++ b/arch/x86/kernel/ipipe.c @@ -116,6 +116,9 @@ void smp_invalidate_interrupt(struct pt_regs *regs); void smp_call_function_interrupt(struct pt_regs *regs); void smp_call_function_single_interrupt(struct pt_regs *regs); void uv_bau_message_interrupt(struct pt_regs *regs); +#ifdef CONFIG_X86_32 +void smp_thermal_interrupt(struct pt_regs *regs); +#endif static void __ipipe_ack_irq(unsigned irq, struct irq_desc *desc) { > > _______________________________________________ > Xenomai-help mailing list > Xenomai-help@domain.hid > https://mail.gna.org/listinfo/xenomai-help -- Philippe. ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Xenomai-help] kernel build fails with CONFIG_X86_MCE_P4THERMAL=y 2009-06-22 8:45 ` Philippe Gerum @ 2009-06-22 18:42 ` Stefan Kisdaroczi 2009-06-22 19:45 ` Philippe Gerum 0 siblings, 1 reply; 4+ messages in thread From: Stefan Kisdaroczi @ 2009-06-22 18:42 UTC (permalink / raw) To: Philippe Gerum; +Cc: xenomai Philippe Gerum schrieb: > On Sun, 2009-06-21 at 22:54 +0200, Stefan Kisdaroczi wrote: > >> hi, >> >> if 'check for P4 thermal throttling interrupt.' ( >> CONFIG_X86_MCE_P4THERMAL ) is enabled, kernel builds ok with 2.6.28, but >> fails with adeos-ipipe-2.6.29.5-x86-2.4-02.patch: >> >> arch/x86/kernel/ipipe.c: In function ‘__ipipe_enable_pipeline’: >> arch/x86/kernel/ipipe.c:210: error: ‘smp_thermal_interrupt’ undeclared >> (first use in this function) >> arch/x86/kernel/ipipe.c:210: error: (Each undeclared identifier is >> reported only once >> arch/x86/kernel/ipipe.c:210: error: for each function it appears in.) >> make[3]: *** [arch/x86/kernel/ipipe.o] Fehler 1 >> make[2]: *** [arch/x86/kernel] Fehler 2 >> >> > > Thanks. I will push 2.4-03 out after I have received confirmation that > everything is fine on your side. TIA, > the kernel compiled fine now with P4THERMAL enabled. thanks. hint: did you notice the CONFIG_X86_64 ? same problem ? +#if defined(CONFIG_X86_MCE_P4THERMAL) || defined(CONFIG_X86_64) + ipipe_virtualize_irq(ipipe_root_domain, + ipipe_apic_vector_irq(THERMAL_APIC_VECTOR), + (ipipe_irq_handler_t)&smp_thermal_interrupt, + NULL, + &__ipipe_ack_apic, + IPIPE_STDROOT_MASK); +#endif /* CONFIG_X86_MCE_P4THERMAL || CONFIG_X86_64 */ > diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c > index 28cc903..d186a4c 100644 > --- a/arch/x86/kernel/ipipe.c > +++ b/arch/x86/kernel/ipipe.c > @@ -116,6 +116,9 @@ void smp_invalidate_interrupt(struct pt_regs *regs); > void smp_call_function_interrupt(struct pt_regs *regs); > void smp_call_function_single_interrupt(struct pt_regs *regs); > void uv_bau_message_interrupt(struct pt_regs *regs); > +#ifdef CONFIG_X86_32 > +void smp_thermal_interrupt(struct pt_regs *regs); > +#endif > > static void __ipipe_ack_irq(unsigned irq, struct irq_desc *desc) > { > > >> _______________________________________________ >> Xenomai-help mailing list >> Xenomai-help@domain.hid >> https://mail.gna.org/listinfo/xenomai-help >> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xenomai-help] kernel build fails with CONFIG_X86_MCE_P4THERMAL=y 2009-06-22 18:42 ` Stefan Kisdaroczi @ 2009-06-22 19:45 ` Philippe Gerum 0 siblings, 0 replies; 4+ messages in thread From: Philippe Gerum @ 2009-06-22 19:45 UTC (permalink / raw) To: Stefan Kisdaroczi; +Cc: xenomai On Mon, 2009-06-22 at 20:42 +0200, Stefan Kisdaroczi wrote: > Philippe Gerum schrieb: > > On Sun, 2009-06-21 at 22:54 +0200, Stefan Kisdaroczi wrote: > > > >> hi, > >> > >> if 'check for P4 thermal throttling interrupt.' ( > >> CONFIG_X86_MCE_P4THERMAL ) is enabled, kernel builds ok with 2.6.28, but > >> fails with adeos-ipipe-2.6.29.5-x86-2.4-02.patch: > >> > >> arch/x86/kernel/ipipe.c: In function ‘__ipipe_enable_pipeline’: > >> arch/x86/kernel/ipipe.c:210: error: ‘smp_thermal_interrupt’ undeclared > >> (first use in this function) > >> arch/x86/kernel/ipipe.c:210: error: (Each undeclared identifier is > >> reported only once > >> arch/x86/kernel/ipipe.c:210: error: for each function it appears in.) > >> make[3]: *** [arch/x86/kernel/ipipe.o] Fehler 1 > >> make[2]: *** [arch/x86/kernel] Fehler 2 > >> > >> > > > > Thanks. I will push 2.4-03 out after I have received confirmation that > > everything is fine on your side. TIA, > > > the kernel compiled fine now with P4THERMAL enabled. thanks. > hint: did you notice the CONFIG_X86_64 ? same problem ? > X86_64 declares smp_thermal_interrupt() properly in asm/traps.h, not X86_32 unfortunately. > +#if defined(CONFIG_X86_MCE_P4THERMAL) || defined(CONFIG_X86_64) > + ipipe_virtualize_irq(ipipe_root_domain, > + ipipe_apic_vector_irq(THERMAL_APIC_VECTOR), > + (ipipe_irq_handler_t)&smp_thermal_interrupt, > + NULL, > + &__ipipe_ack_apic, > + IPIPE_STDROOT_MASK); > +#endif /* CONFIG_X86_MCE_P4THERMAL || CONFIG_X86_64 */ > > > diff --git a/arch/x86/kernel/ipipe.c b/arch/x86/kernel/ipipe.c > > index 28cc903..d186a4c 100644 > > --- a/arch/x86/kernel/ipipe.c > > +++ b/arch/x86/kernel/ipipe.c > > @@ -116,6 +116,9 @@ void smp_invalidate_interrupt(struct pt_regs *regs); > > void smp_call_function_interrupt(struct pt_regs *regs); > > void smp_call_function_single_interrupt(struct pt_regs *regs); > > void uv_bau_message_interrupt(struct pt_regs *regs); > > +#ifdef CONFIG_X86_32 > > +void smp_thermal_interrupt(struct pt_regs *regs); > > +#endif > > > > static void __ipipe_ack_irq(unsigned irq, struct irq_desc *desc) > > { > > > > > >> _______________________________________________ > >> Xenomai-help mailing list > >> Xenomai-help@domain.hid > >> https://mail.gna.org/listinfo/xenomai-help > >> > -- Philippe. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-22 19:45 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-06-21 20:54 [Xenomai-help] kernel build fails with CONFIG_X86_MCE_P4THERMAL=y Stefan Kisdaroczi 2009-06-22 8:45 ` Philippe Gerum 2009-06-22 18:42 ` Stefan Kisdaroczi 2009-06-22 19:45 ` Philippe Gerum
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.