[Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Sebastian Smolorz]

Hi Philippe,

with latest head it is not possible to build the POSIX skin as module. It 
gives:

ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
undefined!

Obviously an

EXPORT_SYMBOL(xnarch_divrem_billion);

is missing.

-- 
Sebastian

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Gilles Chanteperdrix]

Sebastian Smolorz wrote:
> Hi Philippe,
> 
> with latest head it is not possible to build the POSIX skin as module. It 
> gives:
> 
> ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
> undefined!
> 
> Obviously an
> 
> EXPORT_SYMBOL(xnarch_divrem_billion);
> 
> is missing.

Well, no. The definition of xnarh_divrem_billion is in the timeconv.h
header, which should be included in places where this function is
needed. So, what is missing is probably a #include. But Ok, thanks for
taking care of testing 2.5-rc2.

-- 
                                          Gilles

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Sebastian Smolorz]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Gilles Chanteperdrix wrote:
> Sebastian Smolorz wrote:
> > Hi Philippe,
> >
> > with latest head it is not possible to build the POSIX skin as module.
> > It gives:
> >
> > ERROR: "xnarch_divrem_billion"
> > [kernel/xenomai/skins/posix/xeno_posix.ko] undefined!
> >
> > Obviously an
> >
> > EXPORT_SYMBOL(xnarch_divrem_billion);
> >
> > is missing.
>
> Well, no. The definition of xnarh_divrem_billion is in the timeconv.h
> header, which should be included in places where this function is
> needed. So, what is missing is probably a #include.

Hm, I don't think so. The error only appears when building the POSIX skin as 
module. The attached patch fixes the problem.

-- 
Sebastian


[-- Attachment #2: timeconv.h.patch --]
[-- Type: text/x-patch, Size: 486 bytes --]

diff --git a/include/asm-generic/bits/timeconv.h b/include/asm-generic/bits/timeconv.h
index 7d823f7..79060b3 100644
--- a/include/asm-generic/bits/timeconv.h
+++ b/include/asm-generic/bits/timeconv.h
@@ -93,6 +93,7 @@ static inline void xnarch_init_timeconv(unsigned long long freq)
 #ifdef __KERNEL__
 EXPORT_SYMBOL(xnarch_tsc_to_ns);
 EXPORT_SYMBOL(xnarch_ns_to_tsc);
+EXPORT_SYMBOL(xnarch_divrem_billion);
 #endif /* __KERNEL__ */
 
 #endif /* !_XENO_ASM_GENERIC_BITS_TIMECONV_H */

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Philippe Gerum]

On Mon, 2009-06-22 at 12:45 +0200, Sebastian Smolorz wrote:
> Hi Philippe,
> 
> with latest head it is not possible to build the POSIX skin as module. It 
> gives:
> 
> ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
> undefined!
> 
> Obviously an
> 
> EXPORT_SYMBOL(xnarch_divrem_billion);
> 
> is missing.
> 

Indeed. Thanks,
http://git.xenomai.org/?p=xenomai-head.git;a=commit;h=7847120b2d84900941d2a40251e28636d9cbc682

-- 
Philippe.

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Philippe Gerum]

On Mon, 2009-06-22 at 14:06 +0200, Gilles Chanteperdrix wrote:
> Sebastian Smolorz wrote:
> > Hi Philippe,
> > 
> > with latest head it is not possible to build the POSIX skin as module. It 
> > gives:
> > 
> > ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
> > undefined!
> > 
> > Obviously an
> > 
> > EXPORT_SYMBOL(xnarch_divrem_billion);
> > 
> > is missing.
> 
> Well, no. The definition of xnarh_divrem_billion is in the timeconv.h
> header, which should be included in places where this function is
> needed.

Actually, this is no inline stuff anymore, so we do need an export just
like tsc_to_ns and converse op.

>  So, what is missing is probably a #include. But Ok, thanks for
> taking care of testing 2.5-rc2.
> 
-- 
Philippe.

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Gilles Chanteperdrix]

Philippe Gerum wrote:
> On Mon, 2009-06-22 at 14:06 +0200, Gilles Chanteperdrix wrote:
>> Sebastian Smolorz wrote:
>>> Hi Philippe,
>>>
>>> with latest head it is not possible to build the POSIX skin as module. It 
>>> gives:
>>>
>>> ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
>>> undefined!
>>>
>>> Obviously an
>>>
>>> EXPORT_SYMBOL(xnarch_divrem_billion);
>>>
>>> is missing.
>> Well, no. The definition of xnarh_divrem_billion is in the timeconv.h
>> header, which should be included in places where this function is
>> needed.
> 
> Actually, this is no inline stuff anymore, so we do need an export just
> like tsc_to_ns and converse op.

Well, I still see its definition in timeconv.h, the only way I see to
get an undefined symbol would be to use the function without including
timeconv.h.

And indeed, ksrc/skins/posix/internal.h, which uses
xnarch_divrem_billion does not include timeconv.h

-- 
                                          Gilles

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Philippe Gerum]

On Mon, 2009-06-22 at 14:47 +0200, Gilles Chanteperdrix wrote:
> Philippe Gerum wrote:
> > On Mon, 2009-06-22 at 14:06 +0200, Gilles Chanteperdrix wrote:
> >> Sebastian Smolorz wrote:
> >>> Hi Philippe,
> >>>
> >>> with latest head it is not possible to build the POSIX skin as module. It 
> >>> gives:
> >>>
> >>> ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
> >>> undefined!
> >>>
> >>> Obviously an
> >>>
> >>> EXPORT_SYMBOL(xnarch_divrem_billion);
> >>>
> >>> is missing.
> >> Well, no. The definition of xnarh_divrem_billion is in the timeconv.h
> >> header, which should be included in places where this function is
> >> needed.
> > 
> > Actually, this is no inline stuff anymore, so we do need an export just
> > like tsc_to_ns and converse op.
> 
> Well, I still see its definition in timeconv.h, the only way I see to
> get an undefined symbol would be to use the function without including
> timeconv.h.
> 
> And indeed, ksrc/skins/posix/internal.h, which uses
> xnarch_divrem_billion does not include timeconv.h
> 

timeconv.h is not for direct inclusion, this is merely an instantiation
file that works both for kernel space and userland. Callers should
include asm/xenomai/system.h instead.

-- 
Philippe.

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Gilles Chanteperdrix]

Philippe Gerum wrote:
> On Mon, 2009-06-22 at 14:47 +0200, Gilles Chanteperdrix wrote:
>> Philippe Gerum wrote:
>>> On Mon, 2009-06-22 at 14:06 +0200, Gilles Chanteperdrix wrote:
>>>> Sebastian Smolorz wrote:
>>>>> Hi Philippe,
>>>>>
>>>>> with latest head it is not possible to build the POSIX skin as module. It 
>>>>> gives:
>>>>>
>>>>> ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
>>>>> undefined!
>>>>>
>>>>> Obviously an
>>>>>
>>>>> EXPORT_SYMBOL(xnarch_divrem_billion);
>>>>>
>>>>> is missing.
>>>> Well, no. The definition of xnarh_divrem_billion is in the timeconv.h
>>>> header, which should be included in places where this function is
>>>> needed.
>>> Actually, this is no inline stuff anymore, so we do need an export just
>>> like tsc_to_ns and converse op.
>> Well, I still see its definition in timeconv.h, the only way I see to
>> get an undefined symbol would be to use the function without including
>> timeconv.h.
>>
>> And indeed, ksrc/skins/posix/internal.h, which uses
>> xnarch_divrem_billion does not include timeconv.h
>>
> 
> timeconv.h is not for direct inclusion, this is merely an instantiation
> file that works both for kernel space and userland. Callers should
> include asm/xenomai/system.h instead.

posix skin is also borken in user-space then, since it includes timeconv.h.

-- 
                                          Gilles

Re: [Xenomai-core] [BUG] [xenomai-head] xeno_posix.ko cannot be built

[Philippe Gerum]

On Mon, 2009-06-22 at 15:23 +0200, Gilles Chanteperdrix wrote:
> Philippe Gerum wrote:
> > On Mon, 2009-06-22 at 14:47 +0200, Gilles Chanteperdrix wrote:
> >> Philippe Gerum wrote:
> >>> On Mon, 2009-06-22 at 14:06 +0200, Gilles Chanteperdrix wrote:
> >>>> Sebastian Smolorz wrote:
> >>>>> Hi Philippe,
> >>>>>
> >>>>> with latest head it is not possible to build the POSIX skin as module. It 
> >>>>> gives:
> >>>>>
> >>>>> ERROR: "xnarch_divrem_billion" [kernel/xenomai/skins/posix/xeno_posix.ko] 
> >>>>> undefined!
> >>>>>
> >>>>> Obviously an
> >>>>>
> >>>>> EXPORT_SYMBOL(xnarch_divrem_billion);
> >>>>>
> >>>>> is missing.
> >>>> Well, no. The definition of xnarh_divrem_billion is in the timeconv.h
> >>>> header, which should be included in places where this function is
> >>>> needed.
> >>> Actually, this is no inline stuff anymore, so we do need an export just
> >>> like tsc_to_ns and converse op.
> >> Well, I still see its definition in timeconv.h, the only way I see to
> >> get an undefined symbol would be to use the function without including
> >> timeconv.h.
> >>
> >> And indeed, ksrc/skins/posix/internal.h, which uses
> >> xnarch_divrem_billion does not include timeconv.h
> >>
> > 
> > timeconv.h is not for direct inclusion, this is merely an instantiation
> > file that works both for kernel space and userland. Callers should
> > include asm/xenomai/system.h instead.
> 
> posix skin is also borken in user-space then, since it includes timeconv.h.
> 

No, since userland only includes timeconv.h once in the implementation
file of time-related routines, which is mutually exclusive with
asm-generic/system.h which is only for kernel-based code.

-- 
Philippe.