Re: [PATCH] Warn if a qcow (not qcow2) file is opened

[Avi Kivity <avi@redhat.com>]

On 06/30/2009 04:32 PM, Anthony Liguori wrote:
> Kevin Wolf wrote:
>> Avi Kivity schrieb:
>>> The qcow block driver format is no longer maintained and likely 
>>> contains
>>> serious data corruptors.  Urge users to stay away for it, and advertise
>>> the new and improved replacement.
>>>
>>> Signed-off-by: Avi Kivity <avi@redhat.com>
>>
>> vvfat is using qcow internally, so the warning will appear there, too.
>> Not that warning against vvfat would be a bad thing, but this error
>> message could be confusing.
>>
>> Maybe we're lucky enough and vvfat survives a s/qcow/qcow2/, but I
>> really never wanted to touch that code...
>
> I'm not sure how I feel about this.  Can we prove qcow is broken?  Is 
> it only broken for writes and not reads?

Well, Kevin posted a patch, so it is.  It's definitely unmaintained.  
Given it's a qemu native format, there is no interoperability value 
except with old qemu versions.

>
> If we're printing a warning, does that mean we want to deprecate qcow 
> and eventually remove it (or remove write support, at least)?

Yes.

-- 
error compiling committee.c: too many arguments to function