Re: [PATCH] SElinux: Fix some typos.

["Justin P. Mattock" <justinmattock@gmail.com>]

James Morris wrote:
> On Thu, 2 Jul 2009, Justin P. Mattock wrote:
>
>    
>> Signed-off-by: Justin P. Mattock<justinmattock@gmail.com>
>>
>> Fix some typos in some comments.
>>      
>
>    
>> -/* The file system's label must be initialized prior to use. */
>> +/* The filesystems label must be initialized prior to use. */
>>      
>
> Your adding grammertical error's.
>
>    
well, after figuring out how to have git send -email functioning correctly,
I needed something to send.      : ^ )
(but after doing a quick google filesystem did show up).
>> -	 * Note that the setting of hard limits (even to lower them) can be
>> +	 * Note: That the setting of hard limits (even to lower them) can be
>>      
>
> Please get this patch reviewed by an English speaker.
>
>    
That seems viable to me.
>>    * Description:
>>    * Call the NetLabel mechanism to get the security attributes of the given
>> - * packet and use those attributes to determine the correct context/SID to
>> - * assign to the packet.  Returns zero on success, negative values on failure.
>> + * packet and use those attributes to determine the correct context/SID to be
>> + * assigned to the packet.  Returns zero on success, negative values on failure.
>>      
>
> Eschew the active voice?
>
>
> - James
>    
wast ist das?
No I will not be afraid of submitting patches, and having them be rejected.
all part of the learning curve.

Justin P. Mattock

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.