From: Gui Jianfeng <guijianfeng-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
To: Li Zefan <lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Cc: Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
Paul Menage <menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cgroup: Fix indent for /proc/cgroups
Date: Fri, 03 Jul 2009 17:00:19 +0800 [thread overview]
Message-ID: <4A4DC8A3.9040709@cn.fujitsu.com> (raw)
In-Reply-To: <4A4DC4CF.4020808-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
Li Zefan wrote:
> Gui Jianfeng wrote:
>> Li Zefan wrote:
>>> CC: container list
>>>
>>> Gui Jianfeng wrote:
>>>> Currently, /proc/cgroups outputs is fairly ugly as following,
>>>> #subsys_name hierarchy num_cgroups enabled
>>>> cpuset 0 1 1
>>>> debug 0 1 1
>>>> ns 0 1 1
>>>>
>>>> indent it in a good-looking way.
>>>> #subsys_name hierarchy num_cgroups enabled
>>>> cpuset 0 1 1
>>>> debug 0 1 1
>>>> ns 0 1 1
>>>>
>>> But if there's a subsystem with name length >= 8,
>>> it won't be aligned properly..
>> Yeap, but there isn't such a case at least by now.
>>
>
> This is not a good reason.
>
> We'll probably have such a subsystem. Actually there's a
> proposed subsystem named "maxdepth" which is of length 8.
>
> See:
> http://lkml.org/lkml/2009/7/1/581
yes, this is a case. But at least others can be aligned
properly, right? Anyway, please ignore it if you don't
like this change.
>
>
>
>
--
Regards
Gui Jianfeng
WARNING: multiple messages have this Message-ID (diff)
From: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Paul Menage <menage@google.com>,
linux-kernel@vger.kernel.org,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] cgroup: Fix indent for /proc/cgroups
Date: Fri, 03 Jul 2009 17:00:19 +0800 [thread overview]
Message-ID: <4A4DC8A3.9040709@cn.fujitsu.com> (raw)
In-Reply-To: <4A4DC4CF.4020808@cn.fujitsu.com>
Li Zefan wrote:
> Gui Jianfeng wrote:
>> Li Zefan wrote:
>>> CC: container list
>>>
>>> Gui Jianfeng wrote:
>>>> Currently, /proc/cgroups outputs is fairly ugly as following,
>>>> #subsys_name hierarchy num_cgroups enabled
>>>> cpuset 0 1 1
>>>> debug 0 1 1
>>>> ns 0 1 1
>>>>
>>>> indent it in a good-looking way.
>>>> #subsys_name hierarchy num_cgroups enabled
>>>> cpuset 0 1 1
>>>> debug 0 1 1
>>>> ns 0 1 1
>>>>
>>> But if there's a subsystem with name length >= 8,
>>> it won't be aligned properly..
>> Yeap, but there isn't such a case at least by now.
>>
>
> This is not a good reason.
>
> We'll probably have such a subsystem. Actually there's a
> proposed subsystem named "maxdepth" which is of length 8.
>
> See:
> http://lkml.org/lkml/2009/7/1/581
yes, this is a case. But at least others can be aligned
properly, right? Anyway, please ignore it if you don't
like this change.
>
>
>
>
--
Regards
Gui Jianfeng
next prev parent reply other threads:[~2009-07-03 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 8:05 [PATCH] cgroup: Fix indent for /proc/cgroups Gui Jianfeng
2009-07-03 8:20 ` Li Zefan
[not found] ` <4A4DBF50.8090408-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-07-03 8:37 ` Gui Jianfeng
2009-07-03 8:37 ` Gui Jianfeng
[not found] ` <4A4DC358.7030900-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-07-03 8:43 ` Li Zefan
2009-07-03 8:43 ` Li Zefan
[not found] ` <4A4DC4CF.4020808-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-07-03 9:00 ` Gui Jianfeng [this message]
2009-07-03 9:00 ` Gui Jianfeng
[not found] ` <4A4DBBC2.8010805-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2009-07-03 8:20 ` Li Zefan
2009-07-03 15:37 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4DC8A3.9040709@cn.fujitsu.com \
--to=guijianfeng-bthxqxjhjhxqfuhtdcdx3a@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizf-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
--cc=menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.