[PATCH] x86 shadow: disable fast np path in OOS.

[PATCH] x86 shadow: disable fast np path in OOS.

[Gianluca Guida]

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

As discussed, this patch disables fast NP path when OOS is enabled.

Signed off by: Gianluca Guida <gianluca.guida@eu.citrix.com>

[-- Attachment #2: disable-fastgnp.patch --]
[-- Type: text/x-diff, Size: 587 bytes --]

diff -r 7397608bce87 xen/arch/x86/mm/shadow/multi.c
--- a/xen/arch/x86/mm/shadow/multi.c	Mon Jun 29 15:50:32 2009 +0100
+++ b/xen/arch/x86/mm/shadow/multi.c	Fri Jul 03 14:49:37 2009 +0100
@@ -494,11 +494,13 @@
 
     if ( unlikely(!(gflags & _PAGE_PRESENT)) )
     {
+#if !(SHADOW_OPTIMIZATIONS & SHOPT_OUT_OF_SYNC)
         /* If a guest l1 entry is not present, shadow with the magic 
          * guest-not-present entry. */
         if ( level == 1 )
             *sp = sh_l1e_gnp();
         else 
+#endif /* !OOS */
             *sp = shadow_l1e_empty();
         goto done;
     }

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] x86 shadow: disable fast np path in OOS.

[Frank van der Linden]

Gianluca Guida wrote:
> As discussed, this patch disables fast NP path when OOS is enabled.
> 
> Signed off by: Gianluca Guida <gianluca.guida@eu.citrix.com>

Both of your patches look good to me. I can't think of a scenario where 
the same problem would occur again with your patches, and with them 
applied, I can't reproduce the problem anymore (on a setup that 
reproduced it reliably before).

Thanks for the quick fix,

- Frank