All of lore.kernel.org
 help / color / mirror / Atom feed
* [lm-sensors] no PWM output with pwmconfig
@ 2009-07-01 17:22 Niels
  2009-07-03  7:46 ` Jean Delvare
                   ` (10 more replies)
  0 siblings, 11 replies; 12+ messages in thread
From: Niels @ 2009-07-01 17:22 UTC (permalink / raw)
  To: lm-sensors

[-- Attachment #1: Type: text/html, Size: 2052 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
@ 2009-07-03  7:46 ` Jean Delvare
  2009-07-03 13:54 ` Niels
                   ` (9 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Jean Delvare @ 2009-07-03  7:46 UTC (permalink / raw)
  To: lm-sensors

Hi Niels,

On Wed, 01 Jul 2009 19:22:04 +0200, Niels wrote:
> I'm having trouble with my pwmconfig.
> 
> Code:
> Found the following PWM controls:
>    hwmon2/device/pwm1
>    hwmon2/device/pwm2
>    hwmon2/device/pwm3
> There are no usable PWM outputs.

Which version of lm-sensors (or pwmconfig) is this?

I would like to see the full output of pwmconfig and not just the above
summary.

> Though my sensors cleary reads out the fans

Many boards can monitor the fans but not control them. What board is it?

> 
> Code:
> nelis@nelis-desktop:~$ sensors
> acpitz-virtual-0
> Adapter: Virtual device
> temp1:       +41.0°C  (crit = +70.0°C)
> k8temp-pci-00c3
> Adapter: PCI adapter
> Core0 Temp:  +36.0°C
> Core1 Temp:  -49.0°C
> f71862fg-isa-0220
> Adapter: ISA adapter
> in0:         +1.70 V
> in1:         +2.04 V
> in2:         +1.20 V
> in3:         +2.04 V
> in4:         +1.34 V
> in5:         +1.18 V
> in6:         +1.18 V
> in7:         +1.68 V
> in8:         +1.66 V
> fan1:       2538 RPM
> fan2:       2222 RPM
> fan3:          0 RPM  ALARM
> temp1:       +41.0°C  (high = +85.0°C, hyst = +81.0°C)
>                       (crit = +70.0°C, hyst = +66.0°C)  sensor = transistor
> temp2:       +89.0°C  (high = +85.0°C, hyst = +81.0°C)  ALARM
>                       (crit = +100.0°C, hyst = +96.0°C)  sensor = transistor
> temp3:       +44.0°C  (high = +254.0°C, hyst = +252.0°C)
>                       (crit = +254.0°C, hyst = +252.0°C)  sensor = transistor
> 
> Anyone got an idea on how to deal with this ?

I would be interested in the output of the following commands:

grep -H . /sys/class/hwmon/hwmon*/device/name
grep -H . /sys/class/hwmon/hwmon*/device/pwm*
ls -l /sys/class/hwmon/hwmon*/device/pwm*

-- 
Jean Delvare
http://khali.linux-fr.org/wishlist.html

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
  2009-07-03  7:46 ` Jean Delvare
@ 2009-07-03 13:54 ` Niels
  2009-07-03 14:27 ` Jean Delvare
                   ` (8 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Niels @ 2009-07-03 13:54 UTC (permalink / raw)
  To: lm-sensors

Jean Delvare wrote:
> Hi Niels,
>
> On Wed, 01 Jul 2009 19:22:04 +0200, Niels wrote:
>   
>> I'm having trouble with my pwmconfig.
>>
>> Code:
>> Found the following PWM controls:
>>    hwmon2/device/pwm1
>>    hwmon2/device/pwm2
>>    hwmon2/device/pwm3
>> There are no usable PWM outputs.
>>     
>
> Which version of lm-sensors (or pwmconfig) is this?
>
> I would like to see the full output of pwmconfig and not just the above
> summary.
>     
>   
nelis@nelis-desktop:~$ sensors -v
sensors version 3.1.1+SVN with libsensors version 3.1.1+SVN


nelis@nelis-desktop:~$ pwmconfig
# pwmconfig revision 5630 (2009-01-29)
This program will search your sensors for pulse width modulation (pwm)
controls, and test each one to see if it controls a fan on
your motherboard. Note that many motherboards do not have pwm
circuitry installed, even if your sensor chip supports pwm.

We will attempt to briefly stop each fan using the pwm controls.
The program will attempt to restore each fan to full speed
after testing. However, it is ** very important ** that you
physically verify that the fans have been to full speed
after the program has completed.

Found the following devices:
   hwmon0 is acpitz
   hwmon1/device is k8temp
   hwmon2/device is f71862fg

Found the following PWM controls:
   hwmon2/device/pwm1
   hwmon2/device/pwm2
   hwmon2/device/pwm3
There are no usable PWM outputs.



>> Though my sensors cleary reads out the fans
>>     
>
> Many boards can monitor the fans but not control them. What board is it?
>
>   
Jetway NC81-LF http://www.jetwaycomputer.com/NC81.html
>> Code:
>> nelis@nelis-desktop:~$ sensors
>> acpitz-virtual-0
>> Adapter: Virtual device
>> temp1:       +41.0°C  (crit = +70.0°C)
>> k8temp-pci-00c3
>> Adapter: PCI adapter
>> Core0 Temp:  +36.0°C
>> Core1 Temp:  -49.0°C
>> f71862fg-isa-0220
>> Adapter: ISA adapter
>> in0:         +1.70 V
>> in1:         +2.04 V
>> in2:         +1.20 V
>> in3:         +2.04 V
>> in4:         +1.34 V
>> in5:         +1.18 V
>> in6:         +1.18 V
>> in7:         +1.68 V
>> in8:         +1.66 V
>> fan1:       2538 RPM
>> fan2:       2222 RPM
>> fan3:          0 RPM  ALARM
>> temp1:       +41.0°C  (high = +85.0°C, hyst = +81.0°C)
>>                       (crit = +70.0°C, hyst = +66.0°C)  sensor = transistor
>> temp2:       +89.0°C  (high = +85.0°C, hyst = +81.0°C)  ALARM
>>                       (crit = +100.0°C, hyst = +96.0°C)  sensor = transistor
>> temp3:       +44.0°C  (high = +254.0°C, hyst = +252.0°C)
>>                       (crit = +254.0°C, hyst = +252.0°C)  sensor = transistor
>>
>> Anyone got an idea on how to deal with this ?
>>     
>
> I would be interested in the output of the following commands:
>
> grep -H . /sys/class/hwmon/hwmon*/device/name
> grep -H . /sys/class/hwmon/hwmon*/device/pwm*
> ls -l /sys/class/hwmon/hwmon*/device/pwm*
>
>   
nelis@nelis-desktop:~$ grep -H . /sys/class/hwmon/hwmon*/device/name
/sys/class/hwmon/hwmon1/device/name:k8temp
/sys/class/hwmon/hwmon2/device/name:f71862fg

nelis@nelis-desktop:~$ grep -H . /sys/class/hwmon/hwmon*/device/pwm*
/sys/class/hwmon/hwmon2/device/pwm1:81
/sys/class/hwmon/hwmon2/device/pwm1_auto_channels_temp:1
/sys/class/hwmon/hwmon2/device/pwm1_auto_point1_pwm:90
/sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp:60000
/sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp_hyst:56000
/sys/class/hwmon/hwmon2/device/pwm1_auto_point2_pwm:80
/sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp:35000
/sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp_hyst:31000
/sys/class/hwmon/hwmon2/device/pwm1_enable:2
/sys/class/hwmon/hwmon2/device/pwm1_interpolate:1
/sys/class/hwmon/hwmon2/device/pwm2:255
/sys/class/hwmon/hwmon2/device/pwm2_auto_channels_temp:2
/sys/class/hwmon/hwmon2/device/pwm2_auto_point1_pwm:217
/sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp:60000
/sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp_hyst:56000
/sys/class/hwmon/hwmon2/device/pwm2_auto_point2_pwm:128
/sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp:30000
/sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp_hyst:26000
/sys/class/hwmon/hwmon2/device/pwm2_enable:2
/sys/class/hwmon/hwmon2/device/pwm2_interpolate:1
/sys/class/hwmon/hwmon2/device/pwm3:155
/sys/class/hwmon/hwmon2/device/pwm3_auto_channels_temp:4
/sys/class/hwmon/hwmon2/device/pwm3_auto_point1_pwm:217
/sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp:60000
/sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp_hyst:58000
/sys/class/hwmon/hwmon2/device/pwm3_auto_point2_pwm:128
/sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp:30000
/sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp_hyst:28000
/sys/class/hwmon/hwmon2/device/pwm3_enable:2
/sys/class/hwmon/hwmon2/device/pwm3_interpolate:1

nelis@nelis-desktop:~$ ls -l /sys/class/hwmon/hwmon*/device/pwm*
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_auto_channels_temp
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_auto_point1_pwm
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp_hyst
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_auto_point2_pwm
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp
-r--r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp_hyst
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_enable
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm1_interpolate
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_auto_channels_temp
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_auto_point1_pwm
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp_hyst
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_auto_point2_pwm
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp
-r--r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp_hyst
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_enable
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm2_interpolate
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_auto_channels_temp
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_auto_point1_pwm
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp_hyst
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_auto_point2_pwm
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp
-r--r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp_hyst
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_enable
-rw-r--r-- 1 root root 4096 2009-07-03 15:44 
/sys/class/hwmon/hwmon2/device/pwm3_interpolate


I hope this helps,
Thanks for looking in to this.

Niels




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
  2009-07-03  7:46 ` Jean Delvare
  2009-07-03 13:54 ` Niels
@ 2009-07-03 14:27 ` Jean Delvare
  2009-07-03 14:35 ` Hans de Goede
                   ` (7 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Jean Delvare @ 2009-07-03 14:27 UTC (permalink / raw)
  To: lm-sensors

Hi Niels,

On Fri, 03 Jul 2009 15:54:29 +0200, Niels wrote:
> Jean Delvare wrote:
> > Which version of lm-sensors (or pwmconfig) is this?
> >
> > I would like to see the full output of pwmconfig and not just the above
> > summary.
>
> nelis@nelis-desktop:~$ sensors -v
> sensors version 3.1.1+SVN with libsensors version 3.1.1+SVN
> 
> 
> nelis@nelis-desktop:~$ pwmconfig
> # pwmconfig revision 5630 (2009-01-29)
> This program will search your sensors for pulse width modulation (pwm)
> controls, and test each one to see if it controls a fan on
> your motherboard. Note that many motherboards do not have pwm
> circuitry installed, even if your sensor chip supports pwm.
> 
> We will attempt to briefly stop each fan using the pwm controls.
> The program will attempt to restore each fan to full speed
> after testing. However, it is ** very important ** that you
> physically verify that the fans have been to full speed
> after the program has completed.
> 
> Found the following devices:
>    hwmon0 is acpitz
>    hwmon1/device is k8temp
>    hwmon2/device is f71862fg
> 
> Found the following PWM controls:
>    hwmon2/device/pwm1
>    hwmon2/device/pwm2
>    hwmon2/device/pwm3
> There are no usable PWM outputs.

Hmm, you are root, aren't you?

> nelis@nelis-desktop:~$ grep -H . /sys/class/hwmon/hwmon*/device/pwm*
> /sys/class/hwmon/hwmon2/device/pwm1:81
> /sys/class/hwmon/hwmon2/device/pwm1_auto_channels_temp:1
> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_pwm:90
> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp:60000
> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp_hyst:56000
> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_pwm:80
> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp:35000
> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp_hyst:31000
> /sys/class/hwmon/hwmon2/device/pwm1_enable:2
> /sys/class/hwmon/hwmon2/device/pwm1_interpolate:1
> /sys/class/hwmon/hwmon2/device/pwm2:255
> /sys/class/hwmon/hwmon2/device/pwm2_auto_channels_temp:2
> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_pwm:217
> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp:60000
> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp_hyst:56000
> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_pwm:128
> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp:30000
> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp_hyst:26000
> /sys/class/hwmon/hwmon2/device/pwm2_enable:2
> /sys/class/hwmon/hwmon2/device/pwm2_interpolate:1
> /sys/class/hwmon/hwmon2/device/pwm3:155
> /sys/class/hwmon/hwmon2/device/pwm3_auto_channels_temp:4
> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_pwm:217
> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp:60000
> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp_hyst:58000
> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_pwm:128
> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp:30000
> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp_hyst:28000
> /sys/class/hwmon/hwmon2/device/pwm3_enable:2
> /sys/class/hwmon/hwmon2/device/pwm3_interpolate:1

Note that all 3 fan controllers are in automatic mode (pwm#_enable >
1), which is less CPU-intensive than manual mode and usually gives
better results. So you might now want to use pwmconfig and fancontrol
anyway, but rather tweak the automatic mode settings by writing to the
pwm#_auto_point# files above.

I admit the current configuration is a little odd. Usually point2 has
pwm and temperature values above point1, not below. I am not familiar
with the Fintek F71862FG and its driver though. Hans?

-- 
Jean Delvare
http://khali.linux-fr.org/wishlist.html

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (2 preceding siblings ...)
  2009-07-03 14:27 ` Jean Delvare
@ 2009-07-03 14:35 ` Hans de Goede
  2009-07-03 14:54 ` Jean Delvare
                   ` (6 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Hans de Goede @ 2009-07-03 14:35 UTC (permalink / raw)
  To: lm-sensors

Hi,

On 07/03/2009 04:27 PM, Jean Delvare wrote:
> Hi Niels,
>

<snip>

>> nelis@nelis-desktop:~$ grep -H . /sys/class/hwmon/hwmon*/device/pwm*
>> /sys/class/hwmon/hwmon2/device/pwm1:81
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_channels_temp:1
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_pwm:90
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp:60000
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp_hyst:56000
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_pwm:80
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp:35000
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp_hyst:31000
>> /sys/class/hwmon/hwmon2/device/pwm1_enable:2
>> /sys/class/hwmon/hwmon2/device/pwm1_interpolate:1
>> /sys/class/hwmon/hwmon2/device/pwm2:255
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_channels_temp:2
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_pwm:217
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp:60000
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp_hyst:56000
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_pwm:128
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp:30000
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp_hyst:26000
>> /sys/class/hwmon/hwmon2/device/pwm2_enable:2
>> /sys/class/hwmon/hwmon2/device/pwm2_interpolate:1
>> /sys/class/hwmon/hwmon2/device/pwm3:155
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_channels_temp:4
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_pwm:217
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp:60000
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp_hyst:58000
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_pwm:128
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp:30000
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp_hyst:28000
>> /sys/class/hwmon/hwmon2/device/pwm3_enable:2
>> /sys/class/hwmon/hwmon2/device/pwm3_interpolate:1
>
> Note that all 3 fan controllers are in automatic mode (pwm#_enable>
> 1), which is less CPU-intensive than manual mode and usually gives
> better results. So you might now want to use pwmconfig and fancontrol
> anyway, but rather tweak the automatic mode settings by writing to the
> pwm#_auto_point# files above.
>
> I admit the current configuration is a little odd. Usually point2 has
> pwm and temperature values above point1, not below. I am not familiar
> with the Fintek F71862FG and its driver though. Hans?
>

Yes, erm well the F718xx family has them in reverse order in hardware and
I kept the hardware order for sysfs files. A bit strange I must admit.

In hindsight it might have been better to reverse the order in sysfs
for consistency with other drivers.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (3 preceding siblings ...)
  2009-07-03 14:35 ` Hans de Goede
@ 2009-07-03 14:54 ` Jean Delvare
  2009-07-03 16:24 ` Niels
                   ` (5 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Jean Delvare @ 2009-07-03 14:54 UTC (permalink / raw)
  To: lm-sensors

On Fri, 03 Jul 2009 16:35:57 +0200, Hans de Goede wrote:
> On 07/03/2009 04:27 PM, Jean Delvare wrote:
> > I admit the current configuration is a little odd. Usually point2 has
> > pwm and temperature values above point1, not below. I am not familiar
> > with the Fintek F71862FG and its driver though. Hans?
> 
> Yes, erm well the F718xx family has them in reverse order in hardware and
> I kept the hardware order for sysfs files. A bit strange I must admit.
> 
> In hindsight it might have been better to reverse the order in sysfs
> for consistency with other drivers.

I agree. It shouldn't be too difficult, and even though we can't easily
get a fully consistent interface for automatic speed mode due to each
chip being different in its own creative way, being as consistent as we
can makes things easier for the users.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (4 preceding siblings ...)
  2009-07-03 14:54 ` Jean Delvare
@ 2009-07-03 16:24 ` Niels
  2009-07-03 16:35 ` Jean Delvare
                   ` (4 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Niels @ 2009-07-03 16:24 UTC (permalink / raw)
  To: lm-sensors

Jean Delvare wrote:
> Hi Niels,
>
> On Fri, 03 Jul 2009 15:54:29 +0200, Niels wrote:
>   
>> Jean Delvare wrote:
>>     
>>> Which version of lm-sensors (or pwmconfig) is this?
>>>
>>> I would like to see the full output of pwmconfig and not just the above
>>> summary.
>>>       
>> nelis@nelis-desktop:~$ sensors -v
>> sensors version 3.1.1+SVN with libsensors version 3.1.1+SVN
>>
>>
>> nelis@nelis-desktop:~$ pwmconfig
>> # pwmconfig revision 5630 (2009-01-29)
>> This program will search your sensors for pulse width modulation (pwm)
>> controls, and test each one to see if it controls a fan on
>> your motherboard. Note that many motherboards do not have pwm
>> circuitry installed, even if your sensor chip supports pwm.
>>
>> We will attempt to briefly stop each fan using the pwm controls.
>> The program will attempt to restore each fan to full speed
>> after testing. However, it is ** very important ** that you
>> physically verify that the fans have been to full speed
>> after the program has completed.
>>
>> Found the following devices:
>>    hwmon0 is acpitz
>>    hwmon1/device is k8temp
>>    hwmon2/device is f71862fg
>>
>> Found the following PWM controls:
>>    hwmon2/device/pwm1
>>    hwmon2/device/pwm2
>>    hwmon2/device/pwm3
>> There are no usable PWM outputs.
>>     
>
> Hmm, you are root, aren't you?
>
>   
nelis@nelis-desktop:/$ sudo pwmconfig
# pwmconfig revision 5630 (2009-01-29)
This program will search your sensors for pulse width modulation (pwm)
controls, and test each one to see if it controls a fan on
your motherboard. Note that many motherboards do not have pwm
circuitry installed, even if your sensor chip supports pwm.

We will attempt to briefly stop each fan using the pwm controls.
The program will attempt to restore each fan to full speed
after testing. However, it is ** very important ** that you
physically verify that the fans have been to full speed
after the program has completed.

Found the following devices:
   hwmon0 is acpitz
   hwmon1/device is k8temp
   hwmon2/device is f71862fg

Found the following PWM controls:
   hwmon2/device/pwm1
hwmon2/device/pwm1 is currently setup for automatic speed control.
In general, automatic mode is preferred over manual mode, as
it is more efficient and it reacts faster. Are you sure that
you want to setup this output for manual control? (n)
   hwmon2/device/pwm2
hwmon2/device/pwm2 is currently setup for automatic speed control.
In general, automatic mode is preferred over manual mode, as
it is more efficient and it reacts faster. Are you sure that
you want to setup this output for manual control? (n)
   hwmon2/device/pwm3
hwmon2/device/pwm3 is currently setup for automatic speed control.
In general, automatic mode is preferred over manual mode, as
it is more efficient and it reacts faster. Are you sure that
you want to setup this output for manual control? (n)
There are no usable PWM outputs.


>> nelis@nelis-desktop:~$ grep -H . /sys/class/hwmon/hwmon*/device/pwm*
>> /sys/class/hwmon/hwmon2/device/pwm1:81
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_channels_temp:1
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_pwm:90
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp:60000
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point1_temp_hyst:56000
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_pwm:80
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp:35000
>> /sys/class/hwmon/hwmon2/device/pwm1_auto_point2_temp_hyst:31000
>> /sys/class/hwmon/hwmon2/device/pwm1_enable:2
>> /sys/class/hwmon/hwmon2/device/pwm1_interpolate:1
>> /sys/class/hwmon/hwmon2/device/pwm2:255
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_channels_temp:2
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_pwm:217
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp:60000
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point1_temp_hyst:56000
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_pwm:128
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp:30000
>> /sys/class/hwmon/hwmon2/device/pwm2_auto_point2_temp_hyst:26000
>> /sys/class/hwmon/hwmon2/device/pwm2_enable:2
>> /sys/class/hwmon/hwmon2/device/pwm2_interpolate:1
>> /sys/class/hwmon/hwmon2/device/pwm3:155
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_channels_temp:4
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_pwm:217
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp:60000
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point1_temp_hyst:58000
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_pwm:128
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp:30000
>> /sys/class/hwmon/hwmon2/device/pwm3_auto_point2_temp_hyst:28000
>> /sys/class/hwmon/hwmon2/device/pwm3_enable:2
>> /sys/class/hwmon/hwmon2/device/pwm3_interpolate:1
>>     
>
> Note that all 3 fan controllers are in automatic mode (pwm#_enable >
> 1), which is less CPU-intensive than manual mode and usually gives
> better results. So you might now want to use pwmconfig and fancontrol
> anyway, but rather tweak the automatic mode settings by writing to the
> pwm#_auto_point# files above.
>
> I admit the current configuration is a little odd. Usually point2 has
> pwm and temperature values above point1, not below. I am not familiar
> with the Fintek F71862FG and its driver though. Hans?
>
>   
I am unable to write to the files.

nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "0" > 
pwm1_enable
-bash: pwm1_enable: Permission denied

So i guess temp3 is cpu temp and temp1 is motherboard temp.
But can't change that either.

nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "3" > 
pwm1_auto_channels_temp
-bash: pwm1_auto_channels_temp: Permission denied








_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (5 preceding siblings ...)
  2009-07-03 16:24 ` Niels
@ 2009-07-03 16:35 ` Jean Delvare
  2009-07-03 17:05 ` Niels
                   ` (3 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Jean Delvare @ 2009-07-03 16:35 UTC (permalink / raw)
  To: lm-sensors

On Fri, 03 Jul 2009 18:24:38 +0200, Niels wrote:
> Jean Delvare wrote:
> >> There are no usable PWM outputs.
> >
> > Hmm, you are root, aren't you?
>
> nelis@nelis-desktop:/$ sudo pwmconfig
> # pwmconfig revision 5630 (2009-01-29)
> This program will search your sensors for pulse width modulation (pwm)
> controls, and test each one to see if it controls a fan on
> your motherboard. Note that many motherboards do not have pwm
> circuitry installed, even if your sensor chip supports pwm.
> 
> We will attempt to briefly stop each fan using the pwm controls.
> The program will attempt to restore each fan to full speed
> after testing. However, it is ** very important ** that you
> physically verify that the fans have been to full speed
> after the program has completed.
> 
> Found the following devices:
>    hwmon0 is acpitz
>    hwmon1/device is k8temp
>    hwmon2/device is f71862fg
> 
> Found the following PWM controls:
>    hwmon2/device/pwm1
> hwmon2/device/pwm1 is currently setup for automatic speed control.
> In general, automatic mode is preferred over manual mode, as
> it is more efficient and it reacts faster. Are you sure that
> you want to setup this output for manual control? (n)
>    hwmon2/device/pwm2
> hwmon2/device/pwm2 is currently setup for automatic speed control.
> In general, automatic mode is preferred over manual mode, as
> it is more efficient and it reacts faster. Are you sure that
> you want to setup this output for manual control? (n)
>    hwmon2/device/pwm3
> hwmon2/device/pwm3 is currently setup for automatic speed control.
> In general, automatic mode is preferred over manual mode, as
> it is more efficient and it reacts faster. Are you sure that
> you want to setup this output for manual control? (n)
> There are no usable PWM outputs.

OK, I'll change pwmconfig to complain if run as non-root.

> > (...)
> > Note that all 3 fan controllers are in automatic mode (pwm#_enable >
> > 1), which is less CPU-intensive than manual mode and usually gives
> > better results. So you might now want to use pwmconfig and fancontrol
> > anyway, but rather tweak the automatic mode settings by writing to the
> > pwm#_auto_point# files above.
> >
> > I admit the current configuration is a little odd. Usually point2 has
> > pwm and temperature values above point1, not below. I am not familiar
> > with the Fintek F71862FG and its driver though. Hans?
>
> I am unable to write to the files.
> 
> nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "0" > 
> pwm1_enable
> -bash: pwm1_enable: Permission denied

Never mix sudo and shell redirection, it doesn't work. Redirection
"happens first" so you try to write as non-root, and this isn't allowed.

> So i guess temp3 is cpu temp and temp1 is motherboard temp.

Or the other way around, it's hard to tell. Maybe looking at what the
BIOS displays will provide valuable hints. I certainly hope temp2 isn't
real...

> But can't change that either.
> 
> nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "3" > 
> pwm1_auto_channels_temp
> -bash: pwm1_auto_channels_temp: Permission denied

Same problem as above. Use su instead of sudo. Or maybe sudo sh -c ...

-- 
Jean Delvare
http://khali.linux-fr.org/wishlist.html

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (6 preceding siblings ...)
  2009-07-03 16:35 ` Jean Delvare
@ 2009-07-03 17:05 ` Niels
  2009-07-03 17:25 ` Hans de Goede
                   ` (2 subsequent siblings)
  10 siblings, 0 replies; 12+ messages in thread
From: Niels @ 2009-07-03 17:05 UTC (permalink / raw)
  To: lm-sensors

Jean Delvare wrote:
> On Fri, 03 Jul 2009 18:24:38 +0200, Niels wrote:
>   
>> Jean Delvare wrote:
>>     
>>>> There are no usable PWM outputs.
>>>>         
>>> Hmm, you are root, aren't you?
>>>       
>> nelis@nelis-desktop:/$ sudo pwmconfig
>> # pwmconfig revision 5630 (2009-01-29)
>> This program will search your sensors for pulse width modulation (pwm)
>> controls, and test each one to see if it controls a fan on
>> your motherboard. Note that many motherboards do not have pwm
>> circuitry installed, even if your sensor chip supports pwm.
>>
>> We will attempt to briefly stop each fan using the pwm controls.
>> The program will attempt to restore each fan to full speed
>> after testing. However, it is ** very important ** that you
>> physically verify that the fans have been to full speed
>> after the program has completed.
>>
>> Found the following devices:
>>    hwmon0 is acpitz
>>    hwmon1/device is k8temp
>>    hwmon2/device is f71862fg
>>
>> Found the following PWM controls:
>>    hwmon2/device/pwm1
>> hwmon2/device/pwm1 is currently setup for automatic speed control.
>> In general, automatic mode is preferred over manual mode, as
>> it is more efficient and it reacts faster. Are you sure that
>> you want to setup this output for manual control? (n)
>>    hwmon2/device/pwm2
>> hwmon2/device/pwm2 is currently setup for automatic speed control.
>> In general, automatic mode is preferred over manual mode, as
>> it is more efficient and it reacts faster. Are you sure that
>> you want to setup this output for manual control? (n)
>>    hwmon2/device/pwm3
>> hwmon2/device/pwm3 is currently setup for automatic speed control.
>> In general, automatic mode is preferred over manual mode, as
>> it is more efficient and it reacts faster. Are you sure that
>> you want to setup this output for manual control? (n)
>> There are no usable PWM outputs.
>>     
>
> OK, I'll change pwmconfig to complain if run as non-root.
>
>   
>>> (...)
>>> Note that all 3 fan controllers are in automatic mode (pwm#_enable >
>>> 1), which is less CPU-intensive than manual mode and usually gives
>>> better results. So you might now want to use pwmconfig and fancontrol
>>> anyway, but rather tweak the automatic mode settings by writing to the
>>> pwm#_auto_point# files above.
>>>
>>> I admit the current configuration is a little odd. Usually point2 has
>>> pwm and temperature values above point1, not below. I am not familiar
>>> with the Fintek F71862FG and its driver though. Hans?
>>>       
>> I am unable to write to the files.
>>
>> nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "0" > 
>> pwm1_enable
>> -bash: pwm1_enable: Permission denied
>>     
>
> Never mix sudo and shell redirection, it doesn't work. Redirection
> "happens first" so you try to write as non-root, and this isn't allowed.
>
>   
>> So i guess temp3 is cpu temp and temp1 is motherboard temp.
>>     
>
> Or the other way around, it's hard to tell. Maybe looking at what the
> BIOS displays will provide valuable hints. I certainly hope temp2 isn't
> real...
>
>   
>> But can't change that either.
>>
>> nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "3" > 
>> pwm1_auto_channels_temp
>> -bash: pwm1_auto_channels_temp: Permission denied
>>     
>
> Same problem as above. Use su instead of sudo. Or maybe sudo sh -c ...
>
>   
root@nelis-desktop:/sys/class/hwmon/hwmon2/device# echo "0" > pwm1_enable
bash: echo: write error: Invalid argument
root@nelis-desktop:/sys/class/hwmon/hwmon2/device# echo "3" > 
pwm1_auto_channels_temp
bash: echo: write error: Invalid argument

Trading permission for invalid arguments. Sounds like politics.

Thanks again for helping me out.


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (7 preceding siblings ...)
  2009-07-03 17:05 ` Niels
@ 2009-07-03 17:25 ` Hans de Goede
  2009-07-03 17:25 ` Hans de Goede
  2009-07-03 19:09 ` Jean Delvare
  10 siblings, 0 replies; 12+ messages in thread
From: Hans de Goede @ 2009-07-03 17:25 UTC (permalink / raw)
  To: lm-sensors



On 07/03/2009 07:05 PM, Niels wrote:
> Jean Delvare wrote:
>> On Fri, 03 Jul 2009 18:24:38 +0200, Niels wrote:
>>> Jean Delvare wrote:
>>>>> There are no usable PWM outputs.
>>>> Hmm, you are root, aren't you?
>>> nelis@nelis-desktop:/$ sudo pwmconfig
>>> # pwmconfig revision 5630 (2009-01-29)
>>> This program will search your sensors for pulse width modulation (pwm)
>>> controls, and test each one to see if it controls a fan on
>>> your motherboard. Note that many motherboards do not have pwm
>>> circuitry installed, even if your sensor chip supports pwm.
>>>
>>> We will attempt to briefly stop each fan using the pwm controls.
>>> The program will attempt to restore each fan to full speed
>>> after testing. However, it is ** very important ** that you
>>> physically verify that the fans have been to full speed
>>> after the program has completed.
>>>
>>> Found the following devices:
>>> hwmon0 is acpitz
>>> hwmon1/device is k8temp
>>> hwmon2/device is f71862fg
>>>
>>> Found the following PWM controls:
>>> hwmon2/device/pwm1
>>> hwmon2/device/pwm1 is currently setup for automatic speed control.
>>> In general, automatic mode is preferred over manual mode, as
>>> it is more efficient and it reacts faster. Are you sure that
>>> you want to setup this output for manual control? (n)
>>> hwmon2/device/pwm2
>>> hwmon2/device/pwm2 is currently setup for automatic speed control.
>>> In general, automatic mode is preferred over manual mode, as
>>> it is more efficient and it reacts faster. Are you sure that
>>> you want to setup this output for manual control? (n)
>>> hwmon2/device/pwm3
>>> hwmon2/device/pwm3 is currently setup for automatic speed control.
>>> In general, automatic mode is preferred over manual mode, as
>>> it is more efficient and it reacts faster. Are you sure that
>>> you want to setup this output for manual control? (n)
>>> There are no usable PWM outputs.
>>
>> OK, I'll change pwmconfig to complain if run as non-root.
>>
>>>> (...)
>>>> Note that all 3 fan controllers are in automatic mode (pwm#_enable >
>>>> 1), which is less CPU-intensive than manual mode and usually gives
>>>> better results. So you might now want to use pwmconfig and fancontrol
>>>> anyway, but rather tweak the automatic mode settings by writing to the
>>>> pwm#_auto_point# files above.
>>>>
>>>> I admit the current configuration is a little odd. Usually point2 has
>>>> pwm and temperature values above point1, not below. I am not familiar
>>>> with the Fintek F71862FG and its driver though. Hans?
>>> I am unable to write to the files.
>>>
>>> nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "0" >
>>> pwm1_enable
>>> -bash: pwm1_enable: Permission denied
>>
>> Never mix sudo and shell redirection, it doesn't work. Redirection
>> "happens first" so you try to write as non-root, and this isn't allowed.
>>
>>> So i guess temp3 is cpu temp and temp1 is motherboard temp.
>>
>> Or the other way around, it's hard to tell. Maybe looking at what the
>> BIOS displays will provide valuable hints. I certainly hope temp2 isn't
>> real...
>>
>>> But can't change that either.
>>>
>>> nelis@nelis-desktop:/sys/class/hwmon/hwmon2/device$ sudo echo "3" >
>>> pwm1_auto_channels_temp
>>> -bash: pwm1_auto_channels_temp: Permission denied
>>
>> Same problem as above. Use su instead of sudo. Or maybe sudo sh -c ...
>>
> root@nelis-desktop:/sys/class/hwmon/hwmon2/device# echo "0" > pwm1_enable
> bash: echo: write error: Invalid argument

Take a look at Documents/hwmon/f71882fg for which values are allowed,
with your chip only 1 (manual mode) and 2 (auto mode) are supported,
0 = pwm disabled (fans full speed) is not supported.

> root@nelis-desktop:/sys/class/hwmon/hwmon2/device# echo "3" >
> pwm1_auto_channels_temp
> bash: echo: write error: Invalid argument
>

The pwm#_auto_channels_temp attributes are a bitmap, you are now asking
for both temp1 and temp2 to influence pwm1, the chip cannot handle this,
you need to choose one.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (8 preceding siblings ...)
  2009-07-03 17:25 ` Hans de Goede
@ 2009-07-03 17:25 ` Hans de Goede
  2009-07-03 19:09 ` Jean Delvare
  10 siblings, 0 replies; 12+ messages in thread
From: Hans de Goede @ 2009-07-03 17:25 UTC (permalink / raw)
  To: lm-sensors

Hi,

On 07/03/2009 04:54 PM, Jean Delvare wrote:
> On Fri, 03 Jul 2009 16:35:57 +0200, Hans de Goede wrote:
>> On 07/03/2009 04:27 PM, Jean Delvare wrote:
>>> I admit the current configuration is a little odd. Usually point2 has
>>> pwm and temperature values above point1, not below. I am not familiar
>>> with the Fintek F71862FG and its driver though. Hans?
>> Yes, erm well the F718xx family has them in reverse order in hardware and
>> I kept the hardware order for sysfs files. A bit strange I must admit.
>>
>> In hindsight it might have been better to reverse the order in sysfs
>> for consistency with other drivers.
>
> I agree. It shouldn't be too difficult, and even though we can't easily
> get a fully consistent interface for automatic speed mode due to each
> chip being different in its own creative way, being as consistent as we
> can makes things easier for the users.
>

Yes, but do we want to change this now, after the fact, that would
basically come down to ABI breakage.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [lm-sensors] no PWM output with pwmconfig
  2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
                   ` (9 preceding siblings ...)
  2009-07-03 17:25 ` Hans de Goede
@ 2009-07-03 19:09 ` Jean Delvare
  10 siblings, 0 replies; 12+ messages in thread
From: Jean Delvare @ 2009-07-03 19:09 UTC (permalink / raw)
  To: lm-sensors

On Fri, 03 Jul 2009 19:25:49 +0200, Hans de Goede wrote:
> Hi,
> 
> On 07/03/2009 04:54 PM, Jean Delvare wrote:
> > On Fri, 03 Jul 2009 16:35:57 +0200, Hans de Goede wrote:
> >> Yes, erm well the F718xx family has them in reverse order in hardware and
> >> I kept the hardware order for sysfs files. A bit strange I must admit.
> >>
> >> In hindsight it might have been better to reverse the order in sysfs
> >> for consistency with other drivers.
> >
> > I agree. It shouldn't be too difficult, and even though we can't easily
> > get a fully consistent interface for automatic speed mode due to each
> > chip being different in its own creative way, being as consistent as we
> > can makes things easier for the users.
> 
> Yes, but do we want to change this now, after the fact, that would
> basically come down to ABI breakage.

You can see it that way for sure. Or you can see it as fixing an
interface which was improperly implemented originally. While our
documentation doesn't explicitly say how trip points are ordered, the
"incremental" approach is the most natural one and the one implemented by
all other drivers too.

I don't care too much myself, so it's really up to you. You may also
want to contribute a patch to the documentation to make things clearer.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2009-07-03 19:09 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-01 17:22 [lm-sensors] no PWM output with pwmconfig Niels
2009-07-03  7:46 ` Jean Delvare
2009-07-03 13:54 ` Niels
2009-07-03 14:27 ` Jean Delvare
2009-07-03 14:35 ` Hans de Goede
2009-07-03 14:54 ` Jean Delvare
2009-07-03 16:24 ` Niels
2009-07-03 16:35 ` Jean Delvare
2009-07-03 17:05 ` Niels
2009-07-03 17:25 ` Hans de Goede
2009-07-03 17:25 ` Hans de Goede
2009-07-03 19:09 ` Jean Delvare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.