From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org, aliguori@us.ibm.com,
kwolf@redhat.com, glommer@redhat.com
Subject: Re: [PATCHv4 4/5] qemu/msi: missing braces
Date: Sun, 05 Jul 2009 15:07:06 +0300 [thread overview]
Message-ID: <4A50976A.8040901@redhat.com> (raw)
In-Reply-To: <20090705115601.GA4826@redhat.com>
On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote:
>> With the braces comment I meant that while working on the code, you
>> should update it to match CODING_STYLE:
>> if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) {
>> return;
>> }
>>
>
> Yea ... it's probably better to do this all over the file, not piecewise,
> though. No?
>
No, that just causes churn (and merge conflicts for me). Better to only
fix if you have a patch that modifies the same place.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org,
glommer@redhat.com, qemu-devel@nongnu.org,
Blue Swirl <blauwirbel@gmail.com>
Subject: [Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces
Date: Sun, 05 Jul 2009 15:07:06 +0300 [thread overview]
Message-ID: <4A50976A.8040901@redhat.com> (raw)
In-Reply-To: <20090705115601.GA4826@redhat.com>
On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote:
>> With the braces comment I meant that while working on the code, you
>> should update it to match CODING_STYLE:
>> if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) {
>> return;
>> }
>>
>
> Yea ... it's probably better to do this all over the file, not piecewise,
> though. No?
>
No, that just causes churn (and merge conflicts for me). Better to only
fix if you have a patch that modifies the same place.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-07-05 12:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1246793893.git.mst@redhat.com>
2009-07-05 11:40 ` [PATCHv4 1/5] qemu/msi: fix segfault in msix_save Michael S. Tsirkin
2009-07-05 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 11:40 ` [PATCHv4 2/5] qemu/virtio: remove control vector save Michael S. Tsirkin
2009-07-05 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 11:40 ` [PATCHv4 3/5] qemu/msi: clean used vectors state on load Michael S. Tsirkin
2009-07-05 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 11:40 ` [PATCHv4 4/5] qemu/msi: missing braces Michael S. Tsirkin
2009-07-05 11:40 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 11:48 ` Blue Swirl
2009-07-05 11:48 ` [Qemu-devel] " Blue Swirl
2009-07-05 11:56 ` Michael S. Tsirkin
2009-07-05 11:56 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 12:03 ` Blue Swirl
2009-07-05 12:03 ` [Qemu-devel] " Blue Swirl
2009-07-05 12:07 ` Avi Kivity [this message]
2009-07-05 12:07 ` Avi Kivity
2009-07-05 13:18 ` Michael S. Tsirkin
2009-07-05 13:18 ` [Qemu-devel] " Michael S. Tsirkin
2009-07-05 11:41 ` [PATCHv4 5/5] qemu/virtio: mark msi vectors used on load Michael S. Tsirkin
2009-07-05 11:41 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A50976A.8040901@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.