From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Wei Yongjun <yjwei@cn.fujitsu.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCHv2] sctp: fix warning at inet_sock_destruct() while release
Date: Mon, 06 Jul 2009 13:45:01 +0000 [thread overview]
Message-ID: <4A51FFDD.30108@hp.com> (raw)
In-Reply-To: <20090706064957.GA16971@gondor.apana.org.au>
Herbert Xu wrote:
> On Mon, Jul 06, 2009 at 01:45:48PM +0800, Wei Yongjun wrote:
>> Commit 'net: Move rx skb_orphan call to where needed' broken sctp protocol
>> with warning at inet_sock_destruct(). Actually, sctp can do this right with
>> sctp_sock_rfree_frag() and sctp_skb_set_owner_r_frag() pair.
>>
>> sctp_sock_rfree_frag(skb);
>> sctp_skb_set_owner_r_frag(skb, newsk);
>>
>> This patch not revert the commit d55d87fdff8252d0e2f7c28c2d443aee17e9d70f,
>> instead remove the sctp_sock_rfree_frag() function.
>
> It took me a while to understand your patch but yeah it does seem
> to be the right fix. So essentially we were freeing the packet
> twice as my newly added skb_orphan in sctp_skb_set_owner_r is
> repeating what sctp_sock_rfree_frag has already done for the
> migration case.
>
> While your patch simply eliminates sctp_sock_rfree_frag so that
> we only free things once.
>
Yep, I agree.
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>
> Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Wei Yongjun <yjwei@cn.fujitsu.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCHv2] sctp: fix warning at inet_sock_destruct() while release sctp socket
Date: Mon, 06 Jul 2009 09:45:01 -0400 [thread overview]
Message-ID: <4A51FFDD.30108@hp.com> (raw)
In-Reply-To: <20090706064957.GA16971@gondor.apana.org.au>
Herbert Xu wrote:
> On Mon, Jul 06, 2009 at 01:45:48PM +0800, Wei Yongjun wrote:
>> Commit 'net: Move rx skb_orphan call to where needed' broken sctp protocol
>> with warning at inet_sock_destruct(). Actually, sctp can do this right with
>> sctp_sock_rfree_frag() and sctp_skb_set_owner_r_frag() pair.
>>
>> sctp_sock_rfree_frag(skb);
>> sctp_skb_set_owner_r_frag(skb, newsk);
>>
>> This patch not revert the commit d55d87fdff8252d0e2f7c28c2d443aee17e9d70f,
>> instead remove the sctp_sock_rfree_frag() function.
>
> It took me a while to understand your patch but yeah it does seem
> to be the right fix. So essentially we were freeing the packet
> twice as my newly added skb_orphan in sctp_skb_set_owner_r is
> repeating what sctp_sock_rfree_frag has already done for the
> migration case.
>
> While your patch simply eliminates sctp_sock_rfree_frag so that
> we only free things once.
>
Yep, I agree.
>> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Vlad Yasevich <vladislav.yasevich@hp.com>
>
> Thanks,
next prev parent reply other threads:[~2009-07-06 13:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 5:42 [PATCH] sctp: fix warning at inet_sock_destruct() while release sctp Wei Yongjun
2009-07-06 5:42 ` [PATCH] sctp: fix warning at inet_sock_destruct() while release sctp socket Wei Yongjun
2009-07-06 5:45 ` [PATCHv2] sctp: fix warning at inet_sock_destruct() while release Wei Yongjun
2009-07-06 5:45 ` [PATCHv2] sctp: fix warning at inet_sock_destruct() while release sctp socket Wei Yongjun
2009-07-06 6:49 ` [PATCHv2] sctp: fix warning at inet_sock_destruct() while Herbert Xu
2009-07-06 6:49 ` [PATCHv2] sctp: fix warning at inet_sock_destruct() while release sctp socket Herbert Xu
2009-07-06 13:45 ` Vlad Yasevich [this message]
2009-07-06 13:45 ` Vlad Yasevich
2009-07-06 20:08 ` [PATCHv2] sctp: fix warning at inet_sock_destruct() while David Miller
2009-07-06 20:08 ` [PATCHv2] sctp: fix warning at inet_sock_destruct() while release sctp socket David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A51FFDD.30108@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.