Re: [lm-sensors] Test of k8temp

Re: [lm-sensors] Test of k8temp

[Rudolf Marek]

Hi again,


 >Anyway, In the patch, replace :

 >+       /* Some AMD 10H cpus reports Inaccurate Temperature Measurement */
 >+       if ((temp < 21000) || (temp > 90000))

 >+       /* Some AMD 10H cpus reports Inaccurate Temperature Measurement */
 >+       if ((temp < 10000) || (temp > 90000))

So, now you see that workaround on some arbitrary temperature simply does not 
make sense.

Please don't add  support for fam10h CPUs. This is not a point of HW monitoring, 
to rule out  arbitrary temperatures.

I'm perfectly fine if you come up with a patch for fam 11h because the Errata 
seems to have vanished...

Rudolf

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Test of k8temp

[Jaswinder Singh Rajput]

Hello Rudolf,

On Mon, 2009-07-06 at 16:16 +0200, Rudolf Marek wrote:
> Hi again,
> 
> 
>  >Anyway, In the patch, replace :
> 
>  >+       /* Some AMD 10H cpus reports Inaccurate Temperature Measurement */
>  >+       if ((temp < 21000) || (temp > 90000))
> 
>  >+       /* Some AMD 10H cpus reports Inaccurate Temperature Measurement */
>  >+       if ((temp < 10000) || (temp > 90000))
> 
> So, now you see that workaround on some arbitrary temperature simply does not 
> make sense.
> 
> Please don't add  support for fam10h CPUs. This is not a point of HW monitoring, 
> to rule out  arbitrary temperatures.
> 

I totally agree with you that's why I removed the support for 10h as per
your suggestion.

> I'm perfectly fine if you come up with a patch for fam 11h because the Errata 
> seems to have vanished...
> 

x86: hwmon/k8temp.c Add support for AMD 11H

http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h18e6a08d340d853459a39b4104eab0334568427

is still waiting for your approval.

Thanks,
--
JSR


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] Test of k8temp

[Rudolf Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

It seems mine emails are arriving multiple times. I'm sorry about that. Axel, is
it doing mine ISP?


> I totally agree with you that's why I removed the support for 10h as per
> your suggestion.


Ok fine.

> 
>> I'm perfectly fine if you come up with a patch for fam 11h because the Errata 
> is still waiting for your approval.

Aha sorry I forgot about this one. Please can you re-structure it so there are
not a goto's I think kernel codingstyle allows them only for error paths.

Thanks,

Rudolf
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpSKdAACgkQ3J9wPJqZRNXepwCfYtwYNNUx5DDmQrh4tavtCoy5
JmwAoLIm4L0L3cunKR44eVbaIuPKeQKL
=pOcu
-----END PGP SIGNATURE-----

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors