Re: [PATCH] fuse: allow umask processing in userspace

["Jean-Pierre André" <jean-pierre.andre@wanadoo.fr>]

Hi Miklos,

Miklos Szeredi wrote:
> On Sat, 04 Jul 2009, Jean-Pierre André wrote:
>   
>> I went through the patches and the tests, and I can
>> announce that ntfs-3g is the first fuse-based file system
>> which passes the PJD Posix test fully, including the
>> Posix ACL parts.
>>     
>
> Thanks for testing.
>
>   
[...]
>> There is just a point which worries me : I cannot understand
>> how your client patch deactivates the old code which was
>> applying the umask. I would prefer not to discover it the
>> hard way...
>>     
>
> The
>
> 	sb->s_flags |= MS_POSIXACL;
>
> line tells the VFS that it should leave umask applying to the
> filesystem.  The flag is misnamed, it really should be "MS_NOMASK" or
> something.
>   

So there it was, relying on a safe condition...

Thanks so much.

Jean-Pierre

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html