All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 00/23] Add KVM support for PPC64 (970) hosts
Date: Tue, 07 Jul 2009 16:08:16 +0000	[thread overview]
Message-ID: <4A5372F0.7040800@redhat.com> (raw)
In-Reply-To: <1246976262-4826-1-git-send-email-agraf@suse.de>

On 07/07/2009 06:56 PM, Alexander Graf wrote:
>> From a quick review (not that I'm qualified to review ppc code) this 
>> looks very good.
>
>
> Wow - thanks :-).

Well, I only reviewed the code that I understood, which was the 
whitespace.  Apparently that part is a well-formed program (see 
http://compsoc.dur.ac.uk/whitespace/).

>
> Or is using mmu_notifiers mandatory? :-). 

It's highly recommended.

> I also found some mmu_notifiers parts in generic kvm code. Does that 
> mean it gets handled by that already?

You just need to implement a hook that drops a gfn from your shadow page 
tables and tlbs.  It should be fairly small.

-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2009-07-07 16:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-07 14:17 [PATCH 00/23] Add KVM support for PPC64 (970) hosts Alexander Graf
2009-07-07 15:44 ` Arnd Bergmann
2009-07-07 15:49 ` Alexander Graf
2009-07-07 15:54 ` Avi Kivity
2009-07-07 15:56 ` Alexander Graf
2009-07-07 16:08 ` Avi Kivity [this message]
2009-07-08  6:17 ` Benjamin Herrenschmidt
2009-07-08  6:22 ` Benjamin Herrenschmidt
2009-07-08  6:42 ` Benjamin Herrenschmidt
2009-07-08  7:35 ` Alexander Graf
2009-07-08  8:01 ` Benjamin Herrenschmidt
2009-07-08  8:06 ` Avi Kivity
2009-07-08  8:19 ` [PATCH 00/23] Add KVM support for PPC64 (970) host Benjamin Herrenschmidt
2009-07-08  8:28 ` [PATCH 00/23] Add KVM support for PPC64 (970) hosts Alexander Graf
2009-07-08  8:43 ` [PATCH 00/23] Add KVM support for PPC64 (970) host Avi Kivity
2009-07-08  9:51 ` Benjamin Herrenschmidt
2009-07-08 10:04 ` Avi Kivity
2009-07-08 10:24 ` Benjamin Herrenschmidt
2009-07-08 11:10 ` [PATCH 00/23] Add KVM support for PPC64 (970) hosts Benjamin Herrenschmidt
2009-07-08 12:29 ` Alexander Graf
2009-07-08 21:40 ` Benjamin Herrenschmidt
2009-07-22 22:58 ` Olof Johansson
2009-07-22 23:02 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5372F0.7040800@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.