All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 4/5] add isolate pages vmstat
Date: Tue, 07 Jul 2009 13:23:48 -0400	[thread overview]
Message-ID: <4A5384A4.7060108@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0907071248560.5124@gentwo.org>

Christoph Lameter wrote:
> On Tue, 7 Jul 2009, KOSAKI Motohiro wrote:
> 
>> +++ b/include/linux/mmzone.h
>> @@ -100,6 +100,8 @@ enum zone_stat_item {
>>  	NR_BOUNCE,
>>  	NR_VMSCAN_WRITE,
>>  	NR_WRITEBACK_TEMP,	/* Writeback using temporary buffers */
>> +	NR_ISOLATED_ANON,	/* Temporary isolated pages from anon lru */
>> +	NR_ISOLATED_FILE,	/* Temporary isolated pages from file lru */
> 
> LRU counters are rarer in use then the counters used for dirty pages etc.
> 
> Could you move the counters for reclaim into a separate cacheline?

I don't get the point of that - these counters are
per-cpu anyway, so why would they need to be in a
separate cacheline?

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Minchan Kim <minchan.kim@gmail.com>,
	Wu Fengguang <fengguang.wu@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Rientjes <rientjes@google.com>
Subject: Re: [PATCH 4/5] add isolate pages vmstat
Date: Tue, 07 Jul 2009 13:23:48 -0400	[thread overview]
Message-ID: <4A5384A4.7060108@redhat.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0907071248560.5124@gentwo.org>

Christoph Lameter wrote:
> On Tue, 7 Jul 2009, KOSAKI Motohiro wrote:
> 
>> +++ b/include/linux/mmzone.h
>> @@ -100,6 +100,8 @@ enum zone_stat_item {
>>  	NR_BOUNCE,
>>  	NR_VMSCAN_WRITE,
>>  	NR_WRITEBACK_TEMP,	/* Writeback using temporary buffers */
>> +	NR_ISOLATED_ANON,	/* Temporary isolated pages from anon lru */
>> +	NR_ISOLATED_FILE,	/* Temporary isolated pages from file lru */
> 
> LRU counters are rarer in use then the counters used for dirty pages etc.
> 
> Could you move the counters for reclaim into a separate cacheline?

I don't get the point of that - these counters are
per-cpu anyway, so why would they need to be in a
separate cacheline?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-07-07 17:24 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-05  9:22 [PATCH 0/5] OOM analysis helper patches KOSAKI Motohiro
2009-07-05  9:22 ` KOSAKI Motohiro
2009-07-05  9:23 ` [PATCH 1/5] add per-zone statistics to show_free_areas() KOSAKI Motohiro
2009-07-05  9:23   ` KOSAKI Motohiro
2009-07-05 11:05   ` Wu Fengguang
2009-07-05 11:05     ` Wu Fengguang
2009-07-05 11:09     ` KOSAKI Motohiro
2009-07-05 11:09       ` KOSAKI Motohiro
2009-07-05 11:14       ` Wu Fengguang
2009-07-05 11:14         ` Wu Fengguang
2009-07-07 16:33   ` Christoph Lameter
2009-07-07 16:33     ` Christoph Lameter
2009-07-05  9:24 ` [PATCH 2/5] add buffer cache information " KOSAKI Motohiro
2009-07-05  9:24   ` KOSAKI Motohiro
2009-07-05 11:21   ` Wu Fengguang
2009-07-05 11:21     ` Wu Fengguang
2009-07-05 11:31     ` KOSAKI Motohiro
2009-07-05 11:31       ` KOSAKI Motohiro
2009-07-05 12:07       ` Wu Fengguang
2009-07-05 12:07         ` Wu Fengguang
2009-07-05 14:16   ` Minchan Kim
2009-07-05 14:16     ` Minchan Kim
2009-07-06  4:24     ` KOSAKI Motohiro
2009-07-06  4:24       ` KOSAKI Motohiro
2009-07-05  9:24 ` [PATCH 3/5] Show kernel stack usage to /proc/meminfo and OOM log KOSAKI Motohiro
2009-07-05  9:24   ` KOSAKI Motohiro
2009-07-07 16:37   ` Christoph Lameter
2009-07-07 16:37     ` Christoph Lameter
2009-07-09  2:13     ` KOSAKI Motohiro
2009-07-09  2:13       ` KOSAKI Motohiro
2009-07-09 21:00       ` Christoph Lameter
2009-07-09 21:00         ` Christoph Lameter
2009-07-05  9:25 ` [PATCH 4/5] add isolate pages vmstat KOSAKI Motohiro
2009-07-05  9:25   ` KOSAKI Motohiro
2009-07-05 12:10   ` Wu Fengguang
2009-07-05 12:10     ` Wu Fengguang
2009-07-05 12:23     ` KOSAKI Motohiro
2009-07-05 12:23       ` KOSAKI Motohiro
2009-07-05 14:51       ` Minchan Kim
2009-07-05 14:51         ` Minchan Kim
2009-07-06  9:28         ` KOSAKI Motohiro
2009-07-06  9:28           ` KOSAKI Motohiro
2009-07-06 11:55           ` KOSAKI Motohiro
2009-07-06 11:55             ` KOSAKI Motohiro
2009-07-07  0:01             ` Minchan Kim
2009-07-07  0:01               ` Minchan Kim
2009-07-07  0:07               ` KOSAKI Motohiro
2009-07-07  0:07                 ` KOSAKI Motohiro
2009-07-07  1:19                 ` KOSAKI Motohiro
2009-07-07  1:19                   ` KOSAKI Motohiro
2009-07-07  1:48                   ` Minchan Kim
2009-07-07  1:48                     ` Minchan Kim
2009-07-07  2:12                     ` KOSAKI Motohiro
2009-07-07  2:12                       ` KOSAKI Motohiro
2009-07-07  2:31                       ` Minchan Kim
2009-07-07  2:31                         ` Minchan Kim
2009-07-07  3:02                     ` Rik van Riel
2009-07-07  3:02                       ` Rik van Riel
2009-07-07 13:51                   ` Wu Fengguang
2009-07-07 13:51                     ` Wu Fengguang
2009-07-07 16:49                   ` Christoph Lameter
2009-07-07 16:49                     ` Christoph Lameter
2009-07-07 17:23                     ` Rik van Riel [this message]
2009-07-07 17:23                       ` Rik van Riel
2009-07-07 23:32                       ` Christoph Lameter
2009-07-07 23:32                         ` Christoph Lameter
2009-07-09  2:19                     ` KOSAKI Motohiro
2009-07-09  2:19                       ` KOSAKI Motohiro
2009-07-09 21:00                       ` Christoph Lameter
2009-07-09 21:00                         ` Christoph Lameter
2009-07-07 16:46   ` Christoph Lameter
2009-07-07 16:46     ` Christoph Lameter
2009-07-08  1:44     ` Wu Fengguang
2009-07-08  1:44       ` Wu Fengguang
2009-07-05  9:26 ` [PATCH 5/5] add NR_ANON_PAGES to OOM log KOSAKI Motohiro
2009-07-05  9:26   ` KOSAKI Motohiro
2009-07-05 12:13   ` Wu Fengguang
2009-07-05 12:13     ` Wu Fengguang
2009-07-05 12:21     ` KOSAKI Motohiro
2009-07-05 12:21       ` KOSAKI Motohiro
2009-07-05 13:02       ` Wu Fengguang
2009-07-05 13:02         ` Wu Fengguang
2009-07-05 13:19         ` KOSAKI Motohiro
2009-07-05 13:19           ` KOSAKI Motohiro
2009-07-05 15:04           ` Minchan Kim
2009-07-05 15:04             ` Minchan Kim
2009-07-05 15:16             ` Wu Fengguang
2009-07-05 15:16               ` Wu Fengguang
2009-07-05 15:27               ` Minchan Kim
2009-07-05 15:27                 ` Minchan Kim
2009-07-07 16:53                 ` Christoph Lameter
2009-07-07 16:53                   ` Christoph Lameter
2009-07-09  5:50                   ` KOSAKI Motohiro
2009-07-09  5:50                     ` KOSAKI Motohiro
2009-07-09  7:20                     ` KOSAKI Motohiro
2009-07-09  7:20                       ` KOSAKI Motohiro
2009-07-09 10:27                       ` Minchan Kim
2009-07-09 10:27                         ` Minchan Kim
2009-07-07  1:22         ` KOSAKI Motohiro
2009-07-07  1:22           ` KOSAKI Motohiro
2009-07-07 10:54           ` Wu Fengguang
2009-07-07 10:54             ` Wu Fengguang
2009-07-07 13:56           ` Wu Fengguang
2009-07-07 13:56             ` Wu Fengguang
2009-07-09  5:13             ` KOSAKI Motohiro
2009-07-09  5:13               ` KOSAKI Motohiro
  -- strict thread matches above, loose matches on Subject: below --
2009-07-09  8:05 [PATCH 0/5] OOM analysis helper patch series v2 KOSAKI Motohiro
2009-07-09  8:14 ` [PATCH 4/5] add isolate pages vmstat KOSAKI Motohiro
2009-07-09  8:14   ` KOSAKI Motohiro
2009-07-09 10:22   ` Minchan Kim
2009-07-09 10:22     ` Minchan Kim
2009-07-09 20:43   ` Christoph Lameter
2009-07-09 20:43     ` Christoph Lameter
2009-07-10  2:11     ` KOSAKI Motohiro
2009-07-10  2:11       ` KOSAKI Motohiro
2009-07-10 18:48       ` Christoph Lameter
2009-07-10 18:48         ` Christoph Lameter
2009-07-13  1:50         ` KOSAKI Motohiro
2009-07-13  1:50           ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5384A4.7060108@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan.kim@gmail.com \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.