From: Jiri Slaby <jirislaby@gmail.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Matthias Pfaller <leo@marco.de>, linux-kernel@vger.kernel.org
Subject: Re: Bug in dmi_get_year (causing apic not getting enabled)
Date: Wed, 08 Jul 2009 08:47:26 +0200 [thread overview]
Message-ID: <4A5440FE.6000708@gmail.com> (raw)
In-Reply-To: <m1iqi3wxai.fsf@fess.ebiederm.org>
On 07/08/2009 07:36 AM, Eric W. Biederman wrote:
> Matthias Pfaller <leo@marco.de> writes:
>
>> Hi,
>>
>> dmi_get_year extracts the year with:
>>
>> simple_strtoul(s, NULL, 0);
>>
>> for biosdates in 2008 and 2009 this will return 0 because 8 and 9 are no valid
>> octal digits. This will e.g. result in the apic not getting enabled.
>> Changing this to
>>
>> simple_strtoul(s, NULL, 10);
>>
>> should fix the problem.
>
> Only if there is a leading 0....
Yes, 4-digit year is required as of smbios 2.3 (1998). There are broken
BIOSes out there though. So there is no need to guess base if we know
it. I sent a fix for this yesterday. Any objections?
prev parent reply other threads:[~2009-07-08 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 16:06 Bug in dmi_get_year (causing apic not getting enabled) Matthias Pfaller
2009-07-08 5:36 ` Eric W. Biederman
2009-07-08 6:47 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5440FE.6000708@gmail.com \
--to=jirislaby@gmail.com \
--cc=ebiederm@xmission.com \
--cc=leo@marco.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.