From: ebiederm@xmission.com (Eric W. Biederman)
To: Matthias Pfaller <leo@marco.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Bug in dmi_get_year (causing apic not getting enabled)
Date: Tue, 07 Jul 2009 22:36:53 -0700 [thread overview]
Message-ID: <m1iqi3wxai.fsf@fess.ebiederm.org> (raw)
In-Reply-To: <4A53728B.9020703@marco.de> (Matthias Pfaller's message of "Tue\, 07 Jul 2009 18\:06\:35 +0200")
Matthias Pfaller <leo@marco.de> writes:
> Hi,
>
> dmi_get_year extracts the year with:
>
> simple_strtoul(s, NULL, 0);
>
> for biosdates in 2008 and 2009 this will return 0 because 8 and 9 are no valid
> octal digits. This will e.g. result in the apic not getting enabled.
> Changing this to
>
> simple_strtoul(s, NULL, 10);
>
> should fix the problem.
Only if there is a leading 0....
Eric
next prev parent reply other threads:[~2009-07-08 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 16:06 Bug in dmi_get_year (causing apic not getting enabled) Matthias Pfaller
2009-07-08 5:36 ` Eric W. Biederman [this message]
2009-07-08 6:47 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1iqi3wxai.fsf@fess.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=leo@marco.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.