From: Patrick Colp <Patrick.Colp@citrix.com>
To: Neil Turton <nturton@solarflare.com>
Cc: Wei Huang <wei.huang2@amd.com>,
"'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH]Fix vlapic.h type
Date: Wed, 8 Jul 2009 10:31:03 +0100 [thread overview]
Message-ID: <4A546757.5030205@citrix.com> (raw)
In-Reply-To: <4A5463A6.5030001@solarflare.com>
Neil Turton wrote:
> Patrick Colp wrote:
>> Good catch. This line:
>>
>> #define vlapic_vcpu(vpic) (container_of((vpic), struct vcpu, \
>> arch.hvm_vcpu.vlapic))
>>
>> should probably also be changed to this:
>>
>> #define vlapic_vcpu(vlapic) (container_of((vlapic), struct vcpu, \
>> arch.hvm_vcpu.vlapic))
>
> I'm not sure. Do you intend to change the member name after hvm_vcpu
> based on the macro parameter?
No. Why would I do that?
The issue here is that the macro parameter is referring to a vlapic and not a
vpic (which is something different). So for the sake of clarity, it should be
changed to vlapic instead of vpic.
Patrick
next prev parent reply other threads:[~2009-07-08 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 21:20 [PATCH]Fix vlapic.h type Wei Huang
2009-07-08 7:32 ` Patrick Colp
2009-07-08 9:15 ` Neil Turton
2009-07-08 9:31 ` Patrick Colp [this message]
2009-07-08 9:33 ` Tim Deegan
2009-07-08 9:35 ` Neil Turton
2009-07-08 9:38 ` Patrick Colp
2009-07-08 9:58 ` Neil Turton
2009-07-08 9:42 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A546757.5030205@citrix.com \
--to=patrick.colp@citrix.com \
--cc=nturton@solarflare.com \
--cc=wei.huang2@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.