* [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL test
@ 2009-07-11 8:32 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2009-07-11 8:32 UTC (permalink / raw)
To: jirislaby, gregkh, devel, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Apparently, the NULL test is not necessary at this point.
The semantic patch that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E = NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/staging/otus/wwrap.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
index 4db8f6e..855ff41 100644
--- a/drivers/staging/otus/wwrap.c
+++ b/drivers/staging/otus/wwrap.c
@@ -1018,11 +1018,6 @@ void kevent(struct work_struct *work)
container_of(work, struct usbdrv_private, kevent);
zdev_t *dev = macp->device;
- if (macp = NULL)
- {
- return;
- }
-
if (test_and_set_bit(0, (void *)&smp_kevent_Lock))
{
//schedule_work(&macp->kevent);
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL test
@ 2009-07-11 8:32 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2009-07-11 8:32 UTC (permalink / raw)
To: jirislaby, gregkh, devel, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Apparently, the NULL test is not necessary at this point.
The semantic patch that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/staging/otus/wwrap.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
index 4db8f6e..855ff41 100644
--- a/drivers/staging/otus/wwrap.c
+++ b/drivers/staging/otus/wwrap.c
@@ -1018,11 +1018,6 @@ void kevent(struct work_struct *work)
container_of(work, struct usbdrv_private, kevent);
zdev_t *dev = macp->device;
- if (macp == NULL)
- {
- return;
- }
-
if (test_and_set_bit(0, (void *)&smp_kevent_Lock))
{
//schedule_work(&macp->kevent);
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL test
2009-07-11 8:32 ` Julia Lawall
@ 2009-07-11 8:33 ` Jiri Slaby
-1 siblings, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2009-07-11 8:33 UTC (permalink / raw)
To: Julia Lawall; +Cc: gregkh, devel, linux-kernel, kernel-janitors
On 07/11/2009 10:32 AM, Julia Lawall wrote:
> Apparently, the NULL test is not necessary at this point.
>
> The semantic patch that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL
2009-07-11 8:32 ` Julia Lawall
@ 2009-07-11 17:04 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2009-07-11 17:04 UTC (permalink / raw)
To: Julia Lawall; +Cc: jirislaby, devel, linux-kernel, kernel-janitors
On Sat, Jul 11, 2009 at 10:32:23AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Apparently, the NULL test is not necessary at this point.
>
> The semantic patch that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> expression E;
> identifier i,fld;
> statement S;
> @@
>
> - T i = E->fld;
> + T i;
> ... when != E
> when != i
> if (E = NULL) S
> + i = E->fld;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/staging/otus/wwrap.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> index 4db8f6e..855ff41 100644
> --- a/drivers/staging/otus/wwrap.c
> +++ b/drivers/staging/otus/wwrap.c
> @@ -1018,11 +1018,6 @@ void kevent(struct work_struct *work)
> container_of(work, struct usbdrv_private, kevent);
> zdev_t *dev = macp->device;
>
> - if (macp = NULL)
> - {
> - return;
> - }
> -
Ok, that will teach me to read all of my mail before responding... :)
This looks good, I'll queue it up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL test
@ 2009-07-11 17:04 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2009-07-11 17:04 UTC (permalink / raw)
To: Julia Lawall; +Cc: jirislaby, devel, linux-kernel, kernel-janitors
On Sat, Jul 11, 2009 at 10:32:23AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Apparently, the NULL test is not necessary at this point.
>
> The semantic patch that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @@
> type T;
> expression E;
> identifier i,fld;
> statement S;
> @@
>
> - T i = E->fld;
> + T i;
> ... when != E
> when != i
> if (E == NULL) S
> + i = E->fld;
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/staging/otus/wwrap.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> index 4db8f6e..855ff41 100644
> --- a/drivers/staging/otus/wwrap.c
> +++ b/drivers/staging/otus/wwrap.c
> @@ -1018,11 +1018,6 @@ void kevent(struct work_struct *work)
> container_of(work, struct usbdrv_private, kevent);
> zdev_t *dev = macp->device;
>
> - if (macp == NULL)
> - {
> - return;
> - }
> -
Ok, that will teach me to read all of my mail before responding... :)
This looks good, I'll queue it up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-07-11 17:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-11 8:32 [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL test Julia Lawall
2009-07-11 8:32 ` Julia Lawall
2009-07-11 8:33 ` Jiri Slaby
2009-07-11 8:33 ` Jiri Slaby
2009-07-11 17:04 ` [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL Greg KH
2009-07-11 17:04 ` [PATCH 5/5, revised] staging/otus: Drop an unnecessary NULL test Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.