* Re: [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board [not found] <E1MQNDW-0007ur-Rm@melo.openembedded.org> @ 2009-07-13 18:05 ` Marcin Juszkiewicz 2009-07-13 18:52 ` Denys Dmytriyenko 0 siblings, 1 reply; 6+ messages in thread From: Marcin Juszkiewicz @ 2009-07-13 18:05 UTC (permalink / raw) To: openembedded-devel Dnia poniedziałek, 13 lipca 2009 o 17:13:22 git version control napisał(a): > Author: Marco Cavallini <m.cavallini@koansoftware.com> > Date: Mon Jul 13 17:12:49 2009 +0200 > > Added linux version recipes/linux/linux-2.6.29 for taskit Stamp9G20 > Evaluation Board > * based on a patch from http://www.armbedded.eu/documentation > Author: Marco Cavallini <m.cavallini@koansoftware.com> > Date: Mon Jul 13 17:09:02 2009 +0200 > > Added linux version recipes/linux/linux_2.6.29.bb for taskit Stamp9G20 > Evaluation Board > * based on a patch from http://www.armbedded.eu/documentation > * bump PR Please read CommitPolicy in wiki - first line of commit is summary and should fit in 7x chars (weekly changelog script cuts at 78 chars) and next lines are used for description. Also those two changes should be squashed into one ("git rebase -i origin" would be useful command for next patch set). So commit would be better in this style: linux: added taskit Stamp9G20 board support in 2.6.29 * based on a patch from http://www.armbedded.eu/documentation And as this is new machine which do not change others bumping of PR is not necessary. Regards, -- JID: hrw@jabber.org Website: http://marcin.juszkiewicz.com.pl/ LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board 2009-07-13 18:05 ` [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board Marcin Juszkiewicz @ 2009-07-13 18:52 ` Denys Dmytriyenko 2009-07-13 20:07 ` Cliff Brake 0 siblings, 1 reply; 6+ messages in thread From: Denys Dmytriyenko @ 2009-07-13 18:52 UTC (permalink / raw) To: openembedded-devel On Mon, Jul 13, 2009 at 08:05:08PM +0200, Marcin Juszkiewicz wrote: > Dnia poniedzia??ek, 13 lipca 2009 o 17:13:22 git version control > napisa??(a): > > Please read CommitPolicy in wiki - first line of commit is summary and > should fit in 7x chars (weekly changelog script cuts at 78 chars) and > next lines are used for description. Also those two changes should be > squashed into one ("git rebase -i origin" would be useful command for > next patch set). Aren't policies required to be read by new developers when git access is granted? There used to be a welcome message sent by Mickey with helpful links to the Wiki. Is it still the case? Just wondering... -- Denys ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board 2009-07-13 18:52 ` Denys Dmytriyenko @ 2009-07-13 20:07 ` Cliff Brake 2009-07-13 20:19 ` Marco Cavallini 2009-07-16 3:37 ` Rolf Leggewie 0 siblings, 2 replies; 6+ messages in thread From: Cliff Brake @ 2009-07-13 20:07 UTC (permalink / raw) To: openembedded-devel On Mon, Jul 13, 2009 at 2:52 PM, Denys Dmytriyenko<denis@denix.org> wrote: > On Mon, Jul 13, 2009 at 08:05:08PM +0200, Marcin Juszkiewicz wrote: >> Dnia poniedzia??ek, 13 lipca 2009 o 17:13:22 git version control >> napisa??(a): >> >> Please read CommitPolicy in wiki - first line of commit is summary and >> should fit in 7x chars (weekly changelog script cuts at 78 chars) and >> next lines are used for description. Also those two changes should be >> squashed into one ("git rebase -i origin" would be useful command for >> next patch set). > > Aren't policies required to be read by new developers when git access is > granted? There used to be a welcome message sent by Mickey with helpful links > to the Wiki. Is it still the case? Just wondering... I have not seen such a message, but I suggest that http://wiki.openembedded.net/index.php/New_commit_rights be updated to contain any relevant information. I'll start sending a link to this page with new commit rights that I add. Thanks, Cliff ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board 2009-07-13 20:07 ` Cliff Brake @ 2009-07-13 20:19 ` Marco Cavallini 2009-07-13 20:34 ` Denys Dmytriyenko 2009-07-16 3:37 ` Rolf Leggewie 1 sibling, 1 reply; 6+ messages in thread From: Marco Cavallini @ 2009-07-13 20:19 UTC (permalink / raw) To: openembedded-devel Cliff Brake ha scritto: > On Mon, Jul 13, 2009 at 2:52 PM, Denys Dmytriyenko<denis@denix.org> wrote: >> On Mon, Jul 13, 2009 at 08:05:08PM +0200, Marcin Juszkiewicz wrote: >>> Dnia poniedzia??ek, 13 lipca 2009 o 17:13:22 git version control >>> napisa??(a): >>> >>> Please read CommitPolicy in wiki - first line of commit is summary and >>> should fit in 7x chars (weekly changelog script cuts at 78 chars) and >>> next lines are used for description. Also those two changes should be >>> squashed into one ("git rebase -i origin" would be useful command for >>> next patch set). >> Aren't policies required to be read by new developers when git access is >> granted? There used to be a welcome message sent by Mickey with helpful links >> to the Wiki. Is it still the case? Just wondering... > > I have not seen such a message, but I suggest that > http://wiki.openembedded.net/index.php/New_commit_rights be updated to > contain any relevant information. I'll start sending a link to this > page with new commit rights that I add. Yes, if there are so many rules, would be a good idea to document all them in a signle place :-) I did my best updating what is editable : http://wiki.openembedded.net/index.php/Commit_log_example /marco ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board 2009-07-13 20:19 ` Marco Cavallini @ 2009-07-13 20:34 ` Denys Dmytriyenko 0 siblings, 0 replies; 6+ messages in thread From: Denys Dmytriyenko @ 2009-07-13 20:34 UTC (permalink / raw) To: openembedded-devel On Mon, Jul 13, 2009 at 10:19:30PM +0200, Marco Cavallini wrote: > Cliff Brake ha scritto: > > On Mon, Jul 13, 2009 at 2:52 PM, Denys Dmytriyenko<denis@denix.org> wrote: > >> On Mon, Jul 13, 2009 at 08:05:08PM +0200, Marcin Juszkiewicz wrote: > >>> Dnia poniedzia??ek, 13 lipca 2009 o 17:13:22 git version control > >>> napisa??(a): > >>> > >>> Please read CommitPolicy in wiki - first line of commit is summary and > >>> should fit in 7x chars (weekly changelog script cuts at 78 chars) and > >>> next lines are used for description. Also those two changes should be > >>> squashed into one ("git rebase -i origin" would be useful command for > >>> next patch set). > >> Aren't policies required to be read by new developers when git access is > >> granted? There used to be a welcome message sent by Mickey with helpful links > >> to the Wiki. Is it still the case? Just wondering... > > > > I have not seen such a message, but I suggest that > > http://wiki.openembedded.net/index.php/New_commit_rights be updated to > > contain any relevant information. I'll start sending a link to this > > page with new commit rights that I add. > > Yes, if there are so many rules, would be a good idea to document all > them in a signle place :-) > I did my best updating what is editable : > http://wiki.openembedded.net/index.php/Commit_log_example Thanks. Taking into consideration the policies and common practices of other git-based projects, especially kernel.org ones, there are some small changes/nitpicks to consider: - separate the short one-line description and the long description (if present) with an empty line. That would help with extracting and applying patches using git (git-format-patch/git-am), because the short decription becomes the Subject of the patch/email and if there is no emtpy line after it, the long description may get lost when the patch is sent over the email. - don't start every line of the long description with a star "*" - this one is not technical but aestetical... Everything else seems fine and corresponds to the common practices of the Open Source Community. :) -- Denys ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board 2009-07-13 20:07 ` Cliff Brake 2009-07-13 20:19 ` Marco Cavallini @ 2009-07-16 3:37 ` Rolf Leggewie 1 sibling, 0 replies; 6+ messages in thread From: Rolf Leggewie @ 2009-07-16 3:37 UTC (permalink / raw) To: openembedded-devel Cliff Brake wrote: > I have not seen such a message, but I suggest that > http://wiki.openembedded.net/index.php/New_commit_rights be updated to > contain any relevant information. I'll start sending a link to this > page with new commit rights that I add. Actually, that page should eventually be folded into http://wiki.openembedded.net/index.php/New_Dev and then die. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-07-16 3:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1MQNDW-0007ur-Rm@melo.openembedded.org>
2009-07-13 18:05 ` [oe-commits] Marco Cavallini : Added linux version recipes/linux/linux-2.6. 29 for taskit Stamp9G20 Evaluation Board Marcin Juszkiewicz
2009-07-13 18:52 ` Denys Dmytriyenko
2009-07-13 20:07 ` Cliff Brake
2009-07-13 20:19 ` Marco Cavallini
2009-07-13 20:34 ` Denys Dmytriyenko
2009-07-16 3:37 ` Rolf Leggewie
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.