From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 2/3] mm: shrink_inactive_lis() nr_scan accounting fix fix
Date: Wed, 15 Jul 2009 22:10:17 -0400 [thread overview]
Message-ID: <4A5E8C09.1030406@redhat.com> (raw)
In-Reply-To: <20090716095241.9D0D.A69D9226@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> Subject: [PATCH] mm: shrink_inactive_lis() nr_scan accounting fix fix
>
> If sc->isolate_pages() return 0, we don't need to call shrink_page_list().
> In past days, shrink_inactive_list() handled it properly.
>
> But commit fb8d14e1 (three years ago commit!) breaked it. current shrink_inactive_list()
> always call shrink_page_list() although isolate_pages() return 0.
>
> This patch restore proper return value check.
>
>
> Requirements:
> o "nr_taken == 0" condition should stay before calling shrink_page_list().
> o "nr_taken == 0" condition should stay after nr_scan related statistics
> modification.
>
>
> Cc: Wu Fengguang <fengguang.wu@intel.com>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Minchan Kim <minchan.kim@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 2/3] mm: shrink_inactive_lis() nr_scan accounting fix fix
Date: Wed, 15 Jul 2009 22:10:17 -0400 [thread overview]
Message-ID: <4A5E8C09.1030406@redhat.com> (raw)
In-Reply-To: <20090716095241.9D0D.A69D9226@jp.fujitsu.com>
KOSAKI Motohiro wrote:
> Subject: [PATCH] mm: shrink_inactive_lis() nr_scan accounting fix fix
>
> If sc->isolate_pages() return 0, we don't need to call shrink_page_list().
> In past days, shrink_inactive_list() handled it properly.
>
> But commit fb8d14e1 (three years ago commit!) breaked it. current shrink_inactive_list()
> always call shrink_page_list() although isolate_pages() return 0.
>
> This patch restore proper return value check.
>
>
> Requirements:
> o "nr_taken == 0" condition should stay before calling shrink_page_list().
> o "nr_taken == 0" condition should stay after nr_scan related statistics
> modification.
>
>
> Cc: Wu Fengguang <fengguang.wu@intel.com>
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-16 2:10 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 0:51 [PATCH 0/3] Account the number of isolate pages KOSAKI Motohiro
2009-07-16 0:51 ` KOSAKI Motohiro
2009-07-16 0:52 ` [PATCH 1/3] Rename pgmoved variable in shrink_active_list() KOSAKI Motohiro
2009-07-16 0:52 ` KOSAKI Motohiro
2009-07-16 2:08 ` Rik van Riel
2009-07-16 2:08 ` Rik van Riel
2009-07-16 3:16 ` Andrew Morton
2009-07-16 3:16 ` Andrew Morton
2009-07-16 4:01 ` Minchan Kim
2009-07-16 4:01 ` Minchan Kim
2009-07-16 4:22 ` KOSAKI Motohiro
2009-07-16 4:22 ` KOSAKI Motohiro
2009-07-16 4:35 ` Andrew Morton
2009-07-16 4:35 ` Andrew Morton
2009-07-16 4:38 ` KOSAKI Motohiro
2009-07-16 4:38 ` KOSAKI Motohiro
2009-07-16 4:46 ` KOSAKI Motohiro
2009-07-16 4:46 ` KOSAKI Motohiro
2009-07-16 4:49 ` Andrew Morton
2009-07-16 4:49 ` Andrew Morton
2009-07-16 4:00 ` Minchan Kim
2009-07-16 4:00 ` Minchan Kim
2009-07-16 12:33 ` Wu Fengguang
2009-07-16 12:33 ` Wu Fengguang
2009-07-16 14:11 ` Christoph Lameter
2009-07-16 14:11 ` Christoph Lameter
2009-07-16 17:32 ` Johannes Weiner
2009-07-16 17:32 ` Johannes Weiner
2009-07-17 5:43 ` KOSAKI Motohiro
2009-07-17 5:43 ` KOSAKI Motohiro
2009-07-16 0:53 ` [PATCH 2/3] mm: shrink_inactive_lis() nr_scan accounting fix fix KOSAKI Motohiro
2009-07-16 0:53 ` KOSAKI Motohiro
2009-07-16 2:10 ` Rik van Riel [this message]
2009-07-16 2:10 ` Rik van Riel
2009-07-16 4:10 ` Minchan Kim
2009-07-16 4:10 ` Minchan Kim
2009-07-16 12:55 ` Wu Fengguang
2009-07-16 12:55 ` Wu Fengguang
2009-07-17 0:16 ` KOSAKI Motohiro
2009-07-17 0:16 ` KOSAKI Motohiro
2009-07-16 0:55 ` [PATCH 3/3] add isolate pages vmstat KOSAKI Motohiro
2009-07-16 0:55 ` KOSAKI Motohiro
2009-07-16 3:16 ` Andrew Morton
2009-07-16 3:16 ` Andrew Morton
2009-07-16 4:22 ` Minchan Kim
2009-07-16 4:22 ` Minchan Kim
2009-07-16 4:35 ` KOSAKI Motohiro
2009-07-16 4:35 ` KOSAKI Motohiro
2009-07-16 14:26 ` Christoph Lameter
2009-07-16 14:26 ` Christoph Lameter
2009-07-17 7:00 ` KOSAKI Motohiro
2009-07-17 7:00 ` KOSAKI Motohiro
2009-07-17 16:34 ` Christoph Lameter
2009-07-17 16:34 ` Christoph Lameter
2009-07-20 5:39 ` KOSAKI Motohiro
2009-07-20 5:39 ` KOSAKI Motohiro
2009-07-20 15:27 ` Christoph Lameter
2009-07-20 15:27 ` Christoph Lameter
2009-07-20 16:22 ` KOSAKI Motohiro
2009-07-20 16:22 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5E8C09.1030406@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.