All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH -mm] throttle direct reclaim when too many pages are isolated already
Date: Wed, 15 Jul 2009 23:47:59 -0400	[thread overview]
Message-ID: <4A5EA2EF.3050501@redhat.com> (raw)
In-Reply-To: <20090716124255.3d601efb.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote:

>> Am I overlooking something?
>>
> Reclaim from cgorup doesn't come from memory shortage but from
> "it hits limit". Then, it doen't necessary to reclaim pages from
> this zone. fallback to other zone is always ok.
> This will trigger unnecessary wait, I think.

Fair enough.

I'll also change the patch so tasks with a fatal signal
pending will go through congestion_wait at least once,
to give other tasks a chance to free up memory.

That should address everybody's concerns.

-- 
All rights reversed.

WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH -mm] throttle direct reclaim when too many pages are isolated already
Date: Wed, 15 Jul 2009 23:47:59 -0400	[thread overview]
Message-ID: <4A5EA2EF.3050501@redhat.com> (raw)
In-Reply-To: <20090716124255.3d601efb.kamezawa.hiroyu@jp.fujitsu.com>

KAMEZAWA Hiroyuki wrote:

>> Am I overlooking something?
>>
> Reclaim from cgorup doesn't come from memory shortage but from
> "it hits limit". Then, it doen't necessary to reclaim pages from
> this zone. fallback to other zone is always ok.
> This will trigger unnecessary wait, I think.

Fair enough.

I'll also change the patch so tasks with a fatal signal
pending will go through congestion_wait at least once,
to give other tasks a chance to free up memory.

That should address everybody's concerns.

-- 
All rights reversed.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-07-16  3:48 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-16  2:38 [PATCH -mm] throttle direct reclaim when too many pages are isolated already Rik van Riel
2009-07-16  2:38 ` Rik van Riel
2009-07-16  2:48 ` Andrew Morton
2009-07-16  2:48   ` Andrew Morton
2009-07-16  3:10   ` Rik van Riel
2009-07-16  3:10     ` Rik van Riel
2009-07-16  3:21     ` Andrew Morton
2009-07-16  3:21       ` Andrew Morton
2009-07-16  3:28       ` Rik van Riel
2009-07-16  3:28         ` Rik van Riel
2009-07-16  3:38         ` Andrew Morton
2009-07-16  3:38           ` Andrew Morton
2009-07-16  3:42           ` Rik van Riel
2009-07-16  3:42             ` Rik van Riel
2009-07-16  3:51             ` Andrew Morton
2009-07-16  3:51               ` Andrew Morton
2009-07-16  3:53           ` [PATCH -mm] throttle direct reclaim when too many pages are isolated already (v3) Rik van Riel
2009-07-16  3:53             ` Rik van Riel
2009-07-16  4:02             ` Andrew Morton
2009-07-16  4:02               ` Andrew Morton
2009-07-16  4:09               ` Rik van Riel
2009-07-16  4:09                 ` Rik van Riel
2009-07-16  4:26                 ` Andrew Morton
2009-07-16  4:26                   ` Andrew Morton
2009-07-29 15:04             ` Pavel Machek
2009-07-29 15:04               ` Pavel Machek
2009-07-29 16:19               ` Rik van Riel
2009-07-29 16:19                 ` Rik van Riel
2009-07-16  3:36   ` [PATCH -mm] throttle direct reclaim when too many pages are isolated already (v2) Rik van Riel
2009-07-16  3:36     ` Rik van Riel
2009-07-16  3:19 ` [PATCH -mm] throttle direct reclaim when too many pages are isolated already KAMEZAWA Hiroyuki
2009-07-16  3:19   ` KAMEZAWA Hiroyuki
2009-07-16  3:32   ` Rik van Riel
2009-07-16  3:32     ` Rik van Riel
2009-07-16  3:42     ` KAMEZAWA Hiroyuki
2009-07-16  3:42       ` KAMEZAWA Hiroyuki
2009-07-16  3:47       ` Rik van Riel [this message]
2009-07-16  3:47         ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5EA2EF.3050501@redhat.com \
    --to=riel@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.