From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
kvm <kvm@vger.kernel.org>,
DLE <dle-develop@lists.sourceforge.net>,
Jim Keniston <jkenisto@us.ibm.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Avi Kivity <avi@redhat.com>,
Przemys??awPawe??czyk <przemyslaw@pawelczyk.it>
Subject: Re: [PATCH -tip -v12 01/11] x86: instruction decoder API
Date: Thu, 16 Jul 2009 13:28:54 -0400 [thread overview]
Message-ID: <4A5F6356.9080505@redhat.com> (raw)
In-Reply-To: <20090716163708.GB5804@merkur.ravnborg.org>
Sam Ravnborg wrote:
>> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
>> new file mode 100644
>> index 0000000..01e079a
>> --- /dev/null
>> +++ b/arch/x86/include/asm/inat.h
>> @@ -0,0 +1,125 @@
>> +#ifndef _ASM_INAT_INAT_H
>> +#define _ASM_INAT_INAT_H
>
> [With reference to comment on patch 2/12...]
> You create inat.h here.
> Could you investigave what is needed to factor out the stuff
> needed from userspace so we can avoid the ugly havk where
> you redefine types.h?
Sorry, I'm a bit confusing.
Would you mean that I should break down user_include.h and
add those redefined types in inat.h?
> Maybe create a inat_types.h + inat.h as we do in other cases?
And inat_types.h has two parts, one for kernel, and one for
userspace(which is moved from user_include.h), is that right?
Thank you,
>
> Same for the other files that requred the types.h hack.
>
> Sam
>
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: Masami Hiramatsu <mhiramat@redhat.com>
To: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
systemtap <systemtap@sources.redhat.com>,
kvm <kvm@vger.kernel.org
Subject: Re: [PATCH -tip -v12 01/11] x86: instruction decoder API
Date: Thu, 16 Jul 2009 13:28:54 -0400 [thread overview]
Message-ID: <4A5F6356.9080505@redhat.com> (raw)
In-Reply-To: <20090716163708.GB5804@merkur.ravnborg.org>
Sam Ravnborg wrote:
>> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
>> new file mode 100644
>> index 0000000..01e079a
>> --- /dev/null
>> +++ b/arch/x86/include/asm/inat.h
>> @@ -0,0 +1,125 @@
>> +#ifndef _ASM_INAT_INAT_H
>> +#define _ASM_INAT_INAT_H
>
> [With reference to comment on patch 2/12...]
> You create inat.h here.
> Could you investigave what is needed to factor out the stuff
> needed from userspace so we can avoid the ugly havk where
> you redefine types.h?
Sorry, I'm a bit confusing.
Would you mean that I should break down user_include.h and
add those redefined types in inat.h?
> Maybe create a inat_types.h + inat.h as we do in other cases?
And inat_types.h has two parts, one for kernel, and one for
userspace(which is moved from user_include.h), is that right?
Thank you,
>
> Same for the other files that requred the types.h hack.
>
> Sam
>
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-07-16 17:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-16 15:56 [PATCH -tip -v12 00/11] tracing: kprobe-based event tracer and x86 instruction decoder Masami Hiramatsu
2009-07-16 15:56 ` Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 01/11] x86: instruction decoder API Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
2009-07-16 16:19 ` H. Peter Anvin
2009-07-16 16:52 ` Masami Hiramatsu
2009-07-16 16:37 ` Sam Ravnborg
2009-07-16 17:28 ` Masami Hiramatsu [this message]
2009-07-16 17:28 ` Masami Hiramatsu
2009-07-16 20:00 ` Sam Ravnborg
2009-07-16 20:48 ` Masami Hiramatsu
2009-07-16 20:48 ` Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 02/11] x86: x86 instruction decoder build-time selftest Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
2009-07-16 16:29 ` Sam Ravnborg
2009-07-16 17:37 ` Masami Hiramatsu
2009-07-16 17:37 ` Masami Hiramatsu
2009-07-16 19:40 ` Masami Hiramatsu
2009-07-16 19:40 ` Masami Hiramatsu
2009-07-16 19:55 ` Sam Ravnborg
2009-07-16 20:16 ` Masami Hiramatsu
2009-07-16 20:16 ` Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 03/11] kprobes: checks probe address is instruction boudary on x86 Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 04/11] kprobes: cleanup fix_riprel() using insn decoder " Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 05/11] x86: add pt_regs register and stack access APIs Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 06/11] tracing: ftrace dynamic ftrace_event_call support Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 07/11] tracing: Introduce TRACE_FIELD_ZERO() macro Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 08/11] tracing: add kprobe-based event tracer Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 09/11] tracing: Kprobe-tracer supports more than 6 arguments Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 10/11] tracing: Generate names for each kprobe event automatically Masami Hiramatsu
2009-07-16 15:57 ` [PATCH -tip -v12 11/11] tracing: Add kprobes event profiling interface Masami Hiramatsu
2009-07-16 15:57 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A5F6356.9080505@redhat.com \
--to=mhiramat@redhat.com \
--cc=ak@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=avi@redhat.com \
--cc=dle-develop@lists.sourceforge.net \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=jkenisto@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=przemyslaw@pawelczyk.it \
--cc=rostedt@goodmis.org \
--cc=srikar@linux.vnet.ibm.com \
--cc=systemtap@sources.redhat.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.