All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Ric Wheeler <rwheeler@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	David Woodhouse <dwmw2@infradead.org>,
	chris.mason@oracle.com, linux-btrfs@vger.kernel.org,
	neilb@suse.de, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/4] md: Factor out RAID6 algorithms into lib/
Date: Fri, 17 Jul 2009 11:40:34 -0400	[thread overview]
Message-ID: <4A609B72.2010901@zytor.com> (raw)
In-Reply-To: <4A609A52.7070506@redhat.com>

Ric Wheeler wrote:
>>
>> I have seen the papers; I'm not sure it really makes that much
>> difference. One of the things that bugs me about these papers is that he
>> compares to *his* implementation of my optimizations, but not to my
>> code. In real life implementations, on commodity hardware, we're limited
>> by memory and disk performance, not by CPU utilization.
>>
> 
> Fair enough - I thought that his coverage of the other open source 
> friendly encodings beyond RAID6 was actually quite interesting.
> 
> If you have specifics that you found unconvincing in his work, I am 
> pretty sure that he would be delighted to hear from you first hand. 
> James seemed to me to be very reasonable and very much a pro-Linux 
> academic, so I would love to be able to get him and his grad students 
> aligned in a useful way for us :-)
> 

The main flaw, as I said, is in the phrase "as implemented by the 
Jerasure library".  He's comparing his own implementations of various 
algorithms, not optimized implementations.

The bottom line is pretty much this: the cost of changing the encoding 
would appear to outweigh the benefit.  I'm not trying to claim the Linux 
RAID-6 implementation is optimal, but it is simple and appears to be 
fast enough that the math isn't the bottleneck.

	-hpa

  reply	other threads:[~2009-07-17 15:40 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-13 14:11 [PATCH 1/4] md: Factor out RAID6 algorithms into lib/ David Woodhouse
2009-07-15 19:23 ` Dan Williams
2009-07-15 20:16   ` Chris Mason
2009-07-15 22:11     ` Dan Williams
2009-07-15 22:11       ` Dan Williams
2009-07-16 17:38   ` H. Peter Anvin
2009-07-17 14:22     ` Ric Wheeler
2009-07-17 15:20       ` H. Peter Anvin
2009-07-17 15:35         ` Ric Wheeler
2009-07-17 15:40           ` H. Peter Anvin [this message]
2009-07-17 15:47             ` Ric Wheeler
2009-07-17 15:49               ` H. Peter Anvin
2009-07-17 15:58                 ` Ric Wheeler
2009-07-17 18:59                   ` Alex Elsayed
2009-07-17 19:02                     ` Alex Elsayed
2009-07-29 18:16                       ` H. Peter Anvin
2009-07-17 19:12                 ` Gregory Maxwell
2009-07-17 19:12                   ` Gregory Maxwell
2009-07-18 11:53                 ` David Woodhouse
2009-07-18 11:53                   ` David Woodhouse
2009-07-18 12:45                   ` H. Peter Anvin
2009-07-18 12:45                     ` H. Peter Anvin
2009-07-18 18:50                     ` Alex Elsayed
2009-07-18 18:52                       ` Alex Elsayed
2009-07-29 18:20                         ` H. Peter Anvin
2009-07-18 12:49                   ` Ric Wheeler
2009-07-18 12:49                     ` Ric Wheeler
2009-07-18 16:26                   ` Dan Williams
2009-07-18 16:26                     ` Dan Williams
2009-07-18 18:42                     ` David Woodhouse
2009-07-18 20:04                       ` Dan Williams
2009-07-19 18:04                         ` David Woodhouse
2009-07-20  5:21                           ` H. Peter Anvin
2009-07-17 15:51               ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A609B72.2010901@zytor.com \
    --to=hpa@zytor.com \
    --cc=chris.mason@oracle.com \
    --cc=dan.j.williams@intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=rwheeler@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.